[igt-dev] [PATCH i-g-t v12 0/5] DC states igt tests patch series v11

Anshuman Gupta
2019-05-08T06:36:36Z

This patch series adds new tests to validate Display C states.
DC states like DC5 and DC6 are validated during PSR entry/exit and during DPMS on/off cycle.

This is an update after fixing the IGT failure crashes in i915_pm_rpm
caused by enable/restore SATA link power changes in lib/igt_pm.c.

Below is the summary of major changes since first revision.

1. Changed the name of test from "pm_dc" to "i915_pm_dc" aligned to other PM tests.
2. Changed the DC5/6 counter check timeout from 1 sec to 3 sec,
as in case of PSR on some platfrom like KBL it requires more than 2 second to
disable 'DC off' power well after vblank event.
3. Changed the test name from tests/pm_dc to tests tests/i915/i915_pm_dc in
name of individual patch.
4. Addressed the review comment by saving POWER_DIR values in igt_disable_runtime_pm().
5. CI fixures for dc5-dpms failure.
Checking DC5 counter value after DPMS off, broke the dpms_on_off
function to dpms_on and dpms_off.
6. Used igt_pm_enable_sata_link_power_management() function in order to use
min_power policy for SATA.
7. igt_pm_enable_sata_link_power_management() function to restore the
original SATA link power policy using an exit handler.
8. IGT crashes fixture in i915_pm_rpm.c.

Jyoti Yadav (5):
lib/igt_pm: igt lib helper routines to support DC5/6 tests
tests/i915/i915_pm_dc: Added new test to verify Display C States
tests/i915/i915_pm_dc: Added test for DC6 during PSR
tests/i915/i915_pm_dc: Added test for DC5 during DPMS
tests/i915/i915_pm_dc: Added test for DC6 during DPMS

lib/igt_pm.c | 190 +++++++++++++++++++++------
lib/igt_pm.h | 6 +-
tests/Makefile.sources | 3 +
tests/i915/i915_pm_backlight.c | 6 +-
tests/i915/i915_pm_dc.c | 286 +++++++++++++++++++++++++++++++++++++++++
tests/i915/i915_pm_rpm.c | 24 +---
tests/meson.build | 1 +
7 files changed, 449 insertions(+), 67 deletions(-)
create mode 100644 tests/i915/i915_pm_dc.c