public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Anshuman Gupta <anshuman.gupta@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v5 3/4] igt/i915/i915_pm_lpsp: panel-fitter subtest modifications.
Date: Thu,  9 May 2019 17:28:03 +0530	[thread overview]
Message-ID: <1557403084-7803-4-git-send-email-anshuman.gupta@intel.com> (raw)
In-Reply-To: <1557403084-7803-1-git-send-email-anshuman.gupta@intel.com>

It makes sense to skip the test if edp-panel native resoultion
is limted to 1024x768 rather than failing the test.
Dumping i915_runtime_pm_status and i915_power_domain_info if
test fails.
Small improvment in panel-fitter condition which check
lpsp_enabled().

Cc: imre.deak@intel.com
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 tests/i915/i915_pm_lpsp.c | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/tests/i915/i915_pm_lpsp.c b/tests/i915/i915_pm_lpsp.c
index f699edc..0156957 100644
--- a/tests/i915/i915_pm_lpsp.c
+++ b/tests/i915/i915_pm_lpsp.c
@@ -201,10 +201,10 @@ static void edp_subtest(int drm_fd, drmModeResPtr drm_res,
 			 * support LPSP are too new for panels with native
 			 * 1024x768 resolution, so this should force the panel
 			 * fitter. */
-			igt_assert(c->count_modes &&
-				   c->modes[0].hdisplay > 1024);
-			igt_assert(c->count_modes &&
-				   c->modes[0].vdisplay > 768);
+			igt_require(c->count_modes &&
+				    c->modes[0].hdisplay > 1024);
+			igt_require(c->count_modes &&
+				    c->modes[0].vdisplay > 768);
 			mode = &std_1024_mode;
 			break;
 		}
@@ -223,16 +223,14 @@ static void edp_subtest(int drm_fd, drmModeResPtr drm_res,
 			    &connector->connector_id, 1, mode);
 	igt_assert_eq(rc, 0);
 
-	if (use_panel_fitter) {
-		if (IS_HASWELL(devid))
-			igt_assert(!lpsp_is_enabled(devid));
-		else
-			igt_assert(lpsp_is_enabled(devid));
-	} else {
+	if (use_panel_fitter && IS_HASWELL(devid))
+		igt_assert_f(!lpsp_is_enabled(devid),
+			     DUMP_DBGFS("i915_runtime_pm_status",
+					"i915_power_domain_info", fd));
+	else
 		igt_assert_f(lpsp_is_enabled(devid),
 			     DUMP_DBGFS("i915_runtime_pm_status",
 					"i915_power_domain_info", fd));
-	}
 }
 
 static void non_edp_subtest(int drm_fd, drmModeResPtr drm_res, uint32_t devid,
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-05-09 12:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-09 11:58 [igt-dev] [PATCH i-g-t v5 0/4] enable pm_lpsp for platforms till Gen11 v5 Anshuman Gupta
2019-05-09 11:58 ` [igt-dev] [PATCH i-g-t v5 1/4] igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11 Anshuman Gupta
2019-05-09 12:32   ` Animesh Manna
2019-05-09 11:58 ` [igt-dev] [PATCH i-g-t v5 2/4] igt/i915/i915_pm_lpsp check lpsp relevance on non edp panel Anshuman Gupta
2019-05-10  9:27   ` Animesh Manna
2019-05-09 11:58 ` Anshuman Gupta [this message]
2019-05-09 13:53   ` [igt-dev] [PATCH i-g-t v5 3/4] igt/i915/i915_pm_lpsp: panel-fitter subtest modifications Animesh Manna
2019-05-09 11:58 ` [igt-dev] [PATCH i-g-t v5 4/4] DO_NOT_MERGE add i915_pm_lpsp subtests to CI fast feedback list Anshuman Gupta
2019-05-09 13:36 ` [igt-dev] [PATCH i-g-t v5 0/4] enable pm_lpsp for platforms till Gen11 v5 Animesh Manna
2019-05-09 13:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-05-09 19:09 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1557403084-7803-4-git-send-email-anshuman.gupta@intel.com \
    --to=anshuman.gupta@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox