[igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add assert for drm_intel_bufmgr and intel_batchbuffer before usage

Swati Sharma
2019-08-08T12:43:09Z

if drm_intel_bufmgr_gem_init() or intel_batchbuffer_alloc()
returns NULL, it leads to seg fault as below:

root@testrunner:/home/testrunner/swati/otc_gen_graphics-intel-gpu-tools#
./tests/kms_big_fb
IGT-Version: 1.24-g976db91 (x86_64) (Linux: 5.1.0-rc6+ x86_64)
Max driver framebuffer size 8192x8192
RAM: 2749 MiB, GPU address space: 134217728 MiB, GGTT mappable size: 256
MiB
Received signal SIGSEGV.
Stack trace:
#0 [fatal_sig_handler+0x77]
#1 [killpg+0x40]
#2 [drm_intel_bo_alloc+0x0]
#3 [intel_batchbuffer_reset+0x33]
#4 [intel_batchbuffer_alloc+0x34]
#5 [__real_main603+0x3e9]
#6 [main+0x23]
#7 [__libc_start_main+0xf0]
#8 [_start+0x29]
#9 [<unknown>+0x29]
Segmentation fault (core dumped)

To prevent this igt_assert() is added for both the functions.

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
tests/kms_big_fb.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index c3498c6..69061a6 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -648,7 +648,10 @@ igt_main
data.render_copy = igt_get_render_copyfunc(data.devid);

data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096);
+ igt_assert(data.bufmgr);
+
data.batch = intel_batchbuffer_alloc(data.bufmgr, data.devid);
+ igt_assert(data.batch);
}

/*
--
1.9.1