Re: [igt-dev] [PATCH i-g-t] i915/gem_engine_topology: Introduce and use gem_context_clone_with_engines

Chris Wilson
2020-01-23T14:51:49Z

Quoting Tvrtko Ursulin (2020-01-23 14:48:24)
>
> On 23/01/2020 14:16, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2020-01-23 14:01:41)
> >>
> >> On 23/01/2020 13:16, Chris Wilson wrote:
> >>> Either way, I would suggest doing
> >>>
> >>> int __gem_context_clone_with_engines(int i915, uint32_t src, uint32_t *out);
> >>> uint32_t gem_context_clone_with_engines(int i915, uint32_t src);
> >>>
> >>> as I prefer that style of error message.
> >>
> >> Error message? What do you mean?
> >
> > igt_assert_eq(__gem_context_clone_with_engine(i915, src, &ctx), 0);
> > is the nicest assert message without using igt_assert_f and writing an
> > information message by hand.
>
> But you will get that, either helper gem_context_clone_with_engines
> calls uses that style.

Yeah, depends on whether you want to see the error for the underlying
ioctl and then have to look at the stack to work out we are in clone, or
if the clone itself is the interesting detail that wants to standout in
the assert message :)
-Chris