Re: [igt-dev] [PATCH i-g-t] tests/kms_cursor_legacy: increase timeout for nonblocking flip wait

Kahola, Mika
2020-03-09T11:19:05Z

On Wed, 2020-03-04 at 16:50 +0200, Juha-Pekka Heikkila wrote:
> When run on more than one monitor there may be modeset in queue
> which will block flip. Kernel will timeout with modeset at
> ten seconds so lets wait in test also that same ten seconds at
> maximum.
>
> V2 Ville Syrjälä: lets just wait for five seconds
Let's just do this.

Reviewed-by: Mika Kahola <mika.kahola@intel.com>

>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

> ---
> tests/kms_cursor_legacy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
> index f41f68d..d5f95b8 100644
> --- a/tests/kms_cursor_legacy.c
> +++ b/tests/kms_cursor_legacy.c
> @@ -251,7 +251,7 @@ static void flip_nonblocking(igt_display_t
> *display, enum pipe pipe_id, bool ato
> igt_plane_t *primary = igt_pipe_get_plane_type(pipe,
> DRM_PLANE_TYPE_PRIMARY);
> int ret;
>
> - igt_set_timeout(1, "Scheduling page flip\n");
> + igt_set_timeout(5, "Scheduling page flip\n");
> if (!atomic) {
> /* Schedule a nonblocking flip for the next vblank */
> do {