From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: remove redundant work
Date: Thu, 27 Feb 2020 15:27:03 +0200 [thread overview]
Message-ID: <1582810023-28424-1-git-send-email-juhapekka.heikkila@gmail.com> (raw)
removed fb does not take part into final crc comparisons.
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
tests/kms_rotation_crc.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index 58bebf3..164eade 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -54,7 +54,6 @@ typedef struct {
igt_display_t display;
struct igt_fb fb;
struct igt_fb fb_reference;
- struct igt_fb fb_unrotated;
struct igt_fb fb_flip;
igt_crc_t ref_crc;
igt_crc_t flip_crc;
@@ -156,7 +155,6 @@ static void remove_fbs(data_t *data)
{
igt_remove_fb(data->gfx_fd, &data->fb);
igt_remove_fb(data->gfx_fd, &data->fb_reference);
- igt_remove_fb(data->gfx_fd, &data->fb_unrotated);
igt_remove_fb(data->gfx_fd, &data->fb_flip);
}
@@ -306,17 +304,6 @@ static void prepare_fbs(data_t *data, igt_output_t *output,
igt_pipe_crc_get_current(display->drm_fd, data->pipe_crc, &data->ref_crc);
/*
- * Prepare the non-rotated reference fb.
- */
- igt_create_fb(data->gfx_fd, ref_w, ref_h, pixel_format, tiling, &data->fb_unrotated);
- paint_squares(data, IGT_ROTATION_0, &data->fb_unrotated, 1.0);
- igt_plane_set_fb(plane, &data->fb_unrotated);
- igt_plane_set_rotation(plane, IGT_ROTATION_0);
- if (plane->type != DRM_PLANE_TYPE_CURSOR)
- igt_plane_set_position(plane, data->pos_x, data->pos_y);
- igt_display_commit2(display, COMMIT_ATOMIC);
-
- /*
* Prepare the plane with an non-rotated fb let the hw rotate it.
*/
igt_create_fb(data->gfx_fd, w, h, pixel_format, tiling, &data->fb);
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2020-02-27 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 13:27 Juha-Pekka Heikkila [this message]
2020-02-27 15:02 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_rotation_crc: remove redundant work Patchwork
2020-02-28 14:42 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
2020-02-28 15:44 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1582810023-28424-1-git-send-email-juhapekka.heikkila@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox