From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id EACDD89CA4 for ; Wed, 4 Mar 2020 19:16:24 +0000 (UTC) From: Kunal Joshi Date: Wed, 4 Mar 2020 17:48:15 +0530 Message-Id: <1583324295-22013-1-git-send-email-kunal1.joshi@intel.com> Subject: [igt-dev] [PATCH i-g-t] tests/kms_chamelium: Add support to validate YUV pixel formats List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: igt-dev@lists.freedesktop.org Cc: Kunal Joshi , petri.latvala@intel.com List-ID: Currently, only hard coded pixel formats are validated which are not generic for all the platforms which leads to false alarms. Added support to validate only those pixel formats which are supported by platform. Signed-off-by: Kunal Joshi --- tests/kms_chamelium.c | 70 +++++++++++++++++++++++---------------------------- 1 file changed, 32 insertions(+), 38 deletions(-) diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c index 5c4a189..d6d63c6 100644 --- a/tests/kms_chamelium.c +++ b/tests/kms_chamelium.c @@ -2612,6 +2612,14 @@ static const struct edid *get_edid(enum test_edid edid) if (chamelium_port_get_type(port) == \ DRM_MODE_CONNECTOR_ ## type__) +#define connector_subtest_start(name__, type__) \ + igt_subtest_with_dynamic(name__) \ + for_each_port(p, port) \ + if (chamelium_port_get_type(port) == \ + DRM_MODE_CONNECTOR_ ## type__) { + +#define connector_subtest_end } + static data_t data; IGT_TEST_DESCRIPTION("Tests requiring a Chamelium board"); @@ -2872,44 +2880,30 @@ igt_main CHAMELIUM_CHECK_CRC); igt_describe(test_display_one_mode_desc); - connector_subtest("hdmi-cmp-nv12", HDMIA) - test_display_one_mode(&data, port, DRM_FORMAT_NV12, - CHAMELIUM_CHECK_CHECKERBOARD, 1); - - igt_describe(test_display_one_mode_desc); - connector_subtest("hdmi-cmp-nv16", HDMIA) - test_display_one_mode(&data, port, DRM_FORMAT_NV16, - CHAMELIUM_CHECK_CHECKERBOARD, 1); - - igt_describe(test_display_one_mode_desc); - connector_subtest("hdmi-cmp-nv21", HDMIA) - test_display_one_mode(&data, port, DRM_FORMAT_NV21, - CHAMELIUM_CHECK_CHECKERBOARD, 1); - - igt_describe(test_display_one_mode_desc); - connector_subtest("hdmi-cmp-nv61", HDMIA) - test_display_one_mode(&data, port, DRM_FORMAT_NV61, - CHAMELIUM_CHECK_CHECKERBOARD, 1); - - igt_describe(test_display_one_mode_desc); - connector_subtest("hdmi-cmp-yu12", HDMIA) - test_display_one_mode(&data, port, DRM_FORMAT_YUV420, - CHAMELIUM_CHECK_CHECKERBOARD, 1); - - igt_describe(test_display_one_mode_desc); - connector_subtest("hdmi-cmp-yu16", HDMIA) - test_display_one_mode(&data, port, DRM_FORMAT_YUV422, - CHAMELIUM_CHECK_CHECKERBOARD, 1); - - igt_describe(test_display_one_mode_desc); - connector_subtest("hdmi-cmp-yv12", HDMIA) - test_display_one_mode(&data, port, DRM_FORMAT_YVU420, - CHAMELIUM_CHECK_CHECKERBOARD, 1); - - igt_describe(test_display_one_mode_desc); - connector_subtest("hdmi-cmp-yv16", HDMIA) - test_display_one_mode(&data, port, DRM_FORMAT_YVU422, - CHAMELIUM_CHECK_CHECKERBOARD, 1); + connector_subtest_start("hdmi-yuv", HDMIA) + int k; + igt_output_t *output; + igt_plane_t *primary; + + output = prepare_output(&data, port, TEST_EDID_BASE); + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); + igt_assert(primary); + + for (k = 0; k < primary->format_mod_count; k++) { + + if (!igt_fb_supported_format(primary->formats[k])) + continue; + + if (!(igt_format_is_yuv(primary->formats[k]) + && primary->modifiers[k] != LOCAL_DRM_FORMAT_MOD_NONE)) + continue; + + igt_dynamic_f("%c%c%c%c", IGT_FORMAT_ARGS(primary->formats[k])) + test_display_one_mode(&data, port, primary->formats[k], + CHAMELIUM_CHECK_CHECKERBOARD, + 1); + } + connector_subtest_end igt_describe(test_display_planes_random_desc); connector_subtest("hdmi-cmp-planes-random", HDMIA) -- 2.7.4 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev