public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ashutosh Dixit <ashutosh.dixit@intel.com>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_tiled_wb: skip on devices without mappable aperture
Date: Tue, 19 May 2020 20:47:35 +0100	[thread overview]
Message-ID: <158991765572.8153.3177849308791104850@build.alporthouse.com> (raw)
In-Reply-To: <20200519190257.16709-1-ashutosh.dixit@intel.com>

Quoting Ashutosh Dixit (2020-05-19 20:02:57)
> From: Vanshidhar Konda <vanshidhar.r.konda@intel.com>
> 
> Skip on devices without mappable aperture.
> 
> Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
>  tests/i915/gem_tiled_wb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/i915/gem_tiled_wb.c b/tests/i915/gem_tiled_wb.c
> index b7f352fc7..b61a1b2e8 100644
> --- a/tests/i915/gem_tiled_wb.c
> +++ b/tests/i915/gem_tiled_wb.c
> @@ -139,6 +139,7 @@ igt_simple_main
>         uint32_t handle;
>  
>         fd = drm_open_driver(DRIVER_INTEL);
> +       gem_require_mappable_ggtt(fd);

To be precise, also

	igt_require(gem_available_fences() > 0);

and the ability to WB mmap. You'll note that even the mmap used here is
not yet supported on mmap-offset only HW.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2020-05-19 19:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 19:02 [igt-dev] [PATCH i-g-t] i915/gem_tiled_wb: skip on devices without mappable aperture Ashutosh Dixit
2020-05-19 19:47 ` Chris Wilson [this message]
2020-05-19 20:03 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-05-20  6:17 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=158991765572.8153.3177849308791104850@build.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox