From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB4706E019 for ; Tue, 4 Sep 2018 21:41:25 +0000 (UTC) From: "Souza, Jose" Date: Tue, 4 Sep 2018 21:41:21 +0000 Message-ID: <15a80c0cf8f7832a6dae469c0a4e9dbe2117fc24.camel@intel.com> References: <20180817085642.19501-1-maarten.lankhorst@linux.intel.com> In-Reply-To: <20180817085642.19501-1-maarten.lankhorst@linux.intel.com> Content-Language: en-US Content-ID: <952F702C9AFA044AB763C413D9874FBC@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v5 1/4] lib/psr: Add support for toggling edp psr through debugfs, v5. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "igt-dev@lists.freedesktop.org" , "maarten.lankhorst@linux.intel.com" List-ID: T24gRnJpLCAyMDE4LTA4LTE3IGF0IDEwOjU2ICswMjAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90 ZToNCj4gSXQncyBoYXJtZnVsIHRvIHdyaXRlIHRvIGVuYWJsZV9wc3IgYXQgcnVudGltZSwgYW5k IHRoZSBwYXRjaCB0aGF0DQo+IGFsbG93cw0KPiB1cyB0byBjaGFuZ2UgaTkxNV9lZHBfcHNyX2Rl YnVnIHdpdGggdGhlIHBhbmVsIHJ1bm5pbmcgd2lsbCByZXF1aXJlDQo+IHVzDQo+IHRvIGFiYW5k b24gdGhlIG1vZHVsZSBwYXJhbWV0ZXIuIEhlbmNlIHRoZSB1c2Vyc3BhY2UgY2hhbmdlIG5lZWRz IHRvDQo+IGJlDQo+IHB1dCBpbiBJR1QgZmlyc3QgYmVmb3JlIHdlIGNhbiBjaGFuZ2UgaXQgYXQg a2VybmVsIHRpbWUuDQo+IA0KPiBUb2dnbGluZyBpdCB0byBkZWJ1Z2ZzIHdpbGwgbWVhbiB3ZSBj YW4gc2tpcCBhIG1vZGVzZXQgd2hlbiBjaGFuZ2luZw0KPiBvdXINCj4gZmVhdHVyZSBzZXQuDQo+ IA0KPiBDaGFuZ2VzIHNpbmNlIHYxOg0KPiAtIFJlYmFzZSB3aXRoIHRoZSBwcmV2aW91cyBwYXRj aGVzIGRyb3BwZWQuDQo+IENoYW5nZXMgc2luY2UgdjI6DQo+IC0gUmViYXNlIG9uIHRvcCBvZiBu ZXcgYXBpIGluIGk5MTVfZWRwX3Bzcl9kZWJ1Zy4NCj4gQ2hhbmdlcyBzaW5jZSB2MzoNCj4gLSBF bmFibGUgSVJRIGRlYnVnZ2luZyBmb3IgZXh0cmEgbG9nZ2luZy4NCj4gLSBGb3JjZSBQU1IxIG1v ZGUuIChkaG5rcm4pDQo+IC0gTW92ZSBQU1IgZW5hYmxlL2Rpc2FibGUgZnVuY3Rpb25zIHRvIGxp Yi9pZ3RfcHNyLiAoZGhua3JuKQ0KPiBDaGFuZ2VzIHNpbmNlIHY0Og0KPiAtIFJlZGlzYWJsZSBp cnFzIHJpZ2h0IGF3YXkgd2hlbiBkZWJ1Z2ZzIGFwaSBkb2Vzbid0IHdvcmsuIChkaG5rcm4pDQo+ IC0gVXNlIGhleCBldmVyeXdoZXJlLiAoZGhua3JuKQ0KPiANCj4gU2lnbmVkLW9mZi1ieTogTWFh cnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4NCj4gLS0t DQo+ICBsaWIvaWd0X3Bzci5jICAgICAgICAgICAgICAgICAgICB8IDg2DQo+ICsrKysrKysrKysr KysrKysrKysrKysrKysrKysrKystDQo+ICBsaWIvaWd0X3Bzci5oICAgICAgICAgICAgICAgICAg ICB8ICAyICsNCj4gIHRlc3RzL2ttc19mcm9udGJ1ZmZlcl90cmFja2luZy5jIHwgIDYgKy0tDQo+ ICAzIGZpbGVzIGNoYW5nZWQsIDg5IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pDQo+IA0K PiBkaWZmIC0tZ2l0IGEvbGliL2lndF9wc3IuYyBiL2xpYi9pZ3RfcHNyLmMNCj4gaW5kZXggYzk3 OWIwYjU5OTM2Li42MTRjYWE2ZmQ4MDkgMTAwNjQ0DQo+IC0tLSBhL2xpYi9pZ3RfcHNyLmMNCj4g KysrIGIvbGliL2lndF9wc3IuYw0KPiBAQCAtMjEsNyArMjEsOSBAQA0KPiAgICogSU4gVEhFIFNP RlRXQVJFLg0KPiAgICovDQo+ICANCj4gLSNpbmNsdWRlICAiaWd0X3Bzci5oIg0KPiArI2luY2x1 ZGUgImlndF9wc3IuaCINCj4gKyNpbmNsdWRlICJpZ3Rfc3lzZnMuaCINCj4gKyNpbmNsdWRlIDxl cnJuby5oPg0KPiAgDQo+ICBib29sIHBzcl9hY3RpdmUoaW50IGZkLCBib29sIGNoZWNrX2FjdGl2 ZSkNCj4gIHsNCj4gQEAgLTM4LDMgKzQwLDg1IEBAIGJvb2wgcHNyX3dhaXRfZW50cnkoaW50IGZk KQ0KPiAgew0KPiAgCXJldHVybiBpZ3Rfd2FpdChwc3JfYWN0aXZlKGZkLCB0cnVlKSwgNTAwLCAx KTsNCj4gIH0NCj4gKw0KPiArc3RhdGljIHNzaXplX3QgcHNyX3dyaXRlKGludCBmZCwgY29uc3Qg Y2hhciAqYnVmKQ0KPiArew0KPiArCXJldHVybiBpZ3Rfc3lzZnNfd3JpdGUoZmQsICJpOTE1X2Vk cF9wc3JfZGVidWciLCBidWYsDQo+IHN0cmxlbihidWYpKTsNCj4gK30NCj4gKw0KPiArc3RhdGlj IGludCBoYXNfcHNyX2RlYnVnZnMoaW50IGZkKQ0KPiArew0KPiArCWludCByZXQ7DQo+ICsNCj4g KwkvKg0KPiArCSAqIENoZWNrIGlmIG5ldyBQU1IgZGVidWdmcyBhcGkgaXMgdXNhYmxlIGJ5IHdy aXRpbmcgYW4gaW52YWxpZA0KPiB2YWx1ZS4NCj4gKwkgKiBMZWdhY3kgbW9kZSB3aWxsIHJldHVy biBPSyBoZXJlLCBkZWJ1Z2ZzIGFwaSB3aWxsIHJldHVybg0KPiAtRUlOVkFMLg0KPiArCSAqIC1F Tk9ERVYgaXMgcmV0dXJuZWQuDQo+ICsJICovDQo+ICsJcmV0ID0gcHNyX3dyaXRlKGZkLCAiMHhm Iik7DQo+ICsJaWYgKHJldCA9PSAtRUlOVkFMKQ0KPiArCQlyZXR1cm4gMDsNCj4gKwllbHNlIGlm IChyZXQgPCAwKQ0KPiArCQlyZXR1cm4gcmV0Ow0KPiArDQo+ICsJLyogbGVnYWN5IGRlYnVnZnMg YXBpLCB3ZSBlbmFibGVkIGlycXMgYnkgd3JpdGluZywgZGlzYWJsZQ0KPiB0aGVtLiAqLw0KPiAr CXBzcl93cml0ZShmZCwgIjAiKTsNCj4gKwlyZXR1cm4gLUVJTlZBTDsNCj4gK30NCj4gKw0KPiAr c3RhdGljIGJvb2wgcHNyX21vZHBhcmFtX3NldChpbnQgdmFsKQ0KPiArew0KPiArCXN0YXRpYyBp bnQgb2xkdmFsID0gLTE7DQoNClRoaXMgbG9va3Mgd3JvbmcsIHdoeSBub3QgcmVhZCB0aGUgbW9k dWxlIHBhcmFtZXRlcj8gaXQgd2lsbCBndWFyYXRlZQ0KdGhhdCB0aGUgcmV0dXJuZWQgdmFsdWUg aXMgY29ycmVjdCBoZXJlIGlmIHNvbWV0aGluZyBlbHNlIGxlZnQgdGhlDQpwYXJhbWV0ZXIgd2l0 aCBhbm90aGVyIHZhbHVlLg0KDQo+ICsNCj4gKwlpZ3Rfc2V0X21vZHVsZV9wYXJhbV9pbnQoImVu YWJsZV9wc3IiLCB2YWwpOw0KPiArDQo+ICsJaWYgKHZhbCA9PSBvbGR2YWwpDQo+ICsJCXJldHVy biBmYWxzZTsNCj4gKw0KPiArCW9sZHZhbCA9IHZhbDsNCj4gKwlyZXR1cm4gdHJ1ZTsNCj4gK30N Cj4gKw0KPiArc3RhdGljIGludCBwc3JfcmVzdG9yZV9kZWJ1Z2ZzX2ZkID0gLTE7DQoNCk1heWJl IG1vdmUgdGhpcyB0byB0aGUgdG9wIG9mIHRoZSBmaWxlLg0KDQpPdGhlciB0aGFuIHRoYXQgTEdU TS4NCg0KPiArDQo+ICtzdGF0aWMgdm9pZCByZXN0b3JlX3Bzcl9kZWJ1Z2ZzKGludCBzaWcpDQo+ ICt7DQo+ICsJcHNyX3dyaXRlKHBzcl9yZXN0b3JlX2RlYnVnZnNfZmQsICIwIik7DQo+ICt9DQo+ ICsNCj4gK3N0YXRpYyBib29sIHBzcl9zZXQoaW50IGZkLCBib29sIGVuYWJsZSkNCj4gK3sNCj4g KwlpbnQgcmV0Ow0KPiArDQo+ICsJcmV0ID0gaGFzX3Bzcl9kZWJ1Z2ZzKGZkKTsNCj4gKwlpZiAo cmV0ID09IC1FTk9ERVYpIHsNCj4gKwkJaWd0X3NraXBfb25fZihlbmFibGUsICJQU1Igbm90IGF2 YWlsYWJsZVxuIik7DQo+ICsJCXJldHVybiBmYWxzZTsNCj4gKwl9DQo+ICsNCj4gKwlpZiAocmV0 ID09IC1FSU5WQUwpIHsNCj4gKwkJcmV0ID0gcHNyX21vZHBhcmFtX3NldChlbmFibGUpOw0KPiAr CX0gZWxzZSB7DQo+ICsJCXJldCA9IHBzcl93cml0ZShmZCwgZW5hYmxlID8gIjB4MyIgOiAiMHgx Iik7DQo+ICsJCWlndF9hc3NlcnQocmV0ID4gMCk7DQo+ICsJfQ0KPiArDQo+ICsJLyogUmVzdG9y ZSBvcmlnaW5hbCB2YWx1ZSBvbiBleGl0ICovDQo+ICsJaWYgKHBzcl9yZXN0b3JlX2RlYnVnZnNf ZmQgPT0gLTEpIHsNCj4gKwkJcHNyX3Jlc3RvcmVfZGVidWdmc19mZCA9IGR1cChmZCk7DQo+ICsJ CWlndF9hc3NlcnQocHNyX3Jlc3RvcmVfZGVidWdmc19mZCA+PSAwKTsNCj4gKwkJaWd0X2luc3Rh bGxfZXhpdF9oYW5kbGVyKHJlc3RvcmVfcHNyX2RlYnVnZnMpOw0KPiArCX0NCj4gKw0KPiArCXJl dHVybiByZXQ7DQo+ICt9DQo+ICsNCj4gK2Jvb2wgcHNyX2VuYWJsZShpbnQgZmQpDQo+ICt7DQo+ ICsJcmV0dXJuIHBzcl9zZXQoZmQsIHRydWUpOw0KPiArfQ0KPiArDQo+ICtib29sIHBzcl9kaXNh YmxlKGludCBmZCkNCj4gK3sNCj4gKwlyZXR1cm4gcHNyX3NldChmZCwgZmFsc2UpOw0KPiArfQ0K PiBkaWZmIC0tZ2l0IGEvbGliL2lndF9wc3IuaCBiL2xpYi9pZ3RfcHNyLmgNCj4gaW5kZXggOTgw Zjg1ZTA0YjNlLi4wZWYyMmMzZDEyNTggMTAwNjQ0DQo+IC0tLSBhL2xpYi9pZ3RfcHNyLmgNCj4g KysrIGIvbGliL2lndF9wc3IuaA0KPiBAQCAtMzAsNSArMzAsNyBAQA0KPiAgDQo+ICBib29sIHBz cl93YWl0X2VudHJ5KGludCBmZCk7DQo+ICBib29sIHBzcl9hY3RpdmUoaW50IGZkLCBib29sIGNo ZWNrX2FjdGl2ZSk7DQo+ICtib29sIHBzcl9lbmFibGUoaW50IGZkKTsNCj4gK2Jvb2wgcHNyX2Rp c2FibGUoaW50IGZkKTsNCj4gIA0KPiAgI2VuZGlmDQo+IGRpZmYgLS1naXQgYS90ZXN0cy9rbXNf ZnJvbnRidWZmZXJfdHJhY2tpbmcuYw0KPiBiL3Rlc3RzL2ttc19mcm9udGJ1ZmZlcl90cmFja2lu Zy5jDQo+IGluZGV4IDFkZmQ3YzFjZWU4ZC4uN2VhMmY2OTcxODRkIDEwMDY0NA0KPiAtLS0gYS90 ZXN0cy9rbXNfZnJvbnRidWZmZXJfdHJhY2tpbmcuYw0KPiArKysgYi90ZXN0cy9rbXNfZnJvbnRi dWZmZXJfdHJhY2tpbmcuYw0KPiBAQCAtOTQxLDggKzk0MSw2IEBAIHN0YXRpYyBib29sDQo+IGRy cnNfd2FpdF91bnRpbF9ycl9zd2l0Y2hfdG9fbG93KHZvaWQpDQo+ICANCj4gICNkZWZpbmUgZmJj X2VuYWJsZSgpIGlndF9zZXRfbW9kdWxlX3BhcmFtX2ludCgiZW5hYmxlX2ZiYyIsIDEpDQo+ICAj ZGVmaW5lIGZiY19kaXNhYmxlKCkgaWd0X3NldF9tb2R1bGVfcGFyYW1faW50KCJlbmFibGVfZmJj IiwgMCkNCj4gLSNkZWZpbmUgcHNyX2VuYWJsZSgpIGlndF9zZXRfbW9kdWxlX3BhcmFtX2ludCgi ZW5hYmxlX3BzciIsIDEpDQo+IC0jZGVmaW5lIHBzcl9kaXNhYmxlKCkgaWd0X3NldF9tb2R1bGVf cGFyYW1faW50KCJlbmFibGVfcHNyIiwgMCkNCj4gICNkZWZpbmUgZHJyc19lbmFibGUoKQlkcnJz X3NldCgxKQ0KPiAgI2RlZmluZSBkcnJzX2Rpc2FibGUoKQlkcnJzX3NldCgwKQ0KPiAgDQo+IEBA IC0xMTM3LDcgKzExMzUsNyBAQCBzdGF0aWMgdm9pZCBkaXNhYmxlX2ZlYXR1cmVzKGNvbnN0IHN0 cnVjdA0KPiB0ZXN0X21vZGUgKnQpDQo+ICAJCXJldHVybjsNCj4gIA0KPiAgCWZiY19kaXNhYmxl KCk7DQo+IC0JcHNyX2Rpc2FibGUoKTsNCj4gKwlwc3JfZGlzYWJsZShkcm0uZGVidWdmcyk7DQo+ ICAJZHJyc19kaXNhYmxlKCk7DQo+ICB9DQo+ICANCj4gQEAgLTE3MTksNyArMTcxNyw3IEBAIHN0 YXRpYyB2b2lkIGVuYWJsZV9mZWF0dXJlc19mb3JfdGVzdChjb25zdA0KPiBzdHJ1Y3QgdGVzdF9t b2RlICp0KQ0KPiAgCWlmICh0LT5mZWF0dXJlICYgRkVBVFVSRV9GQkMpDQo+ICAJCWZiY19lbmFi bGUoKTsNCj4gIAlpZiAodC0+ZmVhdHVyZSAmIEZFQVRVUkVfUFNSKQ0KPiAtCQlwc3JfZW5hYmxl KCk7DQo+ICsJCXBzcl9lbmFibGUoZHJtLmRlYnVnZnMpOw0KPiAgCWlmICh0LT5mZWF0dXJlICYg RkVBVFVSRV9EUlJTKQ0KPiAgCQlkcnJzX2VuYWJsZSgpOw0KPiAgfQ0KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0 LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==