Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
	igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] lib/xe: on xe driver use blitter for x-tile
Date: Fri, 22 Sep 2023 10:24:35 +0530	[thread overview]
Message-ID: <160cb1ad-d6ec-39b2-2c65-5f7517aefd17@intel.com> (raw)
In-Reply-To: <20230921163530.285456-1-juhapekka.heikkila@gmail.com>

Hi JP,

Since for xe, we want to use blitter generically, please update commit 
message and subject accordingly.

With above fixed.

LGTM
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 21-Sep-23 10:05 PM, Juha-Pekka Heikkila wrote:
> on xe driver need to use blitter for x-tile
> 
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
>   lib/igt_fb.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 4b592825d..c8a7b31a8 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -2557,7 +2557,8 @@ static bool use_blitter(const struct igt_fb *fb)
>   	return fb->modifier == I915_FORMAT_MOD_4_TILED ||
>   	       fb->modifier == I915_FORMAT_MOD_Y_TILED ||
>   	       fb->modifier == I915_FORMAT_MOD_Yf_TILED ||
> -	       (is_i915_device(fb->fd) && !gem_has_mappable_ggtt(fb->fd));
> +	       (is_i915_device(fb->fd) && !gem_has_mappable_ggtt(fb->fd)) ||
> +	       is_xe_device(fb->fd);
>   }
>   
>   static void init_buf_ccs(struct intel_buf *buf, int ccs_idx,

  parent reply	other threads:[~2023-09-22  4:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-21 16:35 [igt-dev] [PATCH i-g-t] lib/xe: on xe driver use blitter for x-tile Juha-Pekka Heikkila
2023-09-21 17:28 ` [igt-dev] ✓ CI.xeBAT: success for " Patchwork
2023-09-21 17:36 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2023-09-22  4:54 ` Sharma, Swati2 [this message]
2023-09-22 10:32   ` [igt-dev] [PATCH i-g-t] " Juha-Pekka Heikkila
2023-09-22  8:01 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2023-09-22 21:47 ` [igt-dev] [PATCH i-g-t] " Rodrigo Vivi
2023-09-25  8:02   ` Juha-Pekka Heikkila
2023-09-25 13:37     ` Rodrigo Vivi
2023-09-25 15:18       ` Juha-Pekka Heikkila
2023-09-25 17:42         ` Rodrigo Vivi
2023-09-25 20:52           ` Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160cb1ad-d6ec-39b2-2c65-5f7517aefd17@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juhapekka.heikkila@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox