Re: [PATCH i-g-t v8 6/6] tests/kms_flip: test suspend at most twice on SNB && BMG

Thasleem, Mohammed
2026-03-25T10:31:00Z

[-- Attachment #1: Type: text/plain, Size: 1372 bytes --]

On 09-03-2026 02:55 pm, Michał Grzelak wrote:
> gettime_us() on SNB and BMG does not return proper time after starting
> suspend tests. This results in too many suspends issued before we hit
> the duration_ms. Break the loop on second execution.
>
> Signed-off-by: Michał Grzelak<michal.grzelak@intel.com>
> ---
> tests/kms_flip.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index f17d027cc..3c5428ff0 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -1322,6 +1322,12 @@ static bool event_loop(struct test_output *o, unsigned duration_ms,
> {
> unsigned long start, end;
> int count = 0;
> + int devid;
> + bool wa;
> +
> + devid = intel_get_drm_devid(drm_fd);
> +
> + wa = IS_SANDYBRIDGE(devid) || IS_BATTLEMAGE(devid);
Why only two specific platforms?
I think, platform specific wa not needed here, instead we can have
generic execution for all,
which can work on all platforms.plz check.
>
> start = gettime_us();
>
> @@ -1342,6 +1348,9 @@ static bool event_loop(struct test_output *o, unsigned duration_ms,
> if (count && (gettime_us() - start) / 1000 >= duration_ms)
> break;
>
> + if (count && wa && o->flags & TEST_SUSPEND)

if (count && wa && o->flags & TEST_SUSPEND) --> if (count && o->flags & TEST_SUSPEND)

> + break;
> +
> count++;
> }
>

[-- Attachment #2: Type: text/html, Size: 2237 bytes --]