From: maitreye <maitreye@codeaurora.org>
To: igt-dev@lists.freedesktop.org
Cc: maitreye <maitreye@codeaurora.org>,
robdclark@gmail.com, seanpaul@chromium.org, swboyd@chromium.org,
nganji@codeaurora.org, aravindh@codeaurora.org,
abhinavk@codeaurora.org, khsieh@codeaurora.org,
manasi.d.navare@intel.com, petri.latvala@intel.com
Subject: [igt-dev] [PATCH i-g-t 1/2] lib/igt_fb: check device type before calling intel_get_drm_devid
Date: Wed, 4 Aug 2021 20:40:22 -0700 [thread overview]
Message-ID: <1628134823-27763-1-git-send-email-maitreye@codeaurora.org> (raw)
Check intel device type before calling intel_get_drm_devid
to avoid incorrect assertion failures while trying to use
create_bo_for_fb on non-intel targets. Otherwise it leads
to failures like below :
./msm_dp_compliance
found idx of failsafe mode = 17
(msm_dp_compliance:27338) intel_chipset-CRITICAL: Test assertion failure function
intel_get_drm_devid, file ../igt-gpu-tools-9999/lib/intel_chipset.c:132:
(msm_dp_compliance:27338) intel_chipset-CRITICAL:
Failed assertion: is_i915_device(fd)
(msm_dp_compliance:27338) intel_chipset-CRITICAL: Last errno: 2,
No such file or directory
Signed-off-by: maitreye <maitreye@codeaurora.org>
---
lib/igt_fb.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index ab52ea9..583cc9e 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -836,9 +836,11 @@ static uint64_t calc_plane_size(struct igt_fb *fb, int plane)
* On ADL_P CCS color planes must be 2MB aligned, until remapping
* support is added for CCS FBs.
*/
- if (IS_ALDERLAKE_P(intel_get_drm_devid(fb->fd)) &&
- is_ccs_modifier(fb->modifier))
- size = ALIGN(size, 2 * 1024 * 1024);
+ if (is_i915_device(fb->fd)) {
+ if (IS_ALDERLAKE_P(intel_get_drm_devid(fb->fd)) &&
+ is_ccs_modifier(fb->modifier))
+ size = ALIGN(size,2 * 1024 * 1024);
+ }
return size;
}
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next reply other threads:[~2021-08-05 3:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 3:40 maitreye [this message]
2021-08-05 3:40 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_fb: add an API to support color square DP CTS pattern maitreye
2021-08-12 21:00 ` maitreye
2021-08-13 11:33 ` Petri Latvala
[not found] ` <4951ee20ab1d8446e08de1c6dc09bd93@codeaurora.org>
2022-02-15 1:49 ` Abhinav Kumar
2021-08-05 3:55 ` [igt-dev] ✗ Fi.CI.BUILD: failure for series starting with [i-g-t,1/2] lib/igt_fb: check device type before calling intel_get_drm_devid Patchwork
2021-08-06 16:38 ` [igt-dev] [PATCH i-g-t 1/2] " Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1628134823-27763-1-git-send-email-maitreye@codeaurora.org \
--to=maitreye@codeaurora.org \
--cc=abhinavk@codeaurora.org \
--cc=aravindh@codeaurora.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=khsieh@codeaurora.org \
--cc=manasi.d.navare@intel.com \
--cc=nganji@codeaurora.org \
--cc=petri.latvala@intel.com \
--cc=robdclark@gmail.com \
--cc=seanpaul@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox