From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5935789FD9 for ; Tue, 28 May 2019 10:56:22 +0000 (UTC) References: <20190523201935.7348-1-ville.syrjala@linux.intel.com> <20190523201935.7348-2-ville.syrjala@linux.intel.com> From: Maarten Lankhorst Message-ID: <16c81e38-f2bc-02aa-0533-2a8642d8ba6c@linux.intel.com> Date: Tue, 28 May 2019 12:56:19 +0200 MIME-Version: 1.0 In-Reply-To: <20190523201935.7348-2-ville.syrjala@linux.intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t 2/2] tests/kms_big_fb: Delay the expensive big fb creation until the last moment List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Ville Syrjala , igt-dev@lists.freedesktop.org List-ID: T3AgMjMtMDUtMjAxOSBvbSAyMjoxOSBzY2hyZWVmIFZpbGxlIFN5cmphbGE6Cj4gRnJvbTogVmls bGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPgo+IFdlIGFscmVh ZHkgcGVyZm9ybSB0aGUgZm9ybWF0K21vZCtyb3RhdGlvbiB0ZXN0IHVzaW5nIHRoZSBzbWFsbCBm Yiwgc28KPiB3ZSBkb24ndCBhY3R1YWxseSBuZWVkIHRvIGNyZWF0ZSB0aGUgYmlnIGZiIHVudGls IHRoYXQgdGVzdCBoYXMgYmVlbgo+IHBlcmZvcm1lZC4gV2UgZG8gbmVlZCB0byBjYWxjdWxhdGUg dGhlIGJpZyBmYiBkaW1lbnNpb25zIHRob3VnaCBzbyB0aGF0Cj4gd2UgY2FuIGNhbGN1bGF0ZSB0 aGUgY29vcmRpbmF0ZXMgd2UncmUgZ29pbmcgdG8gdXNlIGluIHRoZSB0ZXN0Lgo+Cj4gJCB0aW1l IGttc19iaWdfZmIKPiAtIHJlYWwgICAgMG01Mi45MDJzCj4gKyByZWFsICAgIDBtNTIuNjE2cwo+ IHNvIG5vdCBzbyBncmVhdC4KPgo+IEJ1dCBpZiBJIHJ1biBlYWNoIHN1YnRlc3Qgc2VwYXJhdGVs eSBpdCBzdGFydHMgdG8gYWRkIHVwOgo+ICQgZm9yIGkgaW4gYGttc19iaWdfZmIgLS1sYCA7IGRv IGttc19iaWdfZmIgLS1yICRpIDsgZG9uZQo+IC0gcmVhbCAgICA1bTMyLjg5OHMKPiArIHJlYWwg ICAgNG0zMi4xNjRzCj4KPiBUaGUgYmlnIGRpZmZlcmVuY2UgYmV0d2VlbiB0aG9zZSB0d28gd2F5 cyBvZiBydW5uaW5nIHRoZSB0ZXN0Cj4gaXMgYXQgbGVhc3QgcGFydGlhbGx5IGR1ZSB0byB0aGUg dGVzdCByZXVzaW5nIGJpZyBmYiBiZXR3ZWVuCj4gdGhlIGRpZmZlcmVudCByb3RhdGlvbiBzdWJ0 ZXN0cyBmb3IgZWFjaCBmb3JtYXQrbW9kIGNvbWJvLgo+IFJ1bm5pbmcgZWFjaCBzdWJ0ZXN0IGlu ZGl2aWR1YWxseSBjYW4ndCBnZXQgdGhhdCBiZW5lZml0IHNvCj4gYXZvaWRpbmcgbmVlZGxlc3Mg YmlnIGZiIGNyZWF0aW9uIHN0YXJ0cyB0byBtYWtlIGEgZGlmZmVyZW5jZS4KPgo+IFNpZ25lZC1v ZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4g LS0tCj4gIHRlc3RzL2ttc19iaWdfZmIuYyB8IDc3ICsrKysrKysrKysrKysrKysrKysrKysrKy0t LS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQxIGluc2VydGlvbnMoKyks IDM2IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL3Rlc3RzL2ttc19iaWdfZmIuYyBiL3Rl c3RzL2ttc19iaWdfZmIuYwo+IGluZGV4IGMzNTIwZTIyNWFiOS4uYjg4MTNhMzMzNjQzIDEwMDY0 NAo+IC0tLSBhL3Rlc3RzL2ttc19iaWdfZmIuYwo+ICsrKyBiL3Rlc3RzL2ttc19iaWdfZmIuYwo+ IEBAIC00Myw2ICs0Myw3IEBAIHR5cGVkZWYgc3RydWN0IHsKPiAgCWludCB3aWR0aCwgaGVpZ2h0 Owo+ICAJaWd0X3JvdGF0aW9uX3Qgcm90YXRpb247Cj4gIAlpbnQgbWF4X2ZiX3dpZHRoLCBtYXhf ZmJfaGVpZ2h0Owo+ICsJaW50IGJpZ19mYl93aWR0aCwgYmlnX2ZiX2hlaWdodDsKPiAgCXVpbnQ2 NF90IHJhbV9zaXplLCBhcGVyX3NpemUsIG1hcHBhYmxlX3NpemU7Cj4gIAlpZ3RfcmVuZGVyX2Nv cHlmdW5jX3QgcmVuZGVyX2NvcHk7Cj4gIAlkcm1faW50ZWxfYnVmbWdyICpidWZtZ3I7Cj4gQEAg LTE4NiwxMyArMTg3LDMyIEBAIHN0YXRpYyB2b2lkIG1heF9mYl9zaXplKGRhdGFfdCAqZGF0YSwg aW50ICp3aWR0aCwgaW50ICpoZWlnaHQsCj4gIAkJICp3aWR0aCwgKmhlaWdodCk7Cj4gIH0KPiAg Cj4gK3N0YXRpYyB2b2lkIHByZXBfZmIoZGF0YV90ICpkYXRhKQo+ICt7Cj4gKwlpZiAoZGF0YS0+ YmlnX2ZiLmZiX2lkKQo+ICsJCXJldHVybjsKPiArCj4gKwlpZ3RfY3JlYXRlX2ZiKGRhdGEtPmRy bV9mZCwKPiArCQkgICAgICBkYXRhLT5iaWdfZmJfd2lkdGgsIGRhdGEtPmJpZ19mYl9oZWlnaHQs Cj4gKwkJICAgICAgZGF0YS0+Zm9ybWF0LCBkYXRhLT5tb2RpZmllciwKPiArCQkgICAgICAmZGF0 YS0+YmlnX2ZiKTsKPiArCj4gKwlnZW5lcmF0ZV9wYXR0ZXJuKGRhdGEsICZkYXRhLT5iaWdfZmIs IDY0MCwgNDgwKTsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgY2xlYW51cF9mYihkYXRhX3QgKmRh dGEpCj4gK3sKPiArCWlndF9yZW1vdmVfZmIoZGF0YS0+ZHJtX2ZkLCAmZGF0YS0+YmlnX2ZiKTsK PiArCWRhdGEtPmJpZ19mYi5mYl9pZCA9IDA7Cj4gK30KPiArCj4gIHN0YXRpYyBib29sIHRlc3Rf cGxhbmUoZGF0YV90ICpkYXRhKQo+ICB7Cj4gIAlpZ3RfcGxhbmVfdCAqcGxhbmUgPSBkYXRhLT5w bGFuZTsKPiAgCXN0cnVjdCBpZ3RfZmIgKnNtYWxsX2ZiID0gJmRhdGEtPnNtYWxsX2ZiOwo+ICAJ c3RydWN0IGlndF9mYiAqYmlnX2ZiID0gJmRhdGEtPmJpZ19mYjsKPiAtCWludCB3ID0gYmlnX2Zi LT53aWR0aCAtIHNtYWxsX2ZiLT53aWR0aDsKPiAtCWludCBoID0gYmlnX2ZiLT5oZWlnaHQgLSBz bWFsbF9mYi0+aGVpZ2h0Owo+ICsJaW50IHcgPSBkYXRhLT5iaWdfZmJfd2lkdGggLSBzbWFsbF9m Yi0+d2lkdGg7Cj4gKwlpbnQgaCA9IGRhdGEtPmJpZ19mYl9oZWlnaHQgLSBzbWFsbF9mYi0+aGVp Z2h0Owo+ICAJc3RydWN0IHsKPiAgCQlpbnQgeCwgeTsKPiAgCX0gY29vcmRzW10gPSB7Cj4gQEAg LTIzNSwxNiArMjU1LDYgQEAgc3RhdGljIGJvb2wgdGVzdF9wbGFuZShkYXRhX3QgKmRhdGEpCj4g IAkJCXkgJj0gfjE7Cj4gIAkJfQo+ICAKPiAtCQkvKgo+IC0JCSAqIE1ha2UgYSAxOjEgY29weSBv ZiB0aGUgZGVzaXJlZCBwYXJ0IG9mIHRoZSBiaWcgZmIKPiAtCQkgKiByYXRoZXIgdGhhbiB0cnkg dG8gcmVuZGVyIHRoZSBzYW1lIHBhdHRlcm4gKHRyYW5zbGF0ZWQKPiAtCQkgKiBhY2NvcmRpbmx5 KSBhZ2FpbiB2aWEgY2Fpcm8uIFNvbWV0aGluZyBpbiBjYWlybydzCj4gLQkJICogcmVuZGVyaW5n IHBpcGVsaW5lIGludHJvZHVjZXMgc2xpZ2h0IGRpZmZlcmVuY2VzIGludG8KPiAtCQkgKiB0aGUg cmVzdWx0IGlmIHdlIHRyeSB0aGF0LCBhbmQgc28gdGhlIGNyYyB3aWxsIG5vdCBtYXRjaC4KPiAt CQkgKi8KPiAtCQljb3B5X3BhdHRlcm4oZGF0YSwgc21hbGxfZmIsIDAsIDAsIGJpZ19mYiwgeCwg eSwKPiAtCQkJICAgICBzbWFsbF9mYi0+d2lkdGgsIHNtYWxsX2ZiLT5oZWlnaHQpOwo+IC0KPiAg CQlpZ3RfcGxhbmVfc2V0X2ZiKHBsYW5lLCBzbWFsbF9mYik7Cj4gIAkJaWd0X3BsYW5lX3NldF9z aXplKHBsYW5lLCBkYXRhLT53aWR0aCwgZGF0YS0+aGVpZ2h0KTsKPiAgCj4gQEAgLTI2Miw2ICsy NzIsMjIgQEAgc3RhdGljIGJvb2wgdGVzdF9wbGFuZShkYXRhX3QgKmRhdGEpCj4gIAkJCXJldHVy biBmYWxzZTsKPiAgCQl9Cj4gIAo+ICsJCS8qCj4gKwkJICogVG8gc3BlZWQgdXAgc2tpcHMgd2Ug ZGVsYXkgdGhlIGJpZyBmYiBjcmVhdGlvbiB1bnRpbAo+ICsJCSAqIHRoZSBhYm92ZSByb3RhdGlv biByZWxhdGVkIGNoZWNrIGhhcyBiZWVuIHBlcmZvcm1lZC4KPiArCQkgKi8KPiArCQlwcmVwX2Zi KGRhdGEpOwo+ICsKPiArCQkvKgo+ICsJCSAqIE1ha2UgYSAxOjEgY29weSBvZiB0aGUgZGVzaXJl ZCBwYXJ0IG9mIHRoZSBiaWcgZmIKPiArCQkgKiByYXRoZXIgdGhhbiB0cnkgdG8gcmVuZGVyIHRo ZSBzYW1lIHBhdHRlcm4gKHRyYW5zbGF0ZWQKPiArCQkgKiBhY2NvcmRpbmx5KSBhZ2FpbiB2aWEg Y2Fpcm8uIFNvbWV0aGluZyBpbiBjYWlybydzCj4gKwkJICogcmVuZGVyaW5nIHBpcGVsaW5lIGlu dHJvZHVjZXMgc2xpZ2h0IGRpZmZlcmVuY2VzIGludG8KPiArCQkgKiB0aGUgcmVzdWx0IGlmIHdl IHRyeSB0aGF0LCBhbmQgc28gdGhlIGNyYyB3aWxsIG5vdCBtYXRjaC4KPiArCQkgKi8KPiArCQlj b3B5X3BhdHRlcm4oZGF0YSwgc21hbGxfZmIsIDAsIDAsIGJpZ19mYiwgeCwgeSwKPiArCQkJICAg ICBzbWFsbF9mYi0+d2lkdGgsIHNtYWxsX2ZiLT5oZWlnaHQpOwo+ICsKPiAgCQlpZ3RfZGlzcGxh eV9jb21taXQyKCZkYXRhLT5kaXNwbGF5LCBkYXRhLT5kaXNwbGF5LmlzX2F0b21pYyA/Cj4gIAkJ CQkgICAgQ09NTUlUX0FUT01JQyA6IENPTU1JVF9VTklWRVJTQUwpOwo+ICAKPiBAQCAtMzUyLDYg KzM3OCw5IEBAIHN0YXRpYyBib29sIHRlc3RfcGlwZShkYXRhX3QgKmRhdGEpCj4gIAo+ICBzdGF0 aWMgdm9pZCB0ZXN0X3NjYW5vdXQoZGF0YV90ICpkYXRhKQo+ICB7Cj4gKwltYXhfZmJfc2l6ZShk YXRhLCAmZGF0YS0+YmlnX2ZiX3dpZHRoLCAmZGF0YS0+YmlnX2ZiX2hlaWdodCwKPiArCQkgICAg ZGF0YS0+Zm9ybWF0LCBkYXRhLT5tb2RpZmllcik7Cj4gKwo+ICAJZm9yX2VhY2hfcGlwZV93aXRo X3ZhbGlkX291dHB1dCgmZGF0YS0+ZGlzcGxheSwgZGF0YS0+cGlwZSwgZGF0YS0+b3V0cHV0KSB7 Cj4gIAkJaWYgKHRlc3RfcGlwZShkYXRhKSkKPiAgCQkJcmV0dXJuOwo+IEBAIC0zNjEsMjkgKzM5 MCw2IEBAIHN0YXRpYyB2b2lkIHRlc3Rfc2Nhbm91dChkYXRhX3QgKmRhdGEpCj4gIAlpZ3Rfc2tp cCgidW5zdXBwb3J0ZWQgY29uZmlndXJhdGlvblxuIik7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lk IHByZXBfZmIoZGF0YV90ICpkYXRhKQo+IC17Cj4gLQlpbnQgd2lkdGgsIGhlaWdodDsKPiAtCj4g LQlpZiAoZGF0YS0+YmlnX2ZiLmZiX2lkKQo+IC0JCXJldHVybjsKPiAtCj4gLQltYXhfZmJfc2l6 ZShkYXRhLCAmd2lkdGgsICZoZWlnaHQsCj4gLQkJICAgIGRhdGEtPmZvcm1hdCwgZGF0YS0+bW9k aWZpZXIpOwo+IC0KPiAtCWlndF9jcmVhdGVfZmIoZGF0YS0+ZHJtX2ZkLCB3aWR0aCwgaGVpZ2h0 LAo+IC0JCSAgICAgIGRhdGEtPmZvcm1hdCwgZGF0YS0+bW9kaWZpZXIsCj4gLQkJICAgICAgJmRh dGEtPmJpZ19mYik7Cj4gLQo+IC0JZ2VuZXJhdGVfcGF0dGVybihkYXRhLCAmZGF0YS0+YmlnX2Zi LCA2NDAsIDQ4MCk7Cj4gLX0KPiAtCj4gLXN0YXRpYyB2b2lkIGNsZWFudXBfZmIoZGF0YV90ICpk YXRhKQo+IC17Cj4gLQlpZ3RfcmVtb3ZlX2ZiKGRhdGEtPmRybV9mZCwgJmRhdGEtPmJpZ19mYik7 Cj4gLQlkYXRhLT5iaWdfZmIuZmJfaWQgPSAwOwo+IC19Cj4gLQo+ICBzdGF0aWMgdm9pZAo+ICB0 ZXN0X3NpemVfb3ZlcmZsb3coZGF0YV90ICpkYXRhKQo+ICB7Cj4gQEAgLTY1MCw3ICs2NTYsNiBA QCBpZ3RfbWFpbgo+ICAJCQkJCSAgICAgIGZvcm1hdHNbal0uYnBwLCByb3RhdGlvbnNba10uYW5n bGUpIHsKPiAgCQkJCQlpZ3RfcmVxdWlyZShpZ3RfZmJfc3VwcG9ydGVkX2Zvcm1hdChkYXRhLmZv cm1hdCkpOwo+ICAJCQkJCWlndF9yZXF1aXJlKGlndF9kaXNwbGF5X2hhc19mb3JtYXRfbW9kKCZk YXRhLmRpc3BsYXksIGRhdGEuZm9ybWF0LCBkYXRhLm1vZGlmaWVyKSk7Cj4gLQkJCQkJcHJlcF9m YigmZGF0YSk7Cj4gIAkJCQkJdGVzdF9zY2Fub3V0KCZkYXRhKTsKPiAgCQkJCX0KPiAgCQkJfQoK Rm9yIHRoZSBzZXJpZXM6CgpSZXZpZXdlZC1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4u bGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaWd0LWRldg==