Re: [PATCH i-g-t 2/4] tests/kms_color_pipeline: Run tests on all supported planes

["Sharma, Swati2" <swati2.sharma@intel.com>]

Hi Chaitanya,

On 02-02-2026 11:34 am, Chaitanya Kumar Borah wrote:

> Extend the color pipeline tests to run on all planes of a pipe that
> exposes COLOR_PIPELINE property instead of only the primary plane.
>
> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
> ---
>   tests/kms_color_pipeline.c | 56 ++++++++++++++++++++++----------------
>   1 file changed, 32 insertions(+), 24 deletions(-)
>
> diff --git a/tests/kms_color_pipeline.c b/tests/kms_color_pipeline.c
> index 7c4b89139..dd2eed637 100644
> --- a/tests/kms_color_pipeline.c
> +++ b/tests/kms_color_pipeline.c
> @@ -62,7 +62,7 @@ static void test_setup(data_t *data, enum pipe p)
>   	data->mode = igt_output_get_mode(data->output);
>   	igt_require(data->mode);
>   
> -	data->pipe_crc = igt_crtc_crc_new(data->primary->crtc,
> +	data->pipe_crc = igt_crtc_crc_new(crtc,
>   					  IGT_PIPE_CRC_SOURCE_AUTO);
>   
>   	igt_display_commit_atomic(&data->display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
> @@ -83,18 +83,17 @@ static bool ctm_colorop_only(kms_colorop_t *colorops[])
>   	return true;
>   }
>   
> -static bool test_plane_colorops(data_t *data,
> -				const color_t *fb_colors,
> -				const color_t *exp_colors,
> -				kms_colorop_t *colorops[])
> +static void _test_plane_colorops(data_t *data, enum pipe pipe,
pipe parameter in _test_plane_colorops() is currently unused, please 
remove.
> +				 igt_plane_t *plane,
> +				 const color_t *fb_colors,
> +				 const color_t *exp_colors,
> +				 kms_colorop_t *colorops[])
>   {
> -	igt_plane_t *plane = data->primary;
>   	igt_display_t *display = &data->display;
>   	drmModeModeInfo *mode = data->mode;
>   	igt_colorop_t *color_pipeline;
>   	igt_crc_t crc_ref, crc_pipe;
>   	struct igt_fb fb;
> -	bool ret;
>   
>   	color_pipeline = get_color_pipeline(display, plane, colorops);
>   	igt_skip_on(!color_pipeline);
> @@ -139,7 +138,7 @@ static bool test_plane_colorops(data_t *data,
>   	igt_wait_for_vblank(plane->crtc);
>   	igt_pipe_crc_collect_crc(data->pipe_crc, &crc_pipe);
>   
> -	ret = igt_check_crc_equal(&crc_ref, &crc_pipe);
> +	igt_assert_crc_equal(&crc_ref, &crc_pipe);
>   
>   	/* Cleanup per-test state */
>   	set_color_pipeline_bypass(plane);
> @@ -148,8 +147,26 @@ static bool test_plane_colorops(data_t *data,
>   	igt_display_commit_atomic(&data->display, 0, NULL);
>   
>   	igt_remove_fb(data->drm_fd, &fb);
> +}
>   
> -	return ret;
> +static void test_plane_colorops(data_t *data, enum pipe pipe,
> +				const color_t *fb_colors,
> +				const color_t *exp_colors,
> +				kms_colorop_t *colorops[])
> +{
> +	int n_planes = igt_crtc_for_pipe(&data->display, pipe)->n_planes;
> +	igt_output_t *output = data->output;
> +	igt_plane_t *plane;
> +
> +	for (int plane_id = 0; plane_id < n_planes; plane_id++) {
> +		plane = igt_output_get_plane(output, plane_id);
> +
> +		if (!igt_plane_has_prop(plane, IGT_PLANE_COLOR_PIPELINE))
> +			continue;
> +
> +		igt_dynamic_f("pipe-%s-plane-%u", kmstest_pipe_name(pipe), plane_id)
> +			_test_plane_colorops(data, pipe, plane, fb_colors, exp_colors, colorops);
> +	}
>   }
>   
>   static void
> @@ -284,22 +301,13 @@ run_tests_for_plane(data_t *data)
>   
>   				test_setup(data, pipe);
>   
> -				if (!igt_plane_has_prop(data->primary, IGT_PLANE_COLOR_PIPELINE)) {
> -					test_cleanup(data);
> -					continue;
> -				}
> -
> -				igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe),
> -					       igt_output_name(data->output)) {
> -					data->color_depth = 8;
> -					data->drm_format = DRM_FORMAT_XRGB8888;
> -
> -					igt_assert(test_plane_colorops(data,
> -								       plane_colorops_tests[i].fb_colors,
> -								       plane_colorops_tests[i].exp_colors,
> -								       plane_colorops_tests[i].colorops));
> -				}
> +				data->color_depth = 8;
> +				data->drm_format = DRM_FORMAT_XRGB8888;
>   
> +				test_plane_colorops(data, pipe,

patch needs a rebase.

s/pipe/crtc->pipe

> +						    plane_colorops_tests[i].fb_colors,
> +						    plane_colorops_tests[i].exp_colors,
> +						    plane_colorops_tests[i].colorops);
>   				test_cleanup(data);
>   			}
>   		}