From: "Bai, Zongyao" <zongyao.bai@intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
<igt-dev@lists.freedesktop.org>, <jia.yao@intel.com>,
<x.wang@intel.com>
Subject: Re: [PATCH v2 2/3] tests/intel/xe_pat: drop redundant manual srand initialization
Date: Wed, 27 May 2026 10:13:20 -0700 [thread overview]
Message-ID: <1785d264-494c-4478-a816-2c4f23c75f11@intel.com> (raw)
In-Reply-To: <20260527160842.6zufwalycxi5avn5@kamilkon-DESK.igk.intel.com>
On 5/27/2026 9:08 AM, Kamil Konieczny wrote:
> Hi Zongyao,
> On 2026-05-26 at 22:36:53 +0000, Zongyao Bai wrote:
>> Remove manual seed initialization and srand() call from igt_fixture().
>> The IGT framework already handles random seed initialization via igt_srandom()
>>
>> Signed-off-by: Zongyao Bai <zongyao.bai@intel.com>
> This and 1/3 patch was already merged by me,
> could you drop them and resend only 3/3?
>
> Regards,
> Kamil
Got it, thank you Kamil.
>
>> ---
>> tests/intel/xe_pat.c | 7 -------
>> 1 file changed, 7 deletions(-)
>>
>> diff --git a/tests/intel/xe_pat.c b/tests/intel/xe_pat.c
>> index e53e08877..79f9a87aa 100644
>> --- a/tests/intel/xe_pat.c
>> +++ b/tests/intel/xe_pat.c
>> @@ -2213,15 +2213,8 @@ int igt_main_args("V", NULL, help_str, opt_handler, NULL)
>> int fd;
>>
>> igt_fixture() {
>> - uint32_t seed;
>> -
>> fd = drm_open_driver(DRIVER_XE);
>> dev_id = intel_get_drm_devid(fd);
>> -
>> - seed = time(NULL);
>> - srand(seed);
>> - igt_debug("seed: %d\n", seed);
>> -
>> xe_device_get(fd);
>> }
>>
>> --
>> 2.43.0
>>
next prev parent reply other threads:[~2026-05-27 17:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 23:36 [PATCH 0/3] tests/intel/xe_pat: dynamic PAT index selection for pat-index-auto Zongyao Bai
2026-05-11 23:36 ` [PATCH 1/3] tests/intel/xe_pat: fix typo in r2 wc debug print Zongyao Bai
2026-05-27 15:31 ` Kamil Konieczny
2026-05-11 23:36 ` [PATCH 2/3] tests/intel/xe_pat: drop redundant manual srand initialization Zongyao Bai
2026-05-27 15:32 ` Kamil Konieczny
2026-05-11 23:36 ` [PATCH 3/3] tests/intel/xe_pat: Add dynamic PAT index selection for pat-index-auto Zongyao Bai
2026-05-12 22:44 ` Wang, X
2026-05-12 5:04 ` ✓ i915.CI.BAT: success for tests/intel/xe_pat: " Patchwork
2026-05-12 6:41 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-12 13:47 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-06-22 16:54 ` Bai, Zongyao
2026-05-12 19:06 ` ✓ i915.CI.Full: success " Patchwork
2026-05-26 22:36 ` [PATCH v2 0/3] " Zongyao Bai
2026-05-26 22:36 ` [PATCH v2 1/3] tests/intel/xe_pat: fix typo in r2 wc debug print Zongyao Bai
2026-05-26 22:36 ` [PATCH v2 2/3] tests/intel/xe_pat: drop redundant manual srand initialization Zongyao Bai
2026-05-27 16:08 ` Kamil Konieczny
2026-05-27 17:13 ` Bai, Zongyao [this message]
2026-05-26 22:36 ` [PATCH v2 3/3] tests/intel/xe_pat: Add dynamic PAT index selection for pat-index-auto Zongyao Bai
2026-05-27 16:10 ` Kamil Konieczny
2026-05-27 17:31 ` Bai, Zongyao
2026-05-27 16:24 ` [PATCH v2 0/3] tests/intel/xe_pat: " Kamil Konieczny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1785d264-494c-4478-a816-2c4f23c75f11@intel.com \
--to=zongyao.bai@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jia.yao@intel.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=x.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox