public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Bernatowicz, Marcin" <marcin.bernatowicz@linux.intel.com>
To: Nitin Gote <nitin.r.gote@intel.com>, igt-dev@lists.freedesktop.org
Cc: kamil.konieczny@linux.intel.com
Subject: Re: [PATCH] tests/intel/xe_configfs: Skip ctx-restore subtests on platforms without RCS
Date: Fri, 17 Apr 2026 09:21:08 +0200	[thread overview]
Message-ID: <17bda989-1bc2-43c6-b1db-bc301b85d0af@linux.intel.com> (raw)
In-Reply-To: <20260416083004.2723418-2-nitin.r.gote@intel.com>


On 4/16/2026 10:30 AM, Nitin Gote wrote:
> The ctx-restore-post-bb and ctx-restore-mid-bb subtests inject a batch
> buffer via configfs using the "rcs" (render) engine class. However,
> platforms like CRI, PVC don't have render. The BB is stored via configfs
> but never injected into any engine's LRC, causing the subsequent register
> readback to fail.
>
> Fix by adding runtime detection of the render engine using
> xe_for_each_engine() and skip the ctx-restore subtests with
> igt_require_f(has_rcs) on platforms without a render engine instead
> of failing silently.
>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Fixes: b6abdc26e01b ("tests/intel/xe_configfs: Check ctx_restore_post_bb")
> Signed-off-by: Nitin Gote <nitin.r.gote@intel.com>
> ---
>   tests/intel/xe_configfs.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/tests/intel/xe_configfs.c b/tests/intel/xe_configfs.c
> index 755524e7c..445f35431 100644
> --- a/tests/intel/xe_configfs.c
> +++ b/tests/intel/xe_configfs.c
> @@ -364,12 +364,22 @@ int igt_main()
>   	int fd, configfs_fd, configfs_device_fd;
>   	uint32_t devid;
>   	bool is_vf_device;
> +	bool has_rcs = false;
>   
>   	igt_fixture() {
> +		struct drm_xe_engine_class_instance *hwe;
> +
>   		fd = drm_open_driver(DRIVER_XE);
>   		devid = intel_get_drm_devid(fd);
>   		is_vf_device = intel_is_vf_device(fd);
>   		set_bus_addr(fd);
> +
> +		xe_for_each_engine(fd, hwe)
> +			if (hwe->engine_class == DRM_XE_ENGINE_CLASS_RENDER) {
> +				has_rcs = true;
> +				break;
> +			}
> +
Does it mean the feature is designed and used for RCS only ?
>   		drm_close_driver(fd);
>   
>   		configfs_fd = igt_configfs_open("xe");
> @@ -418,6 +428,7 @@ int igt_main()
>   	igt_describe("Validate ctx_restore_post_bb");
>   	igt_subtest("ctx-restore-post-bb") {
>   		igt_skip_on_f(is_vf_device, "MMIO register readback not possible on VF\n");
> +		igt_require_f(has_rcs, "Platform has no render engine\n");
>   		configfs_device_fd = create_device_configfs_group(configfs_fd);
>   		test_ctx_restore(configfs_device_fd, "post");
>   		close_configfs_group(configfs_fd, configfs_device_fd);
> @@ -434,6 +445,7 @@ int igt_main()
>   	igt_describe("Validate ctx_restore_mid_bb");
>   	igt_subtest("ctx-restore-mid-bb") {
>   		igt_skip_on_f(is_vf_device, "MMIO register readback not possible on VF\n");
> +		igt_require_f(has_rcs, "Platform has no render engine\n");
>   		configfs_device_fd = create_device_configfs_group(configfs_fd);
>   		test_ctx_restore(configfs_device_fd, "mid");
>   		close_configfs_group(configfs_fd, configfs_device_fd);

  parent reply	other threads:[~2026-04-17  7:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-16  8:30 [PATCH] tests/intel/xe_configfs: Skip ctx-restore subtests on platforms without RCS Nitin Gote
2026-04-16 13:28 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-04-16 14:21 ` ✓ i915.CI.BAT: " Patchwork
2026-04-16 14:27 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-04-17  4:27   ` Gote, Nitin R
2026-04-17  9:55     ` Ravali, JupallyX
2026-04-17  0:41 ` ✓ i915.CI.Full: success " Patchwork
2026-04-17  7:21 ` Bernatowicz, Marcin [this message]
2026-04-17  8:49   ` [PATCH] " Gote, Nitin R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17bda989-1bc2-43c6-b1db-bc301b85d0af@linux.intel.com \
    --to=marcin.bernatowicz@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=nitin.r.gote@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox