From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id B659A8BDFA
 for <igt-dev@lists.freedesktop.org>; Mon, 11 Jul 2022 04:11:02 +0000 (UTC)
From: "Gupta, Anshuman" <anshuman.gupta@intel.com>
To: "Srivatsa, Anusha" <anusha.srivatsa@intel.com>,
 "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Date: Mon, 11 Jul 2022 04:11:00 +0000
Message-ID: <19d53e1a0dee4cb28ddbc68ec7859d65@intel.com>
References: <20220708181744.398984-1-anusha.srivatsa@intel.com>
In-Reply-To: <20220708181744.398984-1-anusha.srivatsa@intel.com>
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [igt-dev] [i-g-t] tests/i915/i915_pm_dc: Remove PC8+ dependency
 from DC9
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Cc: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>



> -----Original Message-----
> From: Srivatsa, Anusha <anusha.srivatsa@intel.com>
> Sent: Friday, July 8, 2022 11:48 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Srivatsa, Anusha <anusha.srivatsa@intel.com>; Deak, Imre
> <imre.deak@intel.com>; Gupta, Anshuman <anshuman.gupta@intel.com>; Vivi,
> Rodrigo <rodrigo.vivi@intel.com>
> Subject: [i-g-t] tests/i915/i915_pm_dc: Remove PC8+ dependency from DC9
>=20
> Different from DC6, DC9 does not depend on BIOS/PCU to execute save and
> restore or any other sequence when going to PC9/PC10
Commit message should explain this is a change for all DGFX platform.
Thanks,
Anshuman Gupta.
>=20
> DC9 actually depends on D3 and PCODE simply remove power if SW allowed
>=20
> v2: resrict the check for igfx only.
>=20
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Anshuman Gupta <anshuman.gupta@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>(v2)
> ---
>  tests/i915/i915_pm_dc.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c index
> a780f2cb..5132734b 100644
> --- a/tests/i915/i915_pm_dc.c
> +++ b/tests/i915/i915_pm_dc.c
> @@ -532,8 +532,9 @@ int main(int argc, char *argv[])
>=20
>  	igt_describe("This test validates display engine entry to DC9 state");
>  	igt_subtest("dc9-dpms") {
> -
> 	igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.msr_fd),
> -				"PC8+ residencies not supported\n");
> +		if (!(IS_DG1(data.devid) || IS_DG2(data.devid)))
> +
> 	igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.msr_fd),
> +				      "PC8+ residencies not supported\n");
>  		test_dc9_dpms(&data);
>  	}
>=20
> --
> 2.25.1