From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1908B6E04C for ; Wed, 26 Sep 2018 18:56:41 +0000 (UTC) Received: by mail-lf1-x143.google.com with SMTP id q2-v6so14205637lfc.13 for ; Wed, 26 Sep 2018 11:56:41 -0700 (PDT) References: <20180925145357.7918-1-ville.syrjala@linux.intel.com> From: =?UTF-8?Q?Juha-Pekka_Heikkil=c3=a4?= Message-ID: <1a23fddd-f1ec-1bfd-ebdf-5b7a662496df@gmail.com> Date: Wed, 26 Sep 2018 21:56:47 +0300 MIME-Version: 1.0 In-Reply-To: <20180925145357.7918-1-ville.syrjala@linux.intel.com> Subject: Re: [igt-dev] [PATCH i-g-t] lib/debugfs: Use a blocking read in igt_pipe_crc_get_single() List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Ville Syrjala , igt-dev@lists.freedesktop.org List-ID: TG9va3MgZ29vZC4gSSBzdXNwZWN0IHRoaXMgd2lsbCByZWR1Y2UgdGhvc2UgcmFuZG9tIGNyYyBl cnJvcnMgc2VlbiBpbiBDSS4KClJldmlld2VkLWJ5OiBKdWhhLVBla2thIEhlaWtraWxhIDxqdWhh cGVra2EuaGVpa2tpbGFAZ21haWwuY29tPgoKVmlsbGUgU3lyamFsYSBraXJqb2l0dGkgMjUuOS4y MDE4IGtsbyAxNy41MzoKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGlu dXguaW50ZWwuY29tPgo+IAo+IEFsbCB1c2VycyBvZiBpZ3RfcGlwZV9jcmNfZ2V0X3NpbmdsZSgp IHdhbnQgYSBibG9ja2luZyByZWFkIGV2ZW4gaWYKPiB0aGUgZmQgd2FzIG9wZW5lZCBpbiBub25i bG9ja2luZyBtb2RlLiBNYWtlIGl0IHNvLgo+IAo+IENjOiBKdWhhLVBla2thIEhlaWtraWxhIDxq dWhhcGVra2EuaGVpa2tpbGFAZ21haWwuY29tPgo+IENjOiBNYWFydGVuIExhbmtob3JzdCA8bWFh cnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5 cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gICBsaWIvaWd0 X2RlYnVnZnMuYyAgICAgICAgICAgfCAzNSArKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQo+ICAgbGliL2lndF9kZWJ1Z2ZzLmggICAgICAgICAgIHwgIDIgKy0KPiAgIHRlc3RzL2tt c19jaHZfY3Vyc29yX2ZhaWwuYyB8ICAyICstCj4gICAzIGZpbGVzIGNoYW5nZWQsIDE0IGluc2Vy dGlvbnMoKyksIDI1IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9saWIvaWd0X2RlYnVn ZnMuYyBiL2xpYi9pZ3RfZGVidWdmcy5jCj4gaW5kZXggYmFlZGMyMjU1YWM5Li5kMTUxZDliMjNl ZDQgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9kZWJ1Z2ZzLmMKPiArKysgYi9saWIvaWd0X2RlYnVn ZnMuYwo+IEBAIC03NTcsOCArNzU3LDEzIEBAIHN0YXRpYyB2b2lkIHJlYWRfb25lX2NyYyhpZ3Rf cGlwZV9jcmNfdCAqcGlwZV9jcmMsIGlndF9jcmNfdCAqb3V0KQo+ICAgewo+ICAgCWludCByZXQ7 Cj4gICAKPiAtCXdoaWxlICgocmV0ID0gcmVhZF9jcmMocGlwZV9jcmMsIG91dCkpIDw9IDAgJiYg cmV0ICE9IC1FSU5WQUwpCj4gLQkJdXNsZWVwKDEwMDApOwo+ICsJZmNudGwocGlwZV9jcmMtPmNy Y19mZCwgRl9TRVRGTCwgcGlwZV9jcmMtPmZsYWdzICYgfk9fTk9OQkxPQ0spOwo+ICsKPiArCWRv IHsKPiArCQlyZXQgPSByZWFkX2NyYyhwaXBlX2NyYywgb3V0KTsKPiArCX0gd2hpbGUgKHJldCA9 PSAtRUlOVFIpOwo+ICsKPiArCWZjbnRsKHBpcGVfY3JjLT5jcmNfZmQsIEZfU0VURkwsIHBpcGVf Y3JjLT5mbGFncyk7Cj4gICB9Cj4gICAKPiAgIC8qKgo+IEBAIC05MjYsMTIgKzkzMSw4IEBAIHZv aWQgaWd0X3BpcGVfY3JjX2RyYWluKGlndF9waXBlX2NyY190ICpwaXBlX2NyYykKPiAgICAqIEBw aXBlX2NyYzogcGlwZSBDUkMgb2JqZWN0Cj4gICAgKiBAY3JjOiBidWZmZXIgcG9pbnRlciBmb3Ig dGhlIGNhcHR1cmVkIENSQyB2YWx1ZQo+ICAgICoKPiAtICogUmVhZCBhIHNpbmdsZSBAY3JjIGZy b20gQHBpcGVfY3JjLiBUaGlzIGZ1bmN0aW9uIGRvZXMgbm90IGJsb2NrCj4gLSAqIHdoZW4gbm9u YmxvY2tpbmcgQ1JDIGlzIHJlcXVlc3RlZCwgYW5kIHdpbGwgcmV0dXJuIGZhbHNlIGlmIG5vIENS Qwo+IC0gKiBjYW4gYmUgY2FwdHVyZWQuCj4gLSAqCj4gLSAqIElmIG9wZW5lZCBpbiBibG9ja2lu ZyBtb2RlIGl0IHdpbGwgYWx3YXlzIGJsb2NrIHVudGlsIGEgbmV3IENSQyBpcyByZWFkLCBsaWtl Cj4gLSAqIGlndF9waXBlX2NyY19jb2xsZWN0X2NyYygpLgo+ICsgKiBSZWFkIGEgc2luZ2xlIEBj cmMgZnJvbSBAcGlwZV9jcmMuIFRoaXMgZnVuY3Rpb24gYmxvY2tzIGV2ZW4KPiArICogd2hlbiBu b25ibG9ja2luZyBDUkMgaXMgcmVxdWVzdGVkLgo+ICAgICoKPiAgICAqIENhbGxlcnMgbXVzdCBz dGFydCBhbmQgc3RvcCB0aGUgY2FwdHVyaW5nIHRoZW1zZWx2ZXMgYnkgY2FsbGluZwo+ICAgICog aWd0X3BpcGVfY3JjX3N0YXJ0KCkgYW5kIGlndF9waXBlX2NyY19zdG9wKCkuIEZvciBvbmUtc2hv dCBDUkMgY29sbGVjdGluZwo+IEBAIC05NDMsMjIgKzk0NCwxMSBAQCB2b2lkIGlndF9waXBlX2Ny Y19kcmFpbihpZ3RfcGlwZV9jcmNfdCAqcGlwZV9jcmMpCj4gICAgKiBSZXR1cm5zOgo+ICAgICog V2hldGhlciBhIGNyYyBpcyBjYXB0dXJlZCwgb25seSBmYWxzZSBpbiBub24tYmxvY2tpbmcgbW9k ZS4KPiAgICAqLwo+IC1ib29sCj4gLWlndF9waXBlX2NyY19nZXRfc2luZ2xlKGlndF9waXBlX2Ny Y190ICpwaXBlX2NyYywgaWd0X2NyY190ICpjcmMpCj4gK3ZvaWQgaWd0X3BpcGVfY3JjX2dldF9z aW5nbGUoaWd0X3BpcGVfY3JjX3QgKnBpcGVfY3JjLCBpZ3RfY3JjX3QgKmNyYykKPiAgIHsKPiAt CWJvb2wgZm91bmQgPSB0cnVlOwo+ICsJcmVhZF9vbmVfY3JjKHBpcGVfY3JjLCBjcmMpOwo+ICAg Cj4gLQlpZiAocGlwZV9jcmMtPmZsYWdzICYgT19OT05CTE9DSykgewo+IC0JCWludCByZXQgPSBy ZWFkX2NyYyhwaXBlX2NyYywgY3JjKTsKPiAtCj4gLQkJZm91bmQgPSByZXQgPiAwOwo+IC0JfSBl bHNlCj4gLQkJcmVhZF9vbmVfY3JjKHBpcGVfY3JjLCBjcmMpOwo+IC0KPiAtCWlmIChmb3VuZCkK PiAtCQljcmNfc2FuaXR5X2NoZWNrcyhjcmMpOwo+IC0KPiAtCXJldHVybiBmb3VuZDsKPiArCWNy Y19zYW5pdHlfY2hlY2tzKGNyYyk7Cj4gICB9Cj4gICAKPiAgIC8qKgo+IEBAIC05NzYsNyArOTY2 LDYgQEAgaWd0X3BpcGVfY3JjX2dldF9jdXJyZW50KGludCBkcm1fZmQsIGlndF9waXBlX2NyY190 ICpwaXBlX2NyYywgaWd0X2NyY190ICpjcmMpCj4gICB7Cj4gICAJdW5zaWduZWQgdmJsYW5rID0g a21zdGVzdF9nZXRfdmJsYW5rKGRybV9mZCwgcGlwZV9jcmMtPnBpcGUsIDApOwo+ICAgCj4gLQlp Z3RfYXNzZXJ0KCEocGlwZV9jcmMtPmZsYWdzICYgT19OT05CTE9DSykpOwo+ICAgCWRvIHsKPiAg IAkJcmVhZF9vbmVfY3JjKHBpcGVfY3JjLCBjcmMpOwo+ICAgCj4gZGlmZiAtLWdpdCBhL2xpYi9p Z3RfZGVidWdmcy5oIGIvbGliL2lndF9kZWJ1Z2ZzLmgKPiBpbmRleCA5ZjgxYmUwYTI0ZGUuLjU4 Y2EwN2Y1YzE1ZCAxMDA2NDQKPiAtLS0gYS9saWIvaWd0X2RlYnVnZnMuaAo+ICsrKyBiL2xpYi9p Z3RfZGVidWdmcy5oCj4gQEAgLTEzMiw3ICsxMzIsNyBAQCBfX2F0dHJpYnV0ZV9fKCh3YXJuX3Vu dXNlZF9yZXN1bHQpKQo+ICAgaW50IGlndF9waXBlX2NyY19nZXRfY3JjcyhpZ3RfcGlwZV9jcmNf dCAqcGlwZV9jcmMsIGludCBuX2NyY3MsCj4gICAJCQkgIGlndF9jcmNfdCAqKm91dF9jcmNzKTsK PiAgIHZvaWQgaWd0X3BpcGVfY3JjX2RyYWluKGlndF9waXBlX2NyY190ICpwaXBlX2NyYyk7Cj4g LWJvb2wgaWd0X3BpcGVfY3JjX2dldF9zaW5nbGUoaWd0X3BpcGVfY3JjX3QgKnBpcGVfY3JjLCBp Z3RfY3JjX3QgKm91dF9jcmMpOwo+ICt2b2lkIGlndF9waXBlX2NyY19nZXRfc2luZ2xlKGlndF9w aXBlX2NyY190ICpwaXBlX2NyYywgaWd0X2NyY190ICpvdXRfY3JjKTsKPiAgIHZvaWQgaWd0X3Bp cGVfY3JjX2dldF9jdXJyZW50KGludCBkcm1fZmQsIGlndF9waXBlX2NyY190ICpwaXBlX2NyYywg aWd0X2NyY190ICpjcmMpOwo+ICAgCj4gICB2b2lkIGlndF9waXBlX2NyY19jb2xsZWN0X2NyYyhp Z3RfcGlwZV9jcmNfdCAqcGlwZV9jcmMsIGlndF9jcmNfdCAqb3V0X2NyYyk7Cj4gZGlmZiAtLWdp dCBhL3Rlc3RzL2ttc19jaHZfY3Vyc29yX2ZhaWwuYyBiL3Rlc3RzL2ttc19jaHZfY3Vyc29yX2Zh aWwuYwo+IGluZGV4IDcxMzhlNTQ5YWViNy4uOGU1MDk3OGQwYmUxIDEwMDY0NAo+IC0tLSBhL3Rl c3RzL2ttc19jaHZfY3Vyc29yX2ZhaWwuYwo+ICsrKyBiL3Rlc3RzL2ttc19jaHZfY3Vyc29yX2Zh aWwuYwo+IEBAIC0yNTgsNyArMjU4LDcgQEAgc3RhdGljIHZvaWQgcHJlcGFyZV9jcnRjKGRhdGFf dCAqZGF0YSkKPiAgIAo+ICAgCS8qIGdldCByZWZlcmVuY2UgY3JjIHcvbyBjdXJzb3IgKi8KPiAg IAlpZ3RfcGlwZV9jcmNfc3RhcnQoZGF0YS0+cGlwZV9jcmMpOwo+IC0JaWd0X2Fzc2VydChpZ3Rf cGlwZV9jcmNfZ2V0X3NpbmdsZShkYXRhLT5waXBlX2NyYywgJmRhdGEtPnJlZl9jcmMpKTsKPiAr CWlndF9waXBlX2NyY19nZXRfc2luZ2xlKGRhdGEtPnBpcGVfY3JjLCAmZGF0YS0+cmVmX2NyYyk7 Cj4gICB9Cj4gICAKPiAgIHN0YXRpYyB2b2lkIHRlc3RfY3J0YyhkYXRhX3QgKmRhdGEsIHVuc2ln bmVkIGludCBlZGdlcykKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2 Cg==