Re: [PATCH i-g-t v8 2/2] lib/igt_kms.c: Enforce strict check for bigjoiner_possible

[Karthik B S <karthik.b.s@intel.com>]

On 1/10/2025 9:57 AM, Santhosh Reddy Guddati wrote:
> update bigjoiner_mode_found to check for ultrajoiner possibility.
> This ensures that the mode is only set to bigjoiner if ultrajoiner
> is not possible.
Please rephrase the second sentence while merging. May be something 
like, "This ensures that the mode is truly supported by bigjoiner and 
doesn't require ultrajoiner.
>
> v8: rebase and check fot ultra joiner possibility.
Also please remove the "check for ultra joiner possibility" as there is 
no changes from previous version.
>
> Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>

With the above mentioned updates in commit message,

Reviewed-by: Karthik B S <karthik.b.s@intel.com>

> ---
>   lib/igt_kms.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 95e3059f7..1a0819ce2 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -6419,7 +6419,8 @@ bool bigjoiner_mode_found(int drm_fd, drmModeConnector *connector,
>   	bool found = false;
>   
>   	for (int i=0; i< connector->count_modes; i++) {
> -		if (igt_bigjoiner_possible(drm_fd, &connector->modes[i], max_dotclock)) {
> +		if (igt_bigjoiner_possible(drm_fd, &connector->modes[i], max_dotclock) &&
> +		    !igt_ultrajoiner_possible(&connector->modes[i], max_dotclock)) {
>   			*mode = connector->modes[i];
>   			found = true;
>   			break;