Re: [PATCH i-g-t v4] tests/kms_properties: Add skip on headless machines

[Karthik B S <karthik.b.s@intel.com>]

Hi Sumit,

Based on the review received on v2, it would be better to verify on 
headless configs first if these tests are running and if these checks 
are really required in the first place.

Thanks and Regards,
Karthik.B.S

On 4/15/2026 4:18 PM, sumit kishore wrote:
> From: Sumit Kishore <sumit.kishore@intel.com>
>
> Skip the sub-tests on headless display systems.
>
> v2: Use existing library function, instead of
>      defining new (karthik)
> v3: Add headless display check in,
>      colorop_properties function (Pranay)
> v4: Update the commit message (Pranay)
>
> Signed-off-by: Sumit Kishore <sumit.kishore@intel.com>
> Reviewed-by: Pranay Samala <pranay.samala@intel.com>
> ---
>   tests/kms_properties.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/tests/kms_properties.c b/tests/kms_properties.c
> index f735839da..5164277b3 100644
> --- a/tests/kms_properties.c
> +++ b/tests/kms_properties.c
> @@ -341,6 +341,8 @@ static void colorop_properties(igt_display_t *display, bool atomic)
>   	igt_output_t *output;
>   	igt_crtc_t *crtc;
>   
> +	igt_display_require_output(display);
> +
>   	/* colorops are only available with atomic */
>   	igt_skip_on(!display->is_atomic);
>   
> @@ -377,6 +379,8 @@ static void plane_properties(igt_display_t *display, bool atomic)
>   	igt_output_t *output;
>   	igt_crtc_t *crtc;
>   
> +	igt_display_require_output(display);
> +
>   	for_each_crtc_with_single_output(display, crtc, output) {
>   		igt_display_reset(display);
>   
> @@ -400,6 +404,8 @@ static void crtc_properties(igt_display_t *display, bool atomic)
>   	igt_crtc_t *crtc;
>   	igt_output_t *output;
>   
> +	igt_display_require_output(display);
> +
>   	for_each_crtc_with_single_output(display, crtc, output) {
>   		igt_display_reset(display);
>