Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Bernatowicz, Marcin" <marcin.bernatowicz@linux.intel.com>
To: Lukasz Laguna <lukasz.laguna@intel.com>, igt-dev@lists.freedesktop.org
Cc: marcin.bernatowicz@intel.com, raag.jadav@intel.com
Subject: Re: [PATCH v1 2/2] tests/device_reset: Add Xe healthcheck to post-reset validation
Date: Tue, 18 Aug 2026 17:05:57 +0200	[thread overview]
Message-ID: <1b4a6ce7-e862-4713-a943-b1df536a8e6b@linux.intel.com> (raw)
In-Reply-To: <20260811141426.1642321-3-lukasz.laguna@intel.com>


On 8/11/2026 4:14 PM, Lukasz Laguna wrote:
> Extend the healthcheck for Xe devices to validate basic command
> submission after reset.
>
> Signed-off-by: Lukasz Laguna <lukasz.laguna@intel.com>
> ---
>   tests/device_reset.c | 13 ++++++++++---
>   1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/tests/device_reset.c b/tests/device_reset.c
> index b281f4ece..70ca511e0 100644
> --- a/tests/device_reset.c
> +++ b/tests/device_reset.c
> @@ -14,6 +14,8 @@
>   #include "igt_pci.h"
>   #include "igt_sysfs.h"
>   #include "igt_kmod.h"
> +#include "xe/xe_device.h"
> +
>   /**
>    * TEST: device reset
>    * Description: Examine behavior of a driver on device sysfs reset
> @@ -392,6 +394,8 @@ static bool is_i915_wedged(int i915)
>    */
>   static void healthcheck(struct device_fds *dev)
>   {
> +	int fd;
> +
>   	if (dev->fds.dev == -1) {
>   		/* give the kernel a breath for re-creating device nodes in devtmpfs */
>   		sleep(1);
> @@ -400,10 +404,13 @@ static void healthcheck(struct device_fds *dev)
>   		igt_debug("reopen the device\n");
>   		dev->fds.dev = __drm_open_driver(DRIVER_ANY);
>   	}
> -	igt_assert_fd(dev->fds.dev);
> +	fd = dev->fds.dev;
> +	igt_assert_fd(fd);
>   
> -	if (is_i915_device(dev->fds.dev))
> -		igt_assert(!is_i915_wedged(dev->fds.dev));
> +	if (is_i915_device(fd))
> +		igt_assert(!is_i915_wedged(fd));
> +	else if (is_xe_device(fd))
> +		xe_healthcheck(fd);
>   }
>   

LGTM,

Reviewed-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>

>   /**

  reply	other threads:[~2026-08-18 15:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 14:14 [PATCH v1 0/2] tests/device_reset: Add Xe healthcheck to post-reset validation Lukasz Laguna
2026-08-11 14:14 ` [PATCH v1 1/2] lib/xe/xe_device: Add helper for device healthcheck Lukasz Laguna
2026-08-18 15:04   ` Bernatowicz, Marcin
2026-08-11 14:14 ` [PATCH v1 2/2] tests/device_reset: Add Xe healthcheck to post-reset validation Lukasz Laguna
2026-08-18 15:05   ` Bernatowicz, Marcin [this message]
2026-08-11 15:53 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-08-11 16:08 ` ✗ i915.CI.BAT: failure " Patchwork
2026-08-11 18:00 ` ✓ Xe.CI.FULL: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b4a6ce7-e862-4713-a943-b1df536a8e6b@linux.intel.com \
    --to=marcin.bernatowicz@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=lukasz.laguna@intel.com \
    --cc=marcin.bernatowicz@intel.com \
    --cc=raag.jadav@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox