Re: [PATCH i-g-t v2] tests/kms_plane_scaling: Add logs to skips

["Reddy Guddati, Santhosh" <santhosh.reddy.guddati@intel.com>]

On 09-01-2025 22:29, Reddy Guddati, Santhosh wrote:
> Hi Pranay,
> 
> ------------------------------------------------------------------------
> *From:* Samala, Pranay <pranay.samala@intel.com>
> *Sent:* Thursday, January 9, 2025 2:08 PM
> *To:* igt-dev@lists.freedesktop.org <igt-dev@lists.freedesktop.org>
> *Cc:* B S, Karthik <karthik.b.s@intel.com>; Reddy Guddati, Santhosh 
> <santhosh.reddy.guddati@intel.com>; Lattannavar, Sameer 
> <sameer.lattannavar@intel.com>; Samala, Pranay <pranay.samala@intel.com>
> *Subject:* [PATCH i-g-t v2] tests/kms_plane_scaling: Add logs to skips
> Having some logs for test failures & skips would
> make debugging much easier.
> 
> v2: Add output/pipe name for detailed message (Santhosh)
> 
> Signed-off-by: Pranay Samala <pranay.samala@intel.com>
> LGTM
> Reviewed-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>
> 
> ---
>   tests/kms_plane_scaling.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index c8c9aee31..43f578d55 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -1577,6 +1577,12 @@ igt_main_args("", long_opts, help_str, 
> opt_handler, &data)
>                                                                          
> kmstest_pipe_name(pipe), igt_output_name(output))
>                                                                   
> intel_max_source_size_test(&data, pipe, output, mode,
>                                                                                              intel_paramtests[index].planesize);
> +                                               } else {
> +                                                       igt_info("Unable 
> to find the lowest " \
> +                                                                
> "refresh rate mode on output " \
> +                                                                "%s 
> pipe %s\n",
> +                                                                
> igt_output_name(output),
> +                                                                
> kmstest_pipe_name(pipe));
>                                                   }
>                                                   continue;
>                                           }
> --
> 2.34.1
>