From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20180702090727.7721-1-chris@chris-wilson.co.uk> <20180702090727.7721-2-chris@chris-wilson.co.uk> <7d9dc19d-4352-1871-fb27-53797671613a@linux.intel.com> <153078928772.31833.7517594807964385129@skylake-alporthouse-com> <0e20fa11-9be6-b1b1-e881-b8bbb4b382fc@linux.intel.com> <153079414033.2087.13604189223256424909@cwilso3-mobl.ger.intel.com> From: Tvrtko Ursulin Message-ID: <1c0d464b-534c-d465-6e2d-939ea5ce782a@linux.intel.com> Date: Thu, 5 Jul 2018 16:26:51 +0100 MIME-Version: 1.0 In-Reply-To: <153079414033.2087.13604189223256424909@cwilso3-mobl.ger.intel.com> Content-Language: en-GB Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 02/17] igt/gem_tiled_partial_pwrite_pread: Check for known swizzling List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , igt-dev@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-ID: Ck9uIDA1LzA3LzIwMTggMTM6MzUsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTA3LTA1IDEzOjMwOjU3KQo+Pgo+PiBPbiAwNS8wNy8yMDE4IDEyOjE0 LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBRdW90aW5nIFR2cnRrbyBVcnN1bGluICgyMDE4LTA3 LTAyIDEzOjAwOjA3KQo+Pj4+Cj4+Pj4gT24gMDIvMDcvMjAxOCAxMDowNywgQ2hyaXMgV2lsc29u IHdyb3RlOgo+Pj4+PiBBcyB3ZSB3YW50IHRvIGNvbXBhcmUgYSB0ZW1wbGF0ZWQgdGlsaW5nIHBh dHRlcm4gYWdhaW5zdCB0aGUgdGFyZ2V0X2JvLAo+Pj4+PiB3ZSBuZWVkIHRvIGtub3cgdGhhdCB0 aGUgc3dpenpsaW5nIGlzIGNvbXBhdGlibGUuIE9yIGVsc2UgdGhlIHR3bwo+Pj4+PiB0aWxpbmcg cGF0dGVybiBtYXkgZGlmZmVyIGR1ZSB0byB1bmRlcmx5aW5nIHBhZ2UgYWRkcmVzcyB0aGF0IHdl IGNhbm5vdAo+Pj4+PiBrbm93LCBhbmQgc28gdGhlIHRlc3QgbWF5IHNwb3JhZGljYWxseSBmYWls Lgo+Pj4+Pgo+Pj4+PiBSZWZlcmVuY2VzOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3No b3dfYnVnLmNnaT9pZD0xMDI1NzUKPj4+Pj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxj aHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+Pj4+IC0tLQo+Pj4+PiAgICAgdGVzdHMvZ2VtX3Rp bGVkX3BhcnRpYWxfcHdyaXRlX3ByZWFkLmMgfCAyNCArKysrKysrKysrKysrKysrKysrKysrKysK Pj4+Pj4gICAgIDEgZmlsZSBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspCj4+Pj4+Cj4+Pj4+IGRp ZmYgLS1naXQgYS90ZXN0cy9nZW1fdGlsZWRfcGFydGlhbF9wd3JpdGVfcHJlYWQuYyBiL3Rlc3Rz L2dlbV90aWxlZF9wYXJ0aWFsX3B3cml0ZV9wcmVhZC5jCj4+Pj4+IGluZGV4IGZlNTczYzM3Yy4u ODNjNTdjMDdkIDEwMDY0NAo+Pj4+PiAtLS0gYS90ZXN0cy9nZW1fdGlsZWRfcGFydGlhbF9wd3Jp dGVfcHJlYWQuYwo+Pj4+PiArKysgYi90ZXN0cy9nZW1fdGlsZWRfcGFydGlhbF9wd3JpdGVfcHJl YWQuYwo+Pj4+PiBAQCAtMjQ5LDYgKzI0OSwyNCBAQCBzdGF0aWMgdm9pZCB0ZXN0X3BhcnRpYWxf cmVhZF93cml0ZXModm9pZCkKPj4+Pj4gICAgICAgICB9Cj4+Pj4+ICAgICB9Cj4+Pj4+ICAgICAK Pj4+Pj4gK3N0YXRpYyBib29sIGtub3duX3N3aXp6bGluZyh1aW50MzJfdCBoYW5kbGUpCj4+Pj4+ ICt7Cj4+Pj4+ICsgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fZ2V0X3RpbGluZzIgewo+Pj4+PiAr ICAgICAgICAgICAgIHVpbnQzMl90IGhhbmRsZTsKPj4+Pj4gKyAgICAgICAgICAgICB1aW50MzJf dCB0aWxpbmdfbW9kZTsKPj4+Pj4gKyAgICAgICAgICAgICB1aW50MzJfdCBzd2l6emxlX21vZGU7 Cj4+Pj4+ICsgICAgICAgICAgICAgdWludDMyX3QgcGh5c19zd2l6emxlX21vZGU7Cj4+Pj4+ICsg ICAgIH0gYXJnID0gewo+Pj4+PiArICAgICAgICAgICAgIC5oYW5kbGUgPSBoYW5kbGUsCj4+Pj4+ ICsgICAgIH07Cj4+Pj4+ICsjZGVmaW5lIERSTV9JT0NUTF9JOTE1X0dFTV9HRVRfVElMSU5HMiAg ICAgICBEUk1fSU9XUiAoRFJNX0NPTU1BTkRfQkFTRSArIERSTV9JOTE1X0dFTV9HRVRfVElMSU5H LCBzdHJ1Y3QKPj4+Pgo+Pj4+IENhbid0IHdlIHJlbHkgb24gdGhpcyBiZWluZyBpbiBzeXN0ZW0g aGVhZGVycyBieSBub3c/Cj4+Pj4KPj4+PiBkcm1faTkxNV9nZW1fZ2V0X3RpbGluZzIpCj4+Pj4+ ICsKPj4+Pj4gKyAgICAgaWYgKGlndF9pb2N0bChmZCwgRFJNX0lPQ1RMX0k5MTVfR0VNX0dFVF9U SUxJTkcyLCAmYXJnKSkKPj4+Pj4gKyAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Cj4+Pj4+ICsK Pj4+Pj4gKyAgICAgcmV0dXJuIGFyZy5waHlzX3N3aXp6bGVfbW9kZSA9PSBhcmcuc3dpenpsZV9t b2RlOwo+Pj4+PiArfQo+Pj4+PiArCj4+Pj4+ICAgICBpZ3RfbWFpbgo+Pj4+PiAgICAgewo+Pj4+ PiAgICAgICAgIHVpbnQzMl90IHRpbGluZ19tb2RlID0gSTkxNV9USUxJTkdfWDsKPj4+Pj4gQEAg LTI3MSw2ICsyODksMTIgQEAgaWd0X21haW4KPj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJnRpbGluZ19tb2RlLCAmc2NyYXRjaF9waXRj aCwgMCk7Cj4+Pj4+ICAgICAgICAgICAgICAgICBpZ3RfYXNzZXJ0KHRpbGluZ19tb2RlID09IEk5 MTVfVElMSU5HX1gpOwo+Pj4+PiAgICAgICAgICAgICAgICAgaWd0X2Fzc2VydChzY3JhdGNoX3Bp dGNoID09IDQwOTYpOwo+Pj4+PiArCj4+Pj4+ICsgICAgICAgICAgICAgLyoKPj4+Pj4gKyAgICAg ICAgICAgICAgKiBBcyB3ZSB3YW50IHRvIGNvbXBhcmUgb3VyIHRlbXBsYXRlIHRpbGVkIHBhdHRl cm4gYWdhaW5zdAo+Pj4+PiArICAgICAgICAgICAgICAqIHRoZSB0YXJnZXQgYm8sIHdlIG5lZWQg Y29uc2lzdGVudCBzd2l6emxpbmcgb24gYm90aC4KPj4+Pj4gKyAgICAgICAgICAgICAgKi8KPj4+ Pj4gKyAgICAgICAgICAgICBpZ3RfcmVxdWlyZShrbm93bl9zd2l6emxpbmcoc2NyYXRjaF9iby0+ aGFuZGxlKSk7Cj4+Pj4+ICAgICAgICAgICAgICAgICBzdGFnaW5nX2JvID0gZHJtX2ludGVsX2Jv X2FsbG9jKGJ1Zm1nciwgInN0YWdpbmcgYm8iLCBCT19TSVpFLCA0MDk2KTsKPj4+Pj4gICAgICAg ICAgICAgICAgIHRpbGVkX3N0YWdpbmdfYm8gPSBkcm1faW50ZWxfYm9fYWxsb2NfdGlsZWQoYnVm bWdyLCAic2NyYXRjaCBibyIsIDEwMjQsCj4+Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEJPX1NJWkUvNDA5NiwgNCwKPj4+Pj4K Pj4+Pgo+Pj4+IEFub3RoZXIgb3B0aW9uIGNvdWxkIGJlIHRvIGtlZXAgYWxsb2NhdGluZyB1bnRp bCB3ZSBmb3VuZCBvbmUgaW4gdGhlCj4+Pj4gbWVtb3J5IGFyZWEgd2l0aCBjb21wYXRpYmxlIHN3 aXp6bGluZz8gTGlrZSB0aGlzIGl0IG1heSBiZSBzb21lIG5vaXNlIGluCj4+Pj4gdGhlIHRlc3Qg cGFzczwtPnNraXAgdHJhbnNpdGlvbnMuCj4+Pgo+Pj4gSXQgZGVwZW5kcyBvbiBwaHlzaWNhbCBs YXlvdXQgd2hpY2ggdGhlIGtlcm5lbCBrZWVwcyBoaWRkZW4gKGZvcgo+Pj4gdW5kZXJzdGFuZGFi bGUgcmVhc29ucykuCj4+Cj4+IFllYWgsIGJ1dCB3ZSBjb3VsZCBhbGxvY2F0ZSBtb3JlIGFuZCBt b3JlIHVudGlsIHdlIGVuZCB1cCBpbiB0aGUgYXJlYQo+PiB3aGVyZSBhcmdzLnBoeXNfc3dpenps ZV9tb2RlID09IGFyZ3Muc3dpenpsZV9tb2RlLiBNaWdodCBiZSB0byBoZWF2eQo+PiBhcHByb2Fj aC4gQnV0IHRoZW4gdGhpcyBza2lwIGNhbiBiZSByYW5kb20gZGVwZW5kaW5nIG9uIHdoYXQgcGh5 c2ljYWwKPj4gbWVtb3J5IGdldHMgYWxsb2NhdGVkIGluIGVhY2ggdGVzdCBydW4uCj4gCj4gQWgs IGJ1dCBwaHlzX3N3aXp6bGVfbW9kZSBhbmQgc3dpenpsZV9tb2RlIGFyZSBpbnZhcmlhbnRzIGRl dGVybWluZWQKPiBkdXJpbmcgYm9vdCBmb3IgZWFjaCBmZW5jZS10aWxpbmcgdHlwZS4KClRydWUs IGdldF90aWxpbmcgaW9jdGwgaGFzIG5vdGhpbmcgb24gdGhhdCBsZXZlbC4gSSBkb250JyBrbm93 IHdoZXJlIHdhcyAKSS4gSGFkIHRoaXMgaWRlYXMgYWJvdXQgbXVsdGktYmFuayBSQU0gd2l0aCBv bmUgYmFuayBzaW5nbGUgY2hhbm5lbCwgCmFub3RoZXIgbXVsdGktY2hhbm5lbCBhbmQgdGhlbiBz d2l6emxpbmcgZGlmZmVyaW5nIGJldHdlZW4gdGhlIHR3by4KCk9rYXksIHRoZW4gcXVlc3Rpb24g cmVtYWlucyBpZiB5b3UganVzdCB3YW50IHRvIGRyb3AgdGhlIGxvY2FsIHN0cnVjdCAKYW5kIGlv Y3RsIGRlZmluaXRpb24gc2luY2UgQUZBSUNTIHRoZSBzYW1lIGRlZmluaXRpb25zIGFyZSBpbiB0 aGUga2VybmVsIApzaW5jZSAyMDEyLgoKUmVnYXJkcywKClR2cnRrbwoKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=