From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: Naladala Ramanaidu <ramanaidu.naladala@intel.com>,
<igt-dev@lists.freedesktop.org>
Cc: <kunal1.joshi@intel.com>
Subject: Re: [PATCH i-g-t v7 1/5] tests/kms_plane_scaling: Update the single plane scaling function arguments
Date: Thu, 18 Jul 2024 19:52:58 +0530 [thread overview]
Message-ID: <1c355bf4-80c9-4052-bc63-65e114622c12@intel.com> (raw)
In-Reply-To: <20240718140546.676903-2-ramanaidu.naladala@intel.com>
On 7/18/2024 7:35 PM, Naladala Ramanaidu wrote:
> Update the helper test_scaler_with_modifier_pipe,
> test_scaler_with_rotation_pipe and test_scaler_with_pixel_format_pipe
> to use a scaling_factor and is_clip_clamp flag instead of explicit
> width and height parameters. This change simplifies the function interfaces
> and allows for testing scenarios, where we need to recalculate the width
> and height based on the display mode. Adjusted all function calls to match
> new argument order.
>
> v2: Update the function arguments (Ankit)
> v3: Remove unwanted changes (Ankit)
>
> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
> tests/kms_plane_scaling.c | 81 +++++++++++++++++++++++----------------
> 1 file changed, 48 insertions(+), 33 deletions(-)
>
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 3f63d3cf4..450381831 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -569,7 +569,8 @@ static void cleanup_crtc(data_t *data)
> static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
> uint32_t pixel_format,
> uint64_t modifier,
> - int width, int height,
> + double sf_plane,
> + bool is_clip_clamp,
> bool is_upscale,
> enum pipe pipe,
> igt_output_t *output,
> @@ -579,8 +580,16 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
> drmModeModeInfo *mode;
> int commit_ret;
> int w, h;
> + int width, height;
>
> mode = igt_output_get_mode(output);
> + if (is_clip_clamp == true) {
> + width = mode->hdisplay + 100;
> + height = mode->vdisplay + 100;
> + } else {
> + width = get_width(mode, sf_plane);
> + height = get_height(mode, sf_plane);
> + }
>
> if (is_upscale) {
> w = width;
> @@ -693,7 +702,8 @@ static const uint64_t modifiers[] = {
> };
>
> static void test_scaler_with_modifier_pipe(data_t *d,
> - int width, int height,
> + double sf_plane,
> + bool is_clip_clamp,
> bool is_upscale,
> enum pipe pipe,
> igt_output_t *output)
> @@ -716,7 +726,8 @@ static void test_scaler_with_modifier_pipe(data_t *d,
> if (igt_plane_has_format_mod(plane, format, modifier))
> check_scaling_pipe_plane_rot(d, plane,
> format, modifier,
> - width, height,
> + sf_plane,
> + is_clip_clamp,
> is_upscale,
> pipe, output,
> IGT_ROTATION_0);
> @@ -725,7 +736,8 @@ static void test_scaler_with_modifier_pipe(data_t *d,
> }
>
> static void test_scaler_with_rotation_pipe(data_t *d,
> - int width, int height,
> + double sf_plane,
> + bool is_clip_clamp,
> bool is_upscale,
> enum pipe pipe,
> igt_output_t *output)
> @@ -749,7 +761,8 @@ static void test_scaler_with_rotation_pipe(data_t *d,
> if (igt_plane_has_rotation(plane, rot))
> check_scaling_pipe_plane_rot(d, plane,
> format, modifier,
> - width, height,
> + sf_plane,
> + is_clip_clamp,
> is_upscale,
> pipe, output,
> rot);
> @@ -757,8 +770,11 @@ static void test_scaler_with_rotation_pipe(data_t *d,
> }
> }
>
> -static void test_scaler_with_pixel_format_pipe(data_t *d, int width, int height, bool is_upscale,
> - enum pipe pipe, igt_output_t *output)
> +static void test_scaler_with_pixel_format_pipe(data_t *d, double sf_plane,
> + bool is_clip_clamp,
> + bool is_upscale,
> + enum pipe pipe,
> + igt_output_t *output)
> {
> igt_display_t *display = &d->display;
> uint64_t modifier = DRM_FORMAT_MOD_LINEAR;
> @@ -787,9 +803,11 @@ static void test_scaler_with_pixel_format_pipe(data_t *d, int width, int height,
> can_scale(d, format))
> check_scaling_pipe_plane_rot(d, plane,
> format, modifier,
> - width, height,
> + sf_plane,
> + is_clip_clamp,
> is_upscale,
> - pipe, output, IGT_ROTATION_0);
> + pipe, output,
> + IGT_ROTATION_0);
> }
>
> igt_vec_fini(&tested_formats);
> @@ -1307,13 +1325,12 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> continue;
>
> igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
> - drmModeModeInfo *mode = igt_output_get_mode(output);
>
> test_scaler_with_pixel_format_pipe(&data,
> - get_width(mode, scaler_with_pixel_format_tests[index].sf),
> - get_height(mode, scaler_with_pixel_format_tests[index].sf),
> - scaler_with_pixel_format_tests[index].is_upscale,
> - pipe, output);
> + scaler_with_pixel_format_tests[index].sf,
> + false,
> + scaler_with_pixel_format_tests[index].is_upscale,
> + pipe, output);
> }
> break;
> }
> @@ -1332,13 +1349,12 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> continue;
>
> igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
> - drmModeModeInfo *mode = igt_output_get_mode(output);
>
> test_scaler_with_rotation_pipe(&data,
> - get_width(mode, scaler_with_rotation_tests[index].sf),
> - get_height(mode, scaler_with_rotation_tests[index].sf),
> - scaler_with_rotation_tests[index].is_upscale,
> - pipe, output);
> + scaler_with_rotation_tests[index].sf,
> + false,
> + scaler_with_rotation_tests[index].is_upscale,
> + pipe, output);
> }
> break;
> }
> @@ -1357,13 +1373,12 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> continue;
>
> igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
> - drmModeModeInfo *mode = igt_output_get_mode(output);
>
> test_scaler_with_modifier_pipe(&data,
> - get_width(mode, scaler_with_modifiers_tests[index].sf),
> - get_height(mode, scaler_with_modifiers_tests[index].sf),
> - scaler_with_modifiers_tests[index].is_upscale,
> - pipe, output);
> + scaler_with_modifiers_tests[index].sf,
> + false,
> + scaler_with_modifiers_tests[index].is_upscale,
> + pipe, output);
> }
> break;
> }
> @@ -1381,10 +1396,10 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> continue;
>
> igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
> - drmModeModeInfo *mode = igt_output_get_mode(output);
>
> - test_scaler_with_pixel_format_pipe(&data, mode->hdisplay + 100,
> - mode->vdisplay + 100, false, pipe, output);
> + test_scaler_with_pixel_format_pipe(&data, 0.0, true,
> + false, pipe,
> + output);
> }
> break;
> }
> @@ -1401,10 +1416,10 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> continue;
>
> igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
> - drmModeModeInfo *mode = igt_output_get_mode(output);
>
> - test_scaler_with_rotation_pipe(&data, mode->hdisplay + 100,
> - mode->vdisplay + 100, false, pipe, output);
> + test_scaler_with_rotation_pipe(&data, 0.0, true,
> + false, pipe,
> + output);
> }
> break;
> }
> @@ -1421,9 +1436,9 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> continue;
>
> igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
> - drmModeModeInfo *mode = igt_output_get_mode(output);
> - test_scaler_with_modifier_pipe(&data, mode->hdisplay + 100,
> - mode->vdisplay + 100, false, pipe, output);
> + test_scaler_with_modifier_pipe(&data, 0.0, true,
> + false, pipe,
> + output);
> }
> break;
> }
next prev parent reply other threads:[~2024-07-18 14:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 14:05 [PATCH i-g-t v7 0/5] tests/kms_plane_scaling: Improvise the scaling BW issues Naladala Ramanaidu
2024-07-18 14:05 ` [PATCH i-g-t v7 1/5] tests/kms_plane_scaling: Update the single plane scaling function arguments Naladala Ramanaidu
2024-07-18 14:22 ` Nautiyal, Ankit K [this message]
2024-07-18 14:05 ` [PATCH i-g-t v7 2/5] tests/kms_plane_scaling: Update the multi " Naladala Ramanaidu
2024-07-18 14:05 ` [PATCH i-g-t v7 3/5] tests/kms_plane_scaling: Find display mode fitting in BW Naladala Ramanaidu
2024-07-18 14:05 ` [PATCH i-g-t v7 4/5] tests/kms_plane_scaling: Find display mode fitting in BW for rotations Naladala Ramanaidu
2024-07-18 14:05 ` [PATCH i-g-t v7 5/5] HAX patch do not merge Naladala Ramanaidu
2024-07-18 14:24 ` [PATCH i-g-t v7 0/5] tests/kms_plane_scaling: Improvise the scaling BW issues Nautiyal, Ankit K
2024-07-18 14:42 ` ✗ GitLab.Pipeline: warning for tests/kms_plane_scaling: Improvise the scaling BW issues. (rev7) Patchwork
2024-07-18 15:04 ` ✗ CI.xeBAT: failure " Patchwork
2024-07-18 20:00 ` ✗ CI.xeBAT: failure for tests/kms_plane_scaling: Improvise the scaling BW issues. (rev8) Patchwork
2024-07-18 21:06 ` ✗ CI.xeFULL: failure for tests/kms_plane_scaling: Improvise the scaling BW issues. (rev7) Patchwork
2024-07-19 2:16 ` ✗ CI.xeFULL: failure for tests/kms_plane_scaling: Improvise the scaling BW issues. (rev8) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c355bf4-80c9-4052-bc63-65e114622c12@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kunal1.joshi@intel.com \
--cc=ramanaidu.naladala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox