From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Petri Latvala <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] automake: Repair overlay build
Date: Mon, 3 Jun 2019 13:56:19 +0100 [thread overview]
Message-ID: <1c71d491-3952-9c4b-3a2a-8685547b8c2c@linux.intel.com> (raw)
In-Reply-To: <20190524214351.18827-1-chris@chris-wilson.co.uk>
On 24/05/2019 22:43, Chris Wilson wrote:
> This partially reverts commit 9141edea9931db0ca1dfcf476da8bdd370702cc4.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> ---
> configure.ac | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 7467e6204..754a55851 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -122,6 +122,21 @@ case "$target_cpu" in
> ;;
> esac
>
> +if test x"$build_x86" = xyes; then
> + PKG_CHECK_MODULES(OVERLAY_XVLIB, [xv x11 xext dri2proto >= 2.6], enable_overlay_xvlib=yes, enable_overlay_xvlib=no)
> + PKG_CHECK_MODULES(OVERLAY_XLIB, [cairo-xlib dri2proto >= 2.6], enable_overlay_xlib=yes, enable_overlay_xlib=no)
> +
> + AC_CHECK_TOOL([LEG], [leg])
> + if test x"$LEG" != xleg; then
> + enable_overlay_xvlib="no"
> + enable_overlay_xlib="no"
> + AC_MSG_NOTICE([Failed to find leg, required for overlay, try : apt-get install peg])
> + fi
> +else
> + enable_overlay_xvlib="no"
> + enable_overlay_xlib="no"
> + BUILD_SHADER_DEBUGGER="no"
This line might need to be removed, but otherwise:
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
> +fi
> AM_CONDITIONAL(BUILD_X86, [test "x$build_x86" = xyes])
>
> AM_CONDITIONAL(BUILD_OVERLAY_XVLIB, [test "x$enable_overlay_xvlib" = xyes])
> @@ -231,7 +246,6 @@ if test "x$NOUVEAU" = xyes; then
> fi
> AM_CONDITIONAL(HAVE_LIBDRM_NOUVEAU, [test "x$NOUVEAU" = xyes])
>
> -# enable debug symbols
> AC_ARG_ENABLE(debug,
> AS_HELP_STRING([--disable-debug],
> [Build tests without debug symbols]),
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-06-03 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 21:43 [igt-dev] [PATCH i-g-t] automake: Repair overlay build Chris Wilson
2019-05-26 11:03 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-05-26 15:26 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-06-03 12:56 ` Tvrtko Ursulin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c71d491-3952-9c4b-3a2a-8685547b8c2c@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox