From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 75B626ED87 for ; Tue, 15 Jan 2019 16:16:10 +0000 (UTC) Message-ID: <1cfb7ac8169f338d936caf730da746bb0fbfbe1e.camel@bootlin.com> From: Paul Kocialkowski Date: Tue, 15 Jan 2019 17:15:58 +0100 In-Reply-To: <20190114164010.GC20097@intel.com> References: <20190108152001.5367-4-maxime.ripard@bootlin.com> <20190110143854.GX20097@intel.com> <20190114164010.GC20097@intel.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v2 04/13] igt: fb: Move i915 YUV buffer clearing code to a function List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: Petri Latvala , eben@raspberrypi.org, igt-dev@lists.freedesktop.org, Thomas Petazzoni List-ID: SGksCgpPbiBNb24sIDIwMTktMDEtMTQgYXQgMTg6NDAgKzAyMDAsIFZpbGxlIFN5cmrDpGzDpCB3 cm90ZToKPiBPbiBNb24sIEphbiAxNCwgMjAxOSBhdCAwNDoxMzowMlBNICswMTAwLCBQYXVsIEtv Y2lhbGtvd3NraSB3cm90ZToKPiA+IEhpLAo+ID4gCj4gPiBPbiBUaHUsIDIwMTktMDEtMTAgYXQg MTY6MzggKzAyMDAsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPiA+ID4gT24gVGh1LCBKYW4gMTAs IDIwMTkgYXQgMTE6MTA6MDlBTSArMDEwMCwgUGF1bCBLb2NpYWxrb3dza2kgd3JvdGU6Cj4gPiA+ ID4gT24gVHVlLCAyMDE5LTAxLTA4IGF0IDE2OjE5ICswMTAwLCBNYXhpbWUgUmlwYXJkIHdyb3Rl Ogo+ID4gPiA+ID4gVGhlIFlVViBidWZmZXIgYWxsb2NhdGlvbiBwYXRoIGZvciB0aGUgaTkxNSBk cml2ZXIgYWxzbyBoYXMgc29tZSBjb2RlIHRvCj4gPiA+ID4gPiBjbGVhciBhIFlVViBidWZmZXIu Cj4gPiA+ID4gPiAKPiA+ID4gPiA+IEFzIHRoYXQgaXMgZ29pbmcgdG8gYmUgdXNlZnVsIGZvciBh bGwgdGhlIG90aGVyIGRyaXZlcnMsIGxldCdzIG1vdmUgaXQgdG8KPiA+ID4gPiA+IGEgc2VwYXJh dGUgZnVuY3Rpb24uCj4gPiA+ID4gPiAKPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IE1heGltZSBS aXBhcmQgPG1heGltZS5yaXBhcmRAYm9vdGxpbi5jb20+Cj4gPiA+ID4gCj4gPiA+ID4gSSdtIG5v dCByZWFsbHkgc3VyZSB3aHkgY2xlYXJpbmcgdGhlIGJ1ZmZlcnMgaXMgYSB1c2VmdWwgdGhpbmcg dG8gZG8KPiA+ID4gPiBhbmQgd2h5IHdlIHNob3VsZCBvbmx5IGRvIGl0IGZvciBZVVYgYW5kIG5v dCBSR0IgZm9ybWF0cy4KPiA+ID4gCj4gPiA+IDAgPSBibGFjayBmb3IgUkdCLCAwICE9IGJsYWNr IGZvciBZVVYuIFRoZSBtZW1zZXQgd2FzIGp1c3QgdG8gbWFrZQo+ID4gPiB0aGluZ3MgbW9yZSBj b25zaXN0ZW50LiBCdXQgbm90IHN1cmUgaWYgYW55IHRlc3Qgd291bGQgYWN0dWFsbHkKPiA+ID4g ZmFpbCBpZiB3ZSBqdXN0IGRyb3AgdGhlIG1lbXNldC4KPiA+IAo+ID4gUmlnaHQsIEkgdW5kZXJz dGFuZCB0aGF0IHRoaXMgaXMgcmVxdWlyZWQgZm9yIHNldHRpbmcgdGhlIGZyYW1lYnVmZmVyCj4g PiB0byBibGFjaywgYnV0IEknbSBqdXN0IHdvbmRlcmluZyB3aHkgdGhpcyBoYXMgdG8gYmUgZG9u ZSBpbiB0aGUgZmlyc3QKPiA+IHBsYWNlLgo+ID4gCj4gPiBBcyBmYXIgYXMgSSBrbm93LCAoUkdC KSBidWZmZXJzIGFsbG9jYXRlZCB3aXRoIEdFTSBhcmUgbm90IHplcm8tZWQgYnkKPiA+IHRoZSBh bGxvY2F0b3IsCj4gCj4gVGhleSBhcmUgemVyb2VkLiBZb3Ugd291bGRuJ3Qgd2FudCB0aGUga2Vy bmVsIHRvIGxlYWsgcmFuZG9tCj4gbWVtb3J5IGNvbnRlbnRzIGFsbCBvdmVyLgoKT2ggbXkgbWlz dGFrZSEgSXQgZGVmaW5pdGVseSBtYWtlcyBzZW5zZSB0aGF0IHRoZSBrZXJuZWwgZG9lcyB0aGF0 LgpMZXQncyBrZWVwIHRoaW5ncyBjb25zaXN0ZW50IGFuZCBoYXZlIGFsbCBidWZmZXJzIGluaXRp YWxpemVkIHdpdGgKYmxhY2sgdGhlbi4KCkNoZWVycywKClBhdWwKCj4gPiBub3IgYnkgYW55IGNv bXBvbmVudCBpbiBJR1QuIFNvIEknbSB3b25kZXJpbmcgd2h5IHdlJ3JlCj4gPiB0YWtpbmcgdGhl IGV4dHJhIHRpbWUgZm9yIGNsZWFyaW5nIGJ1ZmZlcnMgaW4gdGhlIFlVViBjYXNlLgo+ID4gCj4g PiBDaGVlcnMsCj4gPiAKPiA+IFBhdWwKPiA+IAo+ID4gPiA+IEFueXdheSwgc2luY2UgdGhpcyBj b2RlIHdhcyBhbHJlYWR5IHRoZXJlIGFuZCB0aGUgcmVmYWN0b3JpbmcKPiA+ID4gPiBkZWZpbml0 ZWx5IG1ha2VzIHNlbnNlOgo+ID4gPiA+IAo+ID4gPiA+IFJldmlld2VkLWJ5OiBQYXVsIEtvY2lh bGtvd3NraSA8cGF1bC5rb2NpYWxrb3dza2lAYm9vdGxpbi5jb20+Cj4gPiA+ID4gCj4gPiA+ID4g Q2hlZXJzLAo+ID4gPiA+IAo+ID4gPiA+IFBhdWwKPiA+ID4gPiAKPiA+ID4gPiA+IC0tLQo+ID4g PiA+ID4gIGxpYi9pZ3RfZmIuYyB8IDgwICsrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+ID4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgNDIgaW5zZXJ0 aW9ucygrKSwgMzggZGVsZXRpb25zKC0pCj4gPiA+ID4gPiAKPiA+ID4gPiA+IGRpZmYgLS1naXQg YS9saWIvaWd0X2ZiLmMgYi9saWIvaWd0X2ZiLmMKPiA+ID4gPiA+IGluZGV4IDQ1NjkxZmQ0NDFk OS4uZDY5YzNmYjJkMzhkIDEwMDY0NAo+ID4gPiA+ID4gLS0tIGEvbGliL2lndF9mYi5jCj4gPiA+ ID4gPiArKysgYi9saWIvaWd0X2ZiLmMKPiA+ID4gPiA+IEBAIC00ODQsNiArNDg0LDQ3IEBAIHVp bnQ2NF90IGlndF9mYl90aWxpbmdfdG9fbW9kKHVpbnQ2NF90IHRpbGluZykKPiA+ID4gPiA+ICAJ fQo+ID4gPiA+ID4gIH0KPiA+ID4gPiA+ICAKPiA+ID4gPiA+ICtzdGF0aWMgdm9pZCBjbGVhcl95 dXZfYnVmZmVyKHN0cnVjdCBpZ3RfZmIgKmZiKQo+ID4gPiA+ID4gK3sKPiA+ID4gPiA+ICsJYm9v bCBmdWxsX3JhbmdlID0gZmItPmNvbG9yX3JhbmdlID09IElHVF9DT0xPUl9ZQ0JDUl9GVUxMX1JB TkdFOwo+ID4gPiA+ID4gKwl2b2lkICpwdHI7Cj4gPiA+ID4gPiArCj4gPiA+ID4gPiArCWlndF9h c3NlcnQoaWd0X2Zvcm1hdF9pc195dXYoZmItPmRybV9mb3JtYXQpKTsKPiA+ID4gPiA+ICsKPiA+ ID4gPiA+ICsJLyogRW5zdXJlIHRoZSBmcmFtZWJ1ZmZlciBpcyBwcmVhbGxvY2F0ZWQgKi8KPiA+ ID4gPiA+ICsJcHRyID0gaWd0X2ZiX21hcF9idWZmZXIoZmItPmZkLCBmYik7Cj4gPiA+ID4gPiAr CWlndF9hc3NlcnQoKih1aW50MzJfdCAqKXB0ciA9PSAwKTsKPiA+ID4gPiA+ICsKPiA+ID4gPiA+ ICsJc3dpdGNoIChmYi0+ZHJtX2Zvcm1hdCkgewo+ID4gPiA+ID4gKwljYXNlIERSTV9GT1JNQVRf TlYxMjoKPiA+ID4gPiA+ICsJCW1lbXNldChwdHIgKyBmYi0+b2Zmc2V0c1swXSwKPiA+ID4gPiA+ ICsJCSAgICAgICBmdWxsX3JhbmdlID8gMHgwMCA6IDB4MTAsCj4gPiA+ID4gPiArCQkgICAgICAg ZmItPnN0cmlkZXNbMF0gKiBmYi0+cGxhbmVfaGVpZ2h0WzBdKTsKPiA+ID4gPiA+ICsJCW1lbXNl dChwdHIgKyBmYi0+b2Zmc2V0c1sxXSwKPiA+ID4gPiA+ICsJCSAgICAgICAweDgwLAo+ID4gPiA+ ID4gKwkJICAgICAgIGZiLT5zdHJpZGVzWzFdICogZmItPnBsYW5lX2hlaWdodFsxXSk7Cj4gPiA+ ID4gPiArCQlicmVhazsKPiA+ID4gPiA+ICsJY2FzZSBEUk1fRk9STUFUX1hZVVY4ODg4Ogo+ID4g PiA+ID4gKwkJd21lbXNldChwdHIgKyBmYi0+b2Zmc2V0c1swXSwgZnVsbF9yYW5nZSA/IDB4MDAw MDgwODAgOiAweDAwMTA4MDgwLAo+ID4gPiA+ID4gKwkJCWZiLT5zdHJpZGVzWzBdICogZmItPnBs YW5lX2hlaWdodFswXSAvIHNpemVvZih3Y2hhcl90KSk7Cj4gPiA+ID4gPiArCQlicmVhazsKPiA+ ID4gPiA+ICsJY2FzZSBEUk1fRk9STUFUX1lVWVY6Cj4gPiA+ID4gPiArCWNhc2UgRFJNX0ZPUk1B VF9ZVllVOgo+ID4gPiA+ID4gKwkJd21lbXNldChwdHIgKyBmYi0+b2Zmc2V0c1swXSwKPiA+ID4g PiA+ICsJCQlmdWxsX3JhbmdlID8gMHg4MDAwODAwMCA6IDB4ODAxMDgwMTAsCj4gPiA+ID4gPiAr CQkJZmItPnN0cmlkZXNbMF0gKiBmYi0+cGxhbmVfaGVpZ2h0WzBdIC8gc2l6ZW9mKHdjaGFyX3Qp KTsKPiA+ID4gPiA+ICsJCWJyZWFrOwo+ID4gPiA+ID4gKwljYXNlIERSTV9GT1JNQVRfVVlWWToK PiA+ID4gPiA+ICsJY2FzZSBEUk1fRk9STUFUX1ZZVVk6Cj4gPiA+ID4gPiArCQl3bWVtc2V0KHB0 ciArIGZiLT5vZmZzZXRzWzBdLAo+ID4gPiA+ID4gKwkJCWZ1bGxfcmFuZ2UgPyAweDAwODAwMDgw IDogMHgxMDgwMTA4MCwKPiA+ID4gPiA+ICsJCQlmYi0+c3RyaWRlc1swXSAqIGZiLT5wbGFuZV9o ZWlnaHRbMF0gLyBzaXplb2Yod2NoYXJfdCkpOwo+ID4gPiA+ID4gKwkJYnJlYWs7Cj4gPiA+ID4g PiArCX0KPiA+ID4gPiA+ICsKPiA+ID4gPiA+ICsJaWd0X2ZiX3VubWFwX2J1ZmZlcihmYiwgcHRy KTsKPiA+ID4gPiA+ICt9Cj4gPiA+ID4gPiArCj4gPiA+ID4gPiAgLyogaGVscGVycyB0byBjcmVh dGUgbmljZS1sb29raW5nIGZyYW1lYnVmZmVycyAqLwo+ID4gPiA+ID4gIHN0YXRpYyBpbnQgY3Jl YXRlX2JvX2Zvcl9mYihzdHJ1Y3QgaWd0X2ZiICpmYikKPiA+ID4gPiA+ICB7Cj4gPiA+ID4gPiBA QCAtNTAxLDUwICs1NDIsMTMgQEAgc3RhdGljIGludCBjcmVhdGVfYm9fZm9yX2ZiKHN0cnVjdCBp Z3RfZmIgKmZiKQo+ID4gPiA+ID4gIAkJZmItPmlzX2R1bWIgPSBmYWxzZTsKPiA+ID4gPiA+ICAK PiA+ID4gPiA+ICAJCWlmIChpc19pOTE1X2RldmljZShmZCkpIHsKPiA+ID4gPiA+IC0JCQl2b2lk ICpwdHI7Cj4gPiA+ID4gPiAtCQkJYm9vbCBmdWxsX3JhbmdlID0gZmItPmNvbG9yX3JhbmdlID09 IElHVF9DT0xPUl9ZQ0JDUl9GVUxMX1JBTkdFOwo+ID4gPiA+ID4gIAo+ID4gPiA+ID4gIAkJCWZi LT5nZW1faGFuZGxlID0gZ2VtX2NyZWF0ZShmZCwgZmItPnNpemUpOwo+ID4gPiA+ID4gIAo+ID4g PiA+ID4gIAkJCWdlbV9zZXRfdGlsaW5nKGZkLCBmYi0+Z2VtX2hhbmRsZSwKPiA+ID4gPiA+ICAJ CQkJICAgICAgIGlndF9mYl9tb2RfdG9fdGlsaW5nKGZiLT50aWxpbmcpLAo+ID4gPiA+ID4gIAkJ CQkgICAgICAgZmItPnN0cmlkZXNbMF0pOwo+ID4gPiA+ID4gLQo+ID4gPiA+ID4gLQkJCWdlbV9z ZXRfZG9tYWluKGZkLCBmYi0+Z2VtX2hhbmRsZSwKPiA+ID4gPiA+IC0JCQkJICAgICAgIEk5MTVf R0VNX0RPTUFJTl9HVFQsIEk5MTVfR0VNX0RPTUFJTl9HVFQpOwo+ID4gPiA+ID4gLQo+ID4gPiA+ ID4gLQkJCS8qIEVuc3VyZSB0aGUgZnJhbWVidWZmZXIgaXMgcHJlYWxsb2NhdGVkICovCj4gPiA+ ID4gPiAtCQkJcHRyID0gZ2VtX21tYXBfX2d0dChmZCwgZmItPmdlbV9oYW5kbGUsCj4gPiA+ID4g PiAtCQkJCQkgICAgZmItPnNpemUsIFBST1RfUkVBRCB8IFBST1RfV1JJVEUpOwo+ID4gPiA+ID4g LQkJCWlndF9hc3NlcnQoKih1aW50MzJfdCAqKXB0ciA9PSAwKTsKPiA+ID4gPiA+IC0KPiA+ID4g PiA+IC0JCQlzd2l0Y2ggKGZiLT5kcm1fZm9ybWF0KSB7Cj4gPiA+ID4gPiAtCQkJY2FzZSBEUk1f Rk9STUFUX05WMTI6Cj4gPiA+ID4gPiAtCQkJCW1lbXNldChwdHIgKyBmYi0+b2Zmc2V0c1swXSwK PiA+ID4gPiA+IC0JCQkJICAgICAgIGZ1bGxfcmFuZ2UgPyAweDAwIDogMHgxMCwKPiA+ID4gPiA+ IC0JCQkJICAgICAgIGZiLT5zdHJpZGVzWzBdICogZmItPnBsYW5lX2hlaWdodFswXSk7Cj4gPiA+ ID4gPiAtCQkJCW1lbXNldChwdHIgKyBmYi0+b2Zmc2V0c1sxXSwKPiA+ID4gPiA+IC0JCQkJICAg ICAgIDB4ODAsCj4gPiA+ID4gPiAtCQkJCSAgICAgICBmYi0+c3RyaWRlc1sxXSAqIGZiLT5wbGFu ZV9oZWlnaHRbMV0pOwo+ID4gPiA+ID4gLQkJCQlicmVhazsKPiA+ID4gPiA+IC0JCQljYXNlIERS TV9GT1JNQVRfWFlVVjg4ODg6Cj4gPiA+ID4gPiAtCQkJCXdtZW1zZXQocHRyICsgZmItPm9mZnNl dHNbMF0sIGZ1bGxfcmFuZ2UgPyAweDAwMDA4MDgwIDogMHgwMDEwODA4MCwKPiA+ID4gPiA+IC0J CQkJCWZiLT5zdHJpZGVzWzBdICogZmItPnBsYW5lX2hlaWdodFswXSAvIHNpemVvZih3Y2hhcl90 KSk7Cj4gPiA+ID4gPiAtCQkJCWJyZWFrOwo+ID4gPiA+ID4gLQkJCWNhc2UgRFJNX0ZPUk1BVF9Z VVlWOgo+ID4gPiA+ID4gLQkJCWNhc2UgRFJNX0ZPUk1BVF9ZVllVOgo+ID4gPiA+ID4gLQkJCQl3 bWVtc2V0KHB0ciArIGZiLT5vZmZzZXRzWzBdLAo+ID4gPiA+ID4gLQkJCQkJZnVsbF9yYW5nZSA/ IDB4ODAwMDgwMDAgOiAweDgwMTA4MDEwLAo+ID4gPiA+ID4gLQkJCQkJZmItPnN0cmlkZXNbMF0g KiBmYi0+cGxhbmVfaGVpZ2h0WzBdIC8gc2l6ZW9mKHdjaGFyX3QpKTsKPiA+ID4gPiA+IC0JCQkJ YnJlYWs7Cj4gPiA+ID4gPiAtCQkJY2FzZSBEUk1fRk9STUFUX1VZVlk6Cj4gPiA+ID4gPiAtCQkJ Y2FzZSBEUk1fRk9STUFUX1ZZVVk6Cj4gPiA+ID4gPiAtCQkJCXdtZW1zZXQocHRyICsgZmItPm9m ZnNldHNbMF0sCj4gPiA+ID4gPiAtCQkJCQlmdWxsX3JhbmdlID8gMHgwMDgwMDA4MCA6IDB4MTA4 MDEwODAsCj4gPiA+ID4gPiAtCQkJCQlmYi0+c3RyaWRlc1swXSAqIGZiLT5wbGFuZV9oZWlnaHRb MF0gLyBzaXplb2Yod2NoYXJfdCkpOwo+ID4gPiA+ID4gLQkJCQlicmVhazsKPiA+ID4gPiA+IC0J CQl9Cj4gPiA+ID4gPiAtCQkJZ2VtX211bm1hcChwdHIsIGZiLT5zaXplKTsKPiA+ID4gPiA+ICsJ CQljbGVhcl95dXZfYnVmZmVyKGZkKTsKPiA+ID4gPiA+ICAKPiA+ID4gPiA+ICAJCQlyZXR1cm4g ZmItPmdlbV9oYW5kbGU7Cj4gPiA+ID4gPiAgCQl9IGVsc2Ugewo+ID4gPiA+IC0tIAo+ID4gPiA+ IFBhdWwgS29jaWFsa293c2tpLCBCb290bGluCj4gPiA+ID4gRW1iZWRkZWQgTGludXggYW5kIGtl cm5lbCBlbmdpbmVlcmluZwo+ID4gPiA+IGh0dHBzOi8vYm9vdGxpbi5jb20KPiA+IC0tIAo+ID4g UGF1bCBLb2NpYWxrb3dza2ksIEJvb3RsaW4KPiA+IEVtYmVkZGVkIExpbnV4IGFuZCBrZXJuZWwg ZW5naW5lZXJpbmcKPiA+IGh0dHBzOi8vYm9vdGxpbi5jb20KLS0gClBhdWwgS29jaWFsa293c2tp LCBCb290bGluCkVtYmVkZGVkIExpbnV4IGFuZCBrZXJuZWwgZW5naW5lZXJpbmcKaHR0cHM6Ly9i b290bGluLmNvbQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==