public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Maciej Patelczyk <maciej.patelczyk@intel.com>
To: Jan Maslak <jan.maslak@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <gwan-gyeong.mun@intel.com>
Subject: Re: [PATCH 1/2] tests/intel/xe_eudebug_online: Set timeout for debugger VM fd sync
Date: Wed, 4 Mar 2026 12:03:39 +0100	[thread overview]
Message-ID: <1d6ef0db-7074-42d5-93c4-c01001bbdc1d@intel.com> (raw)
In-Reply-To: <20260227114133.2850125-2-jan.maslak@intel.com>

On 27/02/2026 12:41, Jan Maslak wrote:

> The vm_open_trigger() function opens a debugger VM fd via
> DRM_XE_EUDEBUG_IOCTL_VM_OPEN leaving timeout_ns at zero. With a zero
> timeout, fsync() on the fd may return -ETIMEDOUT immediately instead of
> waiting for GPU cache invalidation to complete.
>
> Set timeout_ns to DRM_XE_EUDEBUG_VM_SYNC_MAX_TIMEOUT_NSECS to allow
> up to 10 seconds for cache invalidation to complete.
>
> Signed-off-by: Jan Maslak <jan.maslak@intel.com>
> ---
>   tests/intel/xe_eudebug_online.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tests/intel/xe_eudebug_online.c b/tests/intel/xe_eudebug_online.c
> index 059f918a6..6009da4d6 100644
> --- a/tests/intel/xe_eudebug_online.c
> +++ b/tests/intel/xe_eudebug_online.c
> @@ -904,6 +904,7 @@ static void vm_open_trigger(struct xe_eudebug_debugger *d,
>   	struct drm_xe_eudebug_vm_open vo = {
>   		.client_handle = vm->client_handle,
>   		.vm_handle = vm->vm_handle,
> +		.timeout_ns = DRM_XE_EUDEBUG_VM_SYNC_MAX_TIMEOUT_NSECS,
>   	};
>   	int fd;
>   

Oh, good catch!

Reviewed-by: Maciej Patelczyk <maciej.patelczyk@intel.com>


  reply	other threads:[~2026-03-04 11:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27 11:41 [PATCH 0/2] tests/intel/xe_eudebug_online: Fix sporadic failures due to unhandled fsync errors Jan Maslak
2026-02-27 11:41 ` [PATCH 1/2] tests/intel/xe_eudebug_online: Set timeout for debugger VM fd sync Jan Maslak
2026-03-04 11:03   ` Maciej Patelczyk [this message]
2026-02-27 11:41 ` [PATCH 2/2] tests/intel/xe_eudebug_online: Assert fsync return on debugger VM fd Jan Maslak
2026-03-04 11:04   ` Maciej Patelczyk
2026-02-27 20:22 ` ✓ Xe.CI.BAT: success for tests/intel/xe_eudebug_online: Fix sporadic failures due to unhandled fsync errors Patchwork
2026-02-27 20:23 ` ✗ i915.CI.BAT: failure " Patchwork
2026-02-28  8:48 ` ✗ Xe.CI.FULL: " Patchwork
2026-03-04 11:05   ` Maciej Patelczyk
  -- strict thread matches above, loose matches on Subject: below --
2026-03-04 14:36 [PATCH 0/2] " Jan Maslak
2026-03-04 14:36 ` [PATCH 1/2] tests/intel/xe_eudebug_online: Set timeout for debugger VM fd sync Jan Maslak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d6ef0db-7074-42d5-93c4-c01001bbdc1d@intel.com \
    --to=maciej.patelczyk@intel.com \
    --cc=gwan-gyeong.mun@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jan.maslak@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox