Re: [igt-dev] [PATCH i-g-t] intel-ci: Sanitycheck CRC readback on the first pipe only

From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Martin Peres <martin.peres@free.fr>,
	Petri Latvala <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] intel-ci: Sanitycheck CRC readback on the first pipe only
Date: Thu, 11 Apr 2019 18:00:10 +0200	[thread overview]
Message-ID: <1e189a5f-ca1c-5c1f-6c82-71a6748b0935@linux.intel.com> (raw)
In-Reply-To: <20190411105248.25149-1-chris@chris-wilson.co.uk>

Op 11-04-2019 om 12:52 schreef Chris Wilson:
> For fast-feedback, we need to sanitycheck that CRC reads work, otherwise
> the display validation tests are flawed. However, we don't need to
> extensively test each pipe as the HW is fundamentally the same. Instead,
> do the full suite of tests on one pipe, and just verify that the interface
> works for the other pipes. This should speed BAT up by reducing
> NUM_PIPES suspend and resume cycles to just 1.
>
> The shards should cover the extended test suite on all pipes for
> complete validation.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Martin Peres <martin.peres@free.fr>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  tests/intel-ci/fast-feedback.testlist | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index 8ae5e8a28..a3b917fd0 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -205,25 +205,14 @@ igt@kms_force_connector_basic@force-edid
>  igt@kms_force_connector_basic@force-load-detect
>  igt@kms_force_connector_basic@prune-stale-modes
>  igt@kms_frontbuffer_tracking@basic
> -igt@kms_pipe_crc_basic@bad-source
>  igt@kms_pipe_crc_basic@hang-read-crc-pipe-a
> -igt@kms_pipe_crc_basic@hang-read-crc-pipe-b
> -igt@kms_pipe_crc_basic@hang-read-crc-pipe-c
>  igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a
>  igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence
> -igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b
> -igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence
> -igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c
> -igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c-frame-sequence
>  igt@kms_pipe_crc_basic@read-crc-pipe-a
> -igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence
>  igt@kms_pipe_crc_basic@read-crc-pipe-b
> -igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence
>  igt@kms_pipe_crc_basic@read-crc-pipe-c
> -igt@kms_pipe_crc_basic@read-crc-pipe-c-frame-sequence
> +igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence
>  igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
> -igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b
> -igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c
>  igt@kms_psr@primary_page_flip
>  igt@kms_psr@cursor_plane_move
>  igt@kms_psr@sprite_plane_onoff

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Makes sense, we might want to make fastset specific versions sometime in the future..

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev