From: John.C.Harrison@Intel.com
To: IGT-Dev@Lists.FreeDesktop.Org
Subject: [igt-dev] [PATCH i-g-t v2 0/4] scripts/trace.pl: Re-order calculations and fixups
Date: Mon, 22 Jan 2018 22:32:33 -0800 [thread overview]
Message-ID: <20180123063237.32039-1-John.C.Harrison@Intel.com> (raw)
From: John Harrison <John.C.Harrison@Intel.com>
The trace.pl script calculates a bunch of statistics. It also
re-generates some timestamp values to correct issues with the log
being processed. These operations were all mixed up together thus some
were done multiple times (with different results each time). Whereas
some stats were not being re-calculated after the underlying data had
changed and thus were not actually correct at the end. Also, the
ordering of some operations was non-deterministic due to being based
on internal Perl hash ordering.
These patches rationalise all of this processing to ensure that it all
happens in the correct order and in a consistent manner.
v2: Review feedback from Tvrtko Ursulin.
John Harrison (4):
scripts/trace.pl: More hash key optimisations
scripts/trace.pl: Sort order
scripts/trace.pl: Calculate stats only after all munging
scripts/trace.pl: Simplify 'end' & 'notify' generation
scripts/trace.pl | 121 ++++++++++++++++++++++++++++++++++---------------------
1 file changed, 76 insertions(+), 45 deletions(-)
--
2.15.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2018-01-23 6:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 6:32 John.C.Harrison [this message]
2018-01-23 6:32 ` [igt-dev] [PATCH i-g-t v2 1/4] scripts/trace.pl: More hash key optimisations John.C.Harrison
2018-01-24 10:07 ` Tvrtko Ursulin
2018-01-25 16:18 ` John.C.Harrison
2018-01-25 16:24 ` John.C.Harrison
2018-01-25 16:36 ` Tvrtko Ursulin
2018-01-23 6:32 ` [igt-dev] [PATCH i-g-t v2 2/4] scripts/trace.pl: Sort order John.C.Harrison
2018-01-24 10:10 ` Tvrtko Ursulin
2018-01-23 6:32 ` [igt-dev] [PATCH i-g-t v2 3/4] scripts/trace.pl: Calculate stats only after all munging John.C.Harrison
2018-01-24 10:11 ` Tvrtko Ursulin
2018-01-25 18:11 ` Tvrtko Ursulin
2018-01-23 6:32 ` [igt-dev] [PATCH i-g-t v2 4/4] scripts/trace.pl: Simplify 'end' & 'notify' generation John.C.Harrison
2018-01-24 10:12 ` Tvrtko Ursulin
2018-01-23 6:53 ` [igt-dev] ✓ Fi.CI.BAT: success for scripts/trace.pl: Re-order calculations and fixups Patchwork
2018-01-23 10:20 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-01-25 16:40 ` [igt-dev] ✓ Fi.CI.BAT: success for scripts/trace.pl: Re-order calculations and fixups (rev2) Patchwork
2018-01-25 16:57 ` [igt-dev] ✓ Fi.CI.BAT: success for scripts/trace.pl: Re-order calculations and fixups (rev3) Patchwork
2018-01-25 18:04 ` [igt-dev] ✗ Fi.CI.IGT: warning for scripts/trace.pl: Re-order calculations and fixups (rev2) Patchwork
2018-01-25 18:49 ` [igt-dev] ✗ Fi.CI.IGT: failure for scripts/trace.pl: Re-order calculations and fixups (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123063237.32039-1-John.C.Harrison@Intel.com \
--to=john.c.harrison@intel.com \
--cc=IGT-Dev@Lists.FreeDesktop.Org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox