From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_atomic_transition: Don't abuse the HSKEW flag to force a modeset
Date: Tue, 30 Jan 2018 18:57:54 +0200 [thread overview]
Message-ID: <20180130165754.GE5453@intel.com> (raw)
In-Reply-To: <84b95757-b0b7-6d09-f63d-f55237e42306@linux.intel.com>
On Tue, Jan 30, 2018 at 04:51:09PM +0100, Maarten Lankhorst wrote:
> Op 30-01-18 om 16:49 schreef Ville Syrjala:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Since kernel commit e995ca0b8139 ("drm/i915: Provide a device level
> > .mode_valid() hook") i915 will bluntly reject the HSKEW mode flag. Thus
> > we can't abuse it to force a modeset.
> >
> > Since we don't particularly care about the visual results here we can
> > risk making the display unhappy by eg. flipping the hsync polarity
> > instead.
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Pushed, thanks.
> > Also add a comment documenting why we're doing this.
> >
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104848
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > tests/kms_atomic_transition.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
> > index 798639393421..aa9a6f8439ea 100644
> > --- a/tests/kms_atomic_transition.c
> > +++ b/tests/kms_atomic_transition.c
> > @@ -410,7 +410,8 @@ run_transition_test(igt_display_t *display, enum pipe pipe, igt_output_t *output
> >
> > mode = igt_output_get_mode(output);
> > override_mode = *mode;
> > - override_mode.flags |= DRM_MODE_FLAG_HSKEW;
> > + /* try to force a modeset */
> > + override_mode.flags ^= DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NHSYNC;
> >
> > igt_create_fb(display->drm_fd, mode->hdisplay, mode->vdisplay,
> > DRM_FORMAT_XRGB8888, LOCAL_DRM_FORMAT_MOD_NONE, &fb);
>
--
Ville Syrjälä
Intel OTC
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-01-30 16:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 15:49 [igt-dev] [PATCH i-g-t] tests/kms_atomic_transition: Don't abuse the HSKEW flag to force a modeset Ville Syrjala
2018-01-30 15:51 ` Maarten Lankhorst
2018-01-30 16:57 ` Ville Syrjälä [this message]
2018-01-30 21:05 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2018-02-28 12:20 ` Arkadiusz Hiler
2018-02-28 12:46 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130165754.GE5453@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox