From: Tvrtko Ursulin <tursulin@ursulin.net>
To: igt-dev@lists.freedesktop.org
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: [igt-dev] [PATCH i-g-t 2/3] tests/perf_pmu: Handle thermally throttled devices
Date: Thu, 8 Feb 2018 08:01:30 +0000 [thread overview]
Message-ID: <20180208080131.3004-2-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20180208080131.3004-1-tvrtko.ursulin@linux.intel.com>
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Some systems cannot reach the advertised maximum frequency due throttling.
Handle them by considering a 100MHz lower limit.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tests/perf_pmu.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
index 70fb6bd55e53..07b25765f1f6 100644
--- a/tests/perf_pmu.c
+++ b/tests/perf_pmu.c
@@ -1222,8 +1222,13 @@ test_frequency(int gem_fd)
min[0], min[1]);
igt_info("Max frequency: requested %.1f, actual %.1f\n",
max[0], max[1]);
+
assert_within_epsilon(min[0], min_freq, tolerance);
- assert_within_epsilon(max[0], max_freq, tolerance);
+ /*
+ * On thermally throttled devices we cannot be sure maximum frequency
+ * can be reached so use a lower limit.
+ */
+ igt_assert(max[0] >= ((double)max_freq - 100.0));
}
static bool wait_for_rc6(int fd)
--
2.14.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-02-08 8:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 8:01 [igt-dev] [PATCH i-g-t 1/3] tests/perf_pmu: Use perf timestamps in a few more places Tvrtko Ursulin
2018-02-08 8:01 ` Tvrtko Ursulin [this message]
2018-02-08 8:10 ` [igt-dev] [PATCH i-g-t 2/3] tests/perf_pmu: Handle thermally throttled devices Chris Wilson
2018-02-12 9:47 ` [igt-dev] [PATCH i-g-t v2 " Tvrtko Ursulin
2018-02-12 10:00 ` Chris Wilson
2018-02-12 11:35 ` [igt-dev] [PATCH i-g-t v3 " Tvrtko Ursulin
2018-02-08 8:01 ` [igt-dev] [PATCH i-g-t 3/3] tests/perf_pmu: Give sampling more time Tvrtko Ursulin
2018-02-08 8:13 ` Chris Wilson
2018-02-12 9:55 ` Tvrtko Ursulin
2018-02-12 10:02 ` Chris Wilson
2018-02-12 11:36 ` [igt-dev] [PATCH i-g-t v2 " Tvrtko Ursulin
2018-02-12 11:39 ` Chris Wilson
2018-02-08 8:09 ` [igt-dev] [PATCH i-g-t 1/3] tests/perf_pmu: Use perf timestamps in a few more places Chris Wilson
2018-02-12 9:46 ` [igt-dev] [PATCH i-g-t v2 " Tvrtko Ursulin
2018-02-12 9:57 ` Chris Wilson
2018-02-08 10:27 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] " Patchwork
2018-02-08 15:13 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-02-12 10:28 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/3] tests/perf_pmu: Use perf timestamps in a few more places (rev3) Patchwork
2018-02-12 12:02 ` [igt-dev] ✗ Fi.CI.IGT: warning " Patchwork
2018-02-12 16:44 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/3] tests/perf_pmu: Use perf timestamps in a few more places (rev5) Patchwork
2018-02-12 17:02 ` Patchwork
2018-02-12 19:00 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-02-12 19:40 ` Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180208080131.3004-2-tvrtko.ursulin@linux.intel.com \
--to=tursulin@ursulin.net \
--cc=igt-dev@lists.freedesktop.org \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox