From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <intel-gfx-bounces@lists.freedesktop.org>
Date: Fri, 2 Mar 2018 10:27:45 +0200
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Message-ID: <20180302082745.GH5453@intel.com>
References: <20180302081235.28346-1-chris@chris-wilson.co.uk>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20180302081235.28346-1-chris@chris-wilson.co.uk>
Subject: Re: [Intel-gfx] [PATCH igt v2] igt/gen7_forcewake_mt: Make the mmio
 register as volatile
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
List-ID: <igt-dev@lists.freedesktop.org>

T24gRnJpLCBNYXIgMDIsIDIwMTggYXQgMDg6MTI6MzVBTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IFByZXZlbnQgdGhlIGNvbXBpbGVyIGZyb20gY2FjaGluZyByZWFkcy93cml0ZXMgdG8g
dGhlIGh3IHJlZ2lzdGVyIGFzIHdlCj4gZG8gd2FudCB0byBwZXJmb3JtIG1taW8uCj4gCj4gV2hp
bHN0IGZpeGluZyB1cCB0aGUgbW1pbyBhY2Nlc3MsIGFsc28gZW5zdXJlIHRoYXQgd2UgZG8gbm90
IGxlYXZlIHRoZQo+IHRlc3Qgd2l0aCBhbnkgb3RoZXIgYml0cyBzdGlsbCBzZXQgaW4gdGhlIGZv
cmNld2FrZSByZWdpc3RlciB0byBwcmV2ZW50Cj4gYWZmZWN0aW5nIG90aGVyIHRlc3RzLCBhcyBz
cG90dGVkIGJ5IFR2cnRrby4KCkkgd29uZGVyIHdoeSB0aGlzIHRlc3QgaXNuJ3QgdXNpbmcgaW50
ZWxfcmVnaXN0ZXJfYWNjZXNzX2luaXQoKSAmIGNvLj8KTWF5YmUgYmVjYXVzZSB0aGUgbGlicmFy
eSBjb2RlIHVzZWQgdG8gdGFrZSB0aGUgZm9yY2V3YWtlIGFsd2F5cz8gQnV0CnRoYXQgY291bGQg
YmUgcHJldmVudGVkIHdpdGggYSBzZXRlbnYoKSBub3cuCgo+IAo+IFNpZ25lZC1vZmYtYnk6IENo
cmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBUdnJ0a28gVXJzdWxp
biA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IC0tLQo+ICB0ZXN0cy9nZW43X2ZvcmNld2Fr
ZV9tdC5jIHwgNTkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0t
LS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQ3IGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQo+
IAo+IGRpZmYgLS1naXQgYS90ZXN0cy9nZW43X2ZvcmNld2FrZV9tdC5jIGIvdGVzdHMvZ2VuN19m
b3JjZXdha2VfbXQuYwo+IGluZGV4IDA3MzIwZWY5Li4yMThmNjc0YyAxMDA2NDQKPiAtLS0gYS90
ZXN0cy9nZW43X2ZvcmNld2FrZV9tdC5jCj4gKysrIGIvdGVzdHMvZ2VuN19mb3JjZXdha2VfbXQu
Ywo+IEBAIC00NCw5ICs0NCwxMCBAQCBJR1RfVEVTVF9ERVNDUklQVElPTigiRXhlcmNpc2UgYSBz
dXNwZWN0IHdvcmthcm91bmQgcmVxdWlyZWQgZm9yIgo+ICAKPiAgc3RydWN0IHRocmVhZCB7Cj4g
IAlwdGhyZWFkX3QgdGhyZWFkOwo+IC0Jdm9pZCAqbW1pbzsKPiArCXZvbGF0aWxlIHVpbnQzMl90
ICptbWlvOwo+ICAJaW50IGZkOwo+ICAJaW50IGJpdDsKPiArCWJvb2wgZG9uZTsKPiAgfTsKPiAg
Cj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgcGNpX2lkX21hdGNoIG1hdGNoW10gPSB7Cj4gQEAgLTgw
LDcgKzgxLDcgQEAgc3RhdGljIHN0cnVjdCBwY2lfZGV2aWNlICpfX2lnZnhfZ2V0KHZvaWQpCj4g
IAlyZXR1cm4gZGV2Owo+ICB9Cj4gIAo+IC1zdGF0aWMgdm9pZCAqaWdmeF9nZXRfbW1pbyh2b2lk
KQo+ICtzdGF0aWMgdm9sYXRpbGUgdWludDMyX3QgKmlnZnhfZ2V0X2ZvcmNld2FrZV9tdCh2b2lk
KQo+ICB7Cj4gIAlzdHJ1Y3QgcGNpX2RldmljZSAqcGNpID0gX19pZ2Z4X2dldCgpOwo+ICAJdm9p
ZCAqbW1pbyA9IE5VTEw7Cj4gQEAgLTEwMCwyMCArMTAxLDI4IEBAIHN0YXRpYyB2b2lkICppZ2Z4
X2dldF9tbWlvKHZvaWQpCj4gIAlpZ3RfYXNzZXJ0X2VxKGVycm9yLCAwKTsKPiAgCWlndF9hc3Nl
cnQobW1pbyAhPSBOVUxMKTsKPiAgCj4gLQlyZXR1cm4gbW1pbzsKPiArCXJldHVybiAodm9sYXRp
bGUgdWludDMyX3QgKikoKGNoYXIgKiltbWlvICsgRk9SQ0VXQUtFX01UKTsKPiAgfQo+ICAKPiAr
Cj4gIHN0YXRpYyB2b2lkICp0aHJlYWQodm9pZCAqYXJnKQo+ICB7Cj4gKwlzdGF0aWMgY29uc3Qg
Y2hhciBhY3F1aXJlX2Vycm9yW10gPSAiYWNxdWlyZSI7Cj4gKwlzdGF0aWMgY29uc3QgY2hhciBy
ZWxlYXNlX2Vycm9yW10gPSAicmVsZWFzZSI7Cj4gKwo+ICAJc3RydWN0IHRocmVhZCAqdCA9IGFy
ZzsKPiAtCXVpbnQzMl90ICpmb3JjZXdha2VfbXQgPSAodWludDMyX3QgKikoKGNoYXIgKil0LT5t
bWlvICsgRk9SQ0VXQUtFX01UKTsKPiAtCXVpbnQzMl90IGJpdCA9IDEgPDwgdC0+Yml0Owo+ICsJ
Y29uc3QgdWludDMyX3QgYml0ID0gMSA8PCB0LT5iaXQ7Cj4gKwl2b2xhdGlsZSB1aW50MzJfdCAq
Zm9yY2V3YWtlX210ID0gdC0+bW1pbzsKPiAgCj4gLQl3aGlsZSAoMSkgewo+ICsJd2hpbGUgKCF0
LT5kb25lKSB7Cj4gIAkJKmZvcmNld2FrZV9tdCA9IGJpdCA8PCAxNiB8IGJpdDsKPiAtCQlpZ3Rf
YXNzZXJ0KCpmb3JjZXdha2VfbXQgJiBiaXQpOwo+ICsJCWlmIChpZ3Rfd2FpdCgqZm9yY2V3YWtl
X210ICYgYml0LCA1MCwgMSkpCj4gKwkJCXJldHVybiAodm9pZCAqKWFjcXVpcmVfZXJyb3I7Cj4g
Kwo+ICAJCSpmb3JjZXdha2VfbXQgPSBiaXQgPDwgMTY7Cj4gLQkJaWd0X2Fzc2VydCgoKmZvcmNl
d2FrZV9tdCAmIGJpdCkgPT0gMCk7Cj4gKwkJaWd0X2Fzc2VydChpZ3Rfd2FpdCgoKmZvcmNld2Fr
ZV9tdCAmIGJpdCkgPT0gMCwgNTAsIDEpID09IDApOwo+ICsJCWlmIChpZ3Rfd2FpdCgoKmZvcmNl
d2FrZV9tdCAmIGJpdCkgPT0gMCwgNTAsIDEpKQo+ICsJCQlyZXR1cm4gKHZvaWQgKilyZWxlYXNl
X2Vycm9yOwo+ICAJfQo+ICAKPiAgCXJldHVybiBOVUxMOwo+IEBAIC0xMjQsMTAgKzEzMywxMiBA
QCBzdGF0aWMgdm9pZCAqdGhyZWFkKHZvaWQgKmFyZykKPiAgaWd0X3NpbXBsZV9tYWluCj4gIHsK
PiAgCXN0cnVjdCB0aHJlYWQgdFsxNl07Cj4gKwlib29sIHN1Y2Nlc3MgPSB0cnVlOwo+ICAJaW50
IGk7Cj4gIAo+ICAJdFswXS5mZCA9IGRybV9vcGVuX2RyaXZlcihEUklWRVJfSU5URUwpOwo+IC0J
dFswXS5tbWlvID0gaWdmeF9nZXRfbW1pbygpOwo+ICsJdFswXS5tbWlvID0gaWdmeF9nZXRfZm9y
Y2V3YWtlX210KCk7Cj4gKwl0WzBdLmRvbmUgPSBmYWxzZTsKPiAgCj4gIAlmb3IgKGkgPSAyOyBp
IDwgMTY7IGkrKykgewo+ICAJCXRbaV0gPSB0WzBdOwo+IEBAIC0xMzcsNyArMTQ4LDcgQEAgaWd0
X3NpbXBsZV9tYWluCj4gIAo+ICAJc2xlZXAoMik7Cj4gIAo+IC0JZm9yIChpID0gMDsgaSA8IDEw
MDA7IGkrKykgewo+ICsJaWd0X3VudGlsX3RpbWVvdXQoMikgewo+ICAJCXVpbnQzMl90ICpwOwo+
ICAJCXN0cnVjdCBkcm1faTkxNV9nZW1fZXhlY2J1ZmZlcjIgZXhlY2J1ZjsKPiAgCQlzdHJ1Y3Qg
ZHJtX2k5MTVfZ2VtX2V4ZWNfb2JqZWN0MiBleGVjWzJdOwo+IEBAIC0xOTIsMTMgKzIwMywzNyBA
QCBpZ3Rfc2ltcGxlX21haW4KPiAgCQlwID0gZ2VtX21tYXBfX2d0dCh0WzBdLmZkLCBleGVjWzBd
LmhhbmRsZSwgNDA5NiwgUFJPVF9SRUFEKTsKPiAgCj4gIAkJaWd0X2luZm8oIlslZF09eyAlMDh4
ICUwOHggfVxuIiwgaSwgcFswXSwgcFsxXSk7Cj4gLQkJaWd0X2Fzc2VydChwWzBdICYgMik7Cj4g
LQkJaWd0X2Fzc2VydCgocFsxXSAmIDIpID09IDApOwo+ICsJCWlmICgocFswXSAmIDIpID09IDAp
IHsKPiArCQkJaWd0X3dhcm4oIkZhaWxlZCB0byBhY3F1aXJlIGZvcmNld2FrZSBCSVQoMSkgZnJv
bSBiYXRjaFxuIik7Cj4gKwkJCXN1Y2Nlc3MgPSBmYWxzZTsKPiArCQl9Cj4gKwkJaWYgKChwWzFd
ICYgMikpIHsKPiArCQkJaWd0X3dhcm4oIkZhaWxlZCB0byByZWxlYXNlIGZvcmNld2FrZSBCSVQo
MSkgZnJvbSBiYXRjaFxuIik7Cj4gKwkJCXN1Y2Nlc3MgPSBmYWxzZTsKPiArCQl9Cj4gIAo+ICAJ
CW11bm1hcChwLCA0MDk2KTsKPiAgCQlnZW1fY2xvc2UodFswXS5mZCwgZXhlY1swXS5oYW5kbGUp
Owo+ICAJCWdlbV9jbG9zZSh0WzBdLmZkLCBleGVjWzFdLmhhbmRsZSk7Cj4gKwkJaWYgKCFzdWNj
ZXNzKQo+ICsJCQlicmVhazsKPiAgCj4gIAkJdXNsZWVwKDEwMDApOwo+ICAJfQo+ICsKPiArCWZv
ciAoaSA9IDI7IGkgPCAxNjsgaSsrKSB7Cj4gKwkJdm9pZCAqcmVzdWx0Owo+ICsKPiArCQl0W2ld
LmRvbmUgPSB0cnVlOwo+ICsJCXB0aHJlYWRfam9pbih0W2ldLnRocmVhZCwgJnJlc3VsdCk7Cj4g
KwkJaWYgKHJlc3VsdCkgewo+ICsJCQlpZ3Rfd2FybigiVGhyZWFkIEJJVCglZCkgZmFpbGVkIHRv
ICVzIGZvcmNld2FrZVxuIiwgaSwgKGNoYXIgKilyZXN1bHQpOwo+ICsJCQlzdWNjZXNzID0gZmFs
c2U7Cj4gKwkJfQo+ICsJfQo+ICsKPiArCS8qIEFuZCBjbGVhciBhbGwgZm9yY2V3YWtlIGJpdHMg
YmVmb3JlIGRpc2FwcGVhcmluZyAqLwo+ICsJKnRbMF0ubW1pbyA9IDB4ZmZmZSA8PCAxNjsKPiAr
Cj4gKwlpZ3RfYXNzZXJ0KHN1Y2Nlc3MpOwo+ICB9Cj4gLS0gCj4gMi4xNi4yCj4gCj4gX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFp
bGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUg
U3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz
a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p
bnRlbC1nZngK