From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v2 2/3] lib: Parse plane IN_FORMATS blobifiers into a nicer form
Date: Tue, 13 Mar 2018 23:19:14 +0200 [thread overview]
Message-ID: <20180313211914.GC5453@intel.com> (raw)
In-Reply-To: <152097459933.515.1890704959553501946@mail.alporthouse.com>
On Tue, Mar 13, 2018 at 08:56:39PM +0000, Chris Wilson wrote:
> Quoting Ville Syrjala (2018-03-13 18:30:13)
> > + for (int i = 0; i < blob_data->count_modifiers; i++) {
> > + for (int j = 0; j < 64; j++) {
> > + const struct drm_format_modifier *modifiers =
> > + modifiers_ptr(blob_data);
> > + const uint32_t *formats = formats_ptr(blob_data);
> > +
> > + if (!(modifiers[i].formats & (1ULL << j)))
> > + continue;
> > +
> > + plane->formats[idx] = formats[modifiers[i].offset + j];
>
> So far everything has been byte offset, but for drm_format_modifier you
> now switch to an index offset. In drm_plane.c, I only found
> drm_format_modifier.offset = 0 and no examples of a non-zero offset to
> check against.
>
> I presume you know what you are doing. :)
Possibly. IIRC the offset is was just supposed to be n*64 to index more
than 64 formats. But of course it's all very much theoretical until a
plane exposes that many formats.
>
> Otherwise the code looks consistent with itself and drm_plane.c
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
--
Ville Syrjälä
Intel OTC
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-03-13 21:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 20:42 [igt-dev] [PATCH i-g-t 1/3] lib: Add igt_hweight{32,64} Ville Syrjala
2018-03-12 20:42 ` [igt-dev] [PATCH i-g-t 2/3] lib: Parse plane IN_FORMATS blobifiers into a nicer form Ville Syrjala
2018-03-13 18:30 ` [igt-dev] [PATCH i-g-t v2 " Ville Syrjala
2018-03-13 20:56 ` Chris Wilson
2018-03-13 21:19 ` Ville Syrjälä [this message]
2018-03-12 20:42 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_addfb_basic: Check that addfb2 accepts/rejects the expected formats Ville Syrjala
2018-03-13 0:14 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib: Add igt_hweight{32,64} Patchwork
2018-03-13 0:21 ` [igt-dev] [PATCH i-g-t 1/3] " Chris Wilson
2018-03-13 5:40 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/3] " Patchwork
2018-03-13 18:29 ` [igt-dev] [PATCH i-g-t v2 1/3] lib: Add igt_hweight() Ville Syrjala
2018-03-13 20:49 ` Chris Wilson
2018-03-13 19:16 ` [igt-dev] ✗ Fi.CI.BAT: warning for series starting with [i-g-t,v2,1/3] lib: Add igt_hweight() (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313211914.GC5453@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox