From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 289B56E0EA for ; Wed, 14 Mar 2018 14:43:53 +0000 (UTC) Date: Wed, 14 Mar 2018 16:43:19 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Message-ID: <20180314144319.GE5453@intel.com> References: <20180314112021.60224-1-maarten.lankhorst@linux.intel.com> <20180314112021.60224-2-maarten.lankhorst@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180314112021.60224-2-maarten.lankhorst@linux.intel.com> Subject: Re: [igt-dev] [PATCH i-g-t 1/5] lib/igt_kms: Add functions to get only a single output for a pipe. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maarten Lankhorst Cc: igt-dev@lists.freedesktop.org List-ID: T24gV2VkLCBNYXIgMTQsIDIwMTggYXQgMTI6MjA6MTdQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gaWd0X2dldF9zaW5nbGVfb3V0cHV0X2Zvcl9waXBlKCkgd2lsbCBnaXZlIGEg dmFsaWQgb3V0cHV0IGZvciBhIHBpcGUsCj4gZm9yX2VhY2hfcGlwZV93aXRoX3NpbmdsZV9vdXRw dXQgd2lsbCBpdGVyYXRlIG92ZXIgYWxsIHBpcGVzLCBhbmQKPiB3aWxsIGJlIGNhbGxlZCBmb3Ig ZWFjaCBwaXBlIHdpdGggYW4gb3V0cHV0IG9uY2UuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFhcnRl biBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAg bGliL2lndF9rbXMuYyB8IDkzICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrCj4gIGxpYi9pZ3Rfa21zLmggfCAyNiArKysrKysrKysrKysr KysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDExOSBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdp dCBhL2xpYi9pZ3Rfa21zLmMgYi9saWIvaWd0X2ttcy5jCj4gaW5kZXggNmJhYzRkMWZhZTUwLi4x MzEzZWYxMmViYzUgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9rbXMuYwo+ICsrKyBiL2xpYi9pZ3Rf a21zLmMKPiBAQCAtMjE5NSw2ICsyMTk1LDk5IEBAIGlndF9wbGFuZV90ICppZ3RfcGlwZV9nZXRf cGxhbmVfdHlwZShpZ3RfcGlwZV90ICpwaXBlLCBpbnQgcGxhbmVfdHlwZSkKPiAgCXJldHVybiAm cGlwZS0+cGxhbmVzW3BsYW5lX2lkeF07Cj4gIH0KPiAgCj4gK3N0YXRpYyBib29sIG91dHB1dF9p c19pbnRlcm5hbF9wYW5lbChpZ3Rfb3V0cHV0X3QgKm91dHB1dCkKPiArewo+ICsJc3dpdGNoIChv dXRwdXQtPmNvbmZpZy5jb25uZWN0b3ItPmNvbm5lY3Rvcl90eXBlKSB7Cj4gKwljYXNlIERSTV9N T0RFX0NPTk5FQ1RPUl9MVkRTOgo+ICsJY2FzZSBEUk1fTU9ERV9DT05ORUNUT1JfZURQOgo+ICsJ Y2FzZSBEUk1fTU9ERV9DT05ORUNUT1JfRFNJOgo+ICsJY2FzZSBEUk1fTU9ERV9DT05ORUNUT1Jf RFBJOgo+ICsJCXJldHVybiB0cnVlOwo+ICsJZGVmYXVsdDoKPiArCQlyZXR1cm4gZmFsc2U7Cj4g Kwl9Cj4gK30KPiArCj4gK2lndF9vdXRwdXRfdCAqKl9faWd0X3BpcGVfcG9wdWxhdGVfb3V0cHV0 cyhpZ3RfZGlzcGxheV90ICpkaXNwbGF5LCBpZ3Rfb3V0cHV0X3QgKipjaG9zZW5fb3V0cHV0cykK PiArewo+ICsJdW5zaWduZWQgZnVsbF9waXBlX21hc2sgPSAoMSA8PCAoZGlzcGxheS0+bl9waXBl cykpIC0gMSwgYXNzaWduZWRfcGlwZXMgPSAwOwo+ICsJaWd0X291dHB1dF90ICpvdXRwdXQ7Cj4g KwlpbnQgaSwgajsKPiArCj4gKwltZW1zZXQoY2hvc2VuX291dHB1dHMsIDAsIHNpemVvZigqY2hv c2VuX291dHB1dHMpICogZGlzcGxheS0+bl9waXBlcyk7Cj4gKwo+ICsJLyoKPiArCSAqIFRyeSB0 byBhc3NpZ24gYWxsIG91dHB1dHMgdG8gdGhlIGZpcnN0IGF2YWlsYWJsZSBDUlRDIGZvcgo+ICsJ ICogaXQsIHN0YXJ0IHdpdGggdGhlIG91dHB1dHMgcmVzdHJpY3RlZCB0byAxIHBpcGUsIHRoZW4g aW5jcmVhc2UKPiArCSAqIG51bWJlciBvZiBwaXBlcyB1bnRpbCB3ZSBhc3NpZ24gY29ubmVjdG9y cyB0byBhbGwgcGlwZXMuCj4gKwkgKi8KPiArCWZvciAoaSA9IDA7IGkgPD0gZGlzcGxheS0+bl9w aXBlczsgaSsrKSB7Cj4gKwkJZm9yX2VhY2hfY29ubmVjdGVkX291dHB1dChkaXNwbGF5LCBvdXRw dXQpIHsKPiArCQkJdWludDMyX3QgcGlwZV9tYXNrID0gb3V0cHV0LT5jb25maWcudmFsaWRfY3J0 Y19pZHhfbWFzayAmIGZ1bGxfcGlwZV9tYXNrOwo+ICsJCQlib29sIGZvdW5kID0gZmFsc2U7Cj4g Kwo+ICsJCQlpZiAob3V0cHV0X2lzX2ludGVybmFsX3BhbmVsKG91dHB1dCkpIHsKPiArCQkJCS8q Cj4gKwkJCQkgKiBJbnRlcm5hbCBwYW5lbCBzaG91bGQgYmUgYXNzaWduZWQgdG8gcGlwZSBBCj4g KwkJCQkgKiBpZiBwb3NzaWJsZSwgc28gbWFrZSBzdXJlIHRoZXkncmUgZW51bWVyYXRlZAo+ICsJ CQkJICogZmlyc3QuCj4gKwkJCQkgKi8KPiArCj4gKwkJCQlpZiAoaSkKPiArCQkJCQljb250aW51 ZTsKPiArCQkJfSBlbHNlIGlmIChfX2J1aWx0aW5fcG9wY291bnQocGlwZV9tYXNrKSAhPSBpKQo+ ICsJCQkJY29udGludWU7Cj4gKwo+ICsJCQlmb3IgKGogPSAwOyBqIDwgZGlzcGxheS0+bl9waXBl czsgaisrKSB7Cj4gKwkJCQlib29sIHBpcGVfYXNzaWduZWQgPSBhc3NpZ25lZF9waXBlcyAmICgx IDw8IGopOwo+ICsKPiArCQkJCWlmIChwaXBlX2Fzc2lnbmVkIHx8ICEocGlwZV9tYXNrICYgKDEg PDwgaikpKQo+ICsJCQkJCWNvbnRpbnVlOwo+ICsKPiArCQkJCWlmICghZm91bmQpIHsKPiArCQkJ CQkvKiBXZSBmb3VuZCBhbiB1bmFzc2lnbmVkIHBpcGUsIHVzZSBpdCEgKi8KPiArCQkJCQlmb3Vu ZCA9IHRydWU7Cj4gKwkJCQkJYXNzaWduZWRfcGlwZXMgfD0gMSA8PCBqOwo+ICsJCQkJCWNob3Nl bl9vdXRwdXRzW2pdID0gb3V0cHV0Owo+ICsJCQkJfSBlbHNlIGlmICghY2hvc2VuX291dHB1dHNb al0gfHwKPiArCQkJCQkgICAvKgo+ICsJCQkJCSAgICAqIE92ZXJ3cml0ZSBpbnRlcm5hbCBwYW5l bCBpZiBub3QgYXNzaWduZWQsCj4gKwkJCQkJICAgICogZXh0ZXJuYWwgb3V0cHV0cyBhcmUgZmFz dGVyIHRvIGRvIG1vZGVzZXRzCj4gKwkJCQkJICAgICovCj4gKwkJCQkJICAgb3V0cHV0X2lzX2lu dGVybmFsX3BhbmVsKGNob3Nlbl9vdXRwdXRzW2pdKSkKPiArCQkJCQljaG9zZW5fb3V0cHV0c1tq XSA9IG91dHB1dDsKPiArCQkJfQoKSSB0aGluayB0aGlzIG1pZ2h0IG5vdCBiZSBmaW5kIHRoZSBv cHRpbWFsIHNvbHV0aW9uIGluIHNvbWUgY2FzZXMgc2luY2UKaXQgYWx3YXlzIHBpY2tzIHRoZSBm aXJzdCBhdmFpbGFibGUgcGlwZS4gU28gaW4gdGhlb3J5IHdlIG1pZ2h0IG5vdCBwaWNrCmFzIG1h bnkgb3V0cHV0cyB0aGF0IGFyZSBhY3R1YWxseSBhdmFpbGFibGUuIEJ1dCBJIHN1cHBvc2Ugc3Vj aApjb25maWd1cmF0aW9ucyBzaG91bGRuJ3QgYmUgY29tbW9pbiBzbyBwcm9iYWJseSB3aWxsIGRv IGZpbmUgZm9yIG1vc3QKY2FzZXMuCgo+ICsKPiArCQkJaWYgKCFmb3VuZCkKPiArCQkJCWlndF93 YXJuKCJPdXRwdXQgJXMgY291bGQgbm90IGJlIGFzc2lnbmVkIHRvIGEgcGlwZVxuIiwKPiArCQkJ CQkgaWd0X291dHB1dF9uYW1lKG91dHB1dCkpOwo+ICsJCX0KPiArCX0KPiArCj4gKwlyZXR1cm4g Y2hvc2VuX291dHB1dHM7Cj4gK30KPiArCj4gKy8qKgo+ICsgKiBpZ3RfZ2V0X3NpbmdsZV9vdXRw dXRfZm9yX3BpcGU6Cj4gKyAqIEBkaXNwbGF5OiBhIHBvaW50ZXIgdG8gYW4gI2lndF9kaXNwbGF5 X3Qgc3RydWN0dXJlCj4gKyAqIEBwaXBlOiBUaGUgcGlwZSBmb3Igd2hpY2ggYW4gI2lndF9vdXRw dXRfdCBtdXN0IGJlIHJldHVybmVkLgo+ICsgKgo+ICsgKiBHZXQgYSBjb21wYXRpYmxlIG91dHB1 dCBmb3IgYSBwaXBlLgo+ICsgKgo+ICsgKiBSZXR1cm5zOiBBIGNvbXBhdGlibGUgb3V0cHV0IGZv ciBhIGdpdmVuIHBpcGUsIG9yIE5VTEwuCj4gKyAqLwo+ICtpZ3Rfb3V0cHV0X3QgKmlndF9nZXRf c2luZ2xlX291dHB1dF9mb3JfcGlwZShpZ3RfZGlzcGxheV90ICpkaXNwbGF5LCBlbnVtIHBpcGUg cGlwZSkKPiArewo+ICsJaWd0X291dHB1dF90ICpjaG9zZW5fb3V0cHV0c1tkaXNwbGF5LT5uX3Bp cGVzXTsKPiArCj4gKwlpZ3RfYXNzZXJ0KHBpcGUgIT0gUElQRV9OT05FKTsKPiArCWlndF9yZXF1 aXJlKHBpcGUgPCBkaXNwbGF5LT5uX3BpcGVzKTsKPiArCj4gKwlfX2lndF9waXBlX3BvcHVsYXRl X291dHB1dHMoZGlzcGxheSwgY2hvc2VuX291dHB1dHMpOwo+ICsKPiArCXJldHVybiBjaG9zZW5f b3V0cHV0c1twaXBlXTsKPiArfQo+ICsKPiAgc3RhdGljIGlndF9vdXRwdXRfdCAqaWd0X3BpcGVf Z2V0X291dHB1dChpZ3RfcGlwZV90ICpwaXBlKQo+ICB7Cj4gIAlpZ3RfZGlzcGxheV90ICpkaXNw bGF5ID0gcGlwZS0+ZGlzcGxheTsKPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9rbXMuaCBiL2xpYi9p Z3Rfa21zLmgKPiBpbmRleCAxYzQ2MTg2ZThhOWQuLjE3OGI2MzZjMTQzZSAxMDA2NDQKPiAtLS0g YS9saWIvaWd0X2ttcy5oCj4gKysrIGIvbGliL2lndF9rbXMuaAo+IEBAIC0zODAsNyArMzgwLDkg QEAgaWd0X3BsYW5lX3QgKmlndF9vdXRwdXRfZ2V0X3BsYW5lKGlndF9vdXRwdXRfdCAqb3V0cHV0 LCBpbnQgcGxhbmVfaWR4KTsKPiAgaWd0X3BsYW5lX3QgKmlndF9vdXRwdXRfZ2V0X3BsYW5lX3R5 cGUoaWd0X291dHB1dF90ICpvdXRwdXQsIGludCBwbGFuZV90eXBlKTsKPiAgaWd0X291dHB1dF90 ICppZ3Rfb3V0cHV0X2Zyb21fY29ubmVjdG9yKGlndF9kaXNwbGF5X3QgKmRpc3BsYXksCj4gICAg ICBkcm1Nb2RlQ29ubmVjdG9yICpjb25uZWN0b3IpOwo+ICsKPiAgaWd0X3BsYW5lX3QgKmlndF9w aXBlX2dldF9wbGFuZV90eXBlKGlndF9waXBlX3QgKnBpcGUsIGludCBwbGFuZV90eXBlKTsKPiAr aWd0X291dHB1dF90ICppZ3RfZ2V0X3NpbmdsZV9vdXRwdXRfZm9yX3BpcGUoaWd0X2Rpc3BsYXlf dCAqZGlzcGxheSwgZW51bSBwaXBlIHBpcGUpOwo+ICAKPiAgdm9pZCBpZ3RfcGlwZV9yZXF1ZXN0 X291dF9mZW5jZShpZ3RfcGlwZV90ICpwaXBlKTsKPiAgCj4gQEAgLTQ2OCw2ICs0NzAsMTAgQEAg c3RhdGljIGlubGluZSBib29sIGlndF9vdXRwdXRfaXNfY29ubmVjdGVkKGlndF9vdXRwdXRfdCAq b3V0cHV0KQo+ICAgKgo+ICAgKiBUaGlzIGZvciBsb29wIGlzIGNhbGxlZCBvdmVyIGFsbCBjb25u ZWN0ZWQgb3V0cHV0cy4gVGhpcyBmdW5jdGlvbgo+ICAgKiB3aWxsIHRyeSBldmVyeSBjb21iaW5h dGlvbiBvZiBAcGlwZSBhbmQgQG91dHB1dC4KPiArICoKPiArICogSWYgeW91IG9ubHkgbmVlZCB0 byB0ZXN0IGEgc2luZ2xlIG91dHB1dCBmb3IgZWFjaCBwaXBlLCB1c2UKPiArICogZm9yX2VhY2hf cGlwZV93aXRoX3NpbmdsZV9vdXRwdXQoKSwgaWYgeW91IG9ubHkgbmVlZCBhbgo+ICsgKiBvdXRw dXQgZm9yIGEgc2luZ2xlIHBpcGUsIHVzZSBpZ3RfZ2V0X3NpbmdsZV9vdXRwdXRfZm9yX3BpcGUo KS4KPiAgICovCj4gICNkZWZpbmUgZm9yX2VhY2hfcGlwZV93aXRoX3ZhbGlkX291dHB1dChkaXNw bGF5LCBwaXBlLCBvdXRwdXQpIFwKPiAgCWZvciAoaW50IGNvbl9fID0gKHBpcGUpID0gMDsgXAo+ IEBAIC00NzYsNiArNDgyLDI2IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBpZ3Rfb3V0cHV0X2lzX2Nv bm5lY3RlZChpZ3Rfb3V0cHV0X3QgKm91dHB1dCkKPiAgCQlmb3JfZWFjaF9pZiAoKCgob3V0cHV0 KSA9ICYoZGlzcGxheSktPm91dHB1dHNbY29uX19dKSwgXAo+ICAJCQkgICAgIGlndF9waXBlX2Nv bm5lY3Rvcl92YWxpZCgocGlwZSksIChvdXRwdXQpKSkpCj4gIAo+ICtpZ3Rfb3V0cHV0X3QgKipf X2lndF9waXBlX3BvcHVsYXRlX291dHB1dHMoaWd0X2Rpc3BsYXlfdCAqZGlzcGxheSwKPiArCQkJ CQkgICBpZ3Rfb3V0cHV0X3QgKipjaG9zZW5fb3V0cHV0cyk7Cj4gKwo+ICsvKioKPiArICogZm9y X2VhY2hfcGlwZV93aXRoX3NpbmdsZV9vdXRwdXQ6Cj4gKyAqIEBkaXNwbGF5OiBhIHBvaW50ZXIg dG8gYW4gI2lndF9kaXNwbGF5X3Qgc3RydWN0dXJlCj4gKyAqIEBwaXBlOiBUaGUgcGlwZSBmb3Ig d2hpY2ggdGhpcyBAcGlwZSAvIEBvdXRwdXQgY29tYmluYXRpb24gaXMgdmFsaWQuCj4gKyAqIEBv dXRwdXQ6IFRoZSBvdXRwdXQgZm9yIHdoaWNoIHRoaXMgQHBpcGUgLyBAb3V0cHV0IGNvbWJpbmF0 aW9uIGlzIHZhbGlkLgo+ICsgKgo+ICsgKiBUaGlzIGxvb3AgaXMgY2FsbGVkIG92ZXIgYWxsIHBp cGVzLCBhbmQgd2lsbCB0cnkgdG8gZmluZCBhIGNvbXBhdGlibGUgb3V0cHV0Cj4gKyAqIGZvciBl YWNoIHBpcGUuIFVubGlrZSBmb3JfZWFjaF9waXBlX3dpdGhfdmFsaWRfb3V0cHV0KCksIHRoaXMg ZnVuY3Rpb24gd2lsbAo+ICsgKiBiZSBjYWxsZWQgYXQgbW9zdCBvbmNlIGZvciBlYWNoIHBpcGUu Cj4gKyAqLwo+ICsjZGVmaW5lIGZvcl9lYWNoX3BpcGVfd2l0aF9zaW5nbGVfb3V0cHV0KGRpc3Bs YXksIHBpcGUsIG91dHB1dCkgXAo+ICsJZm9yIChpZ3Rfb3V0cHV0X3QgKl9fb3V0cHV0c1soZGlz cGxheSktPm5fcGlwZXNdLCBcCj4gKwkgICAgICoqX19vdXRwdXQgPSBfX2lndF9waXBlX3BvcHVs YXRlX291dHB1dHMoKGRpc3BsYXkpLCBfX291dHB1dHMpOyBcCj4gKwkgICAgIF9fb3V0cHV0IDwg Jl9fb3V0cHV0c1soZGlzcGxheSktPm5fcGlwZXNdOyBfX291dHB1dCsrKSBcCj4gKwkJZm9yX2Vh Y2hfaWYgKCpfX291dHB1dCAmJiBcCj4gKwkJCSAgICAgKChwaXBlKSA9IChfX291dHB1dHMgLSBf X291dHB1dCksIChvdXRwdXQpID0gKl9fb3V0cHV0LCAxKSkKClRoYXQgcmVxdWlyZXMgcXVpdGUg YSBzb3BoaXN0aWNhdGVkIHBhcnNlciA6KSBCdXQgaXQgZG9lcyBsb29rIGNvcnJlY3QgdG8gbWUu CgpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4KCj4gKwo+ICAvKioKPiAgICogZm9yX2VhY2hfdmFsaWRfb3V0cHV0X29uX3BpcGU6Cj4g ICAqIEBkaXNwbGF5OiBhIHBvaW50ZXIgdG8gYW4gI2lndF9kaXNwbGF5X3Qgc3RydWN0dXJlCj4g LS0gCj4gMi4xNi4yCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KPiBpZ3QtZGV2IG1haWxpbmcgbGlzdAo+IGlndC1kZXZAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p Z3QtZGV2CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2lndC1kZXYK