Re: [igt-dev] [PATCH i-g-t 2/5] tests/kms_rmfb: Use for_each_pipe_with_single_output.

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Mar 14, 2018 at 12:20:18PM +0100, Maarten Lankhorst wrote:
> A single output on every pipe will do for testing.
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  tests/kms_rmfb.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/kms_rmfb.c b/tests/kms_rmfb.c
> index c97adceea761..f3461cc919e9 100644
> --- a/tests/kms_rmfb.c
> +++ b/tests/kms_rmfb.c
> @@ -129,15 +129,10 @@ static void
>  run_rmfb_test(struct rmfb_data *data, bool reopen)
>  {
>  	igt_output_t *output;
> -	int valid_tests = 0;
>  	enum pipe pipe;
>  
> -	for_each_pipe_with_valid_output(&data->display, pipe, output) {
> +	for_each_pipe_with_single_output(&data->display, pipe, output)
>  		test_rmfb(data, output, pipe, reopen);
> -		valid_tests = 1;
> -	}
> -
> -	igt_require_f(valid_tests, "no valid crtc/connector combinations found\n");
>  }
>  
>  igt_main
> @@ -152,6 +147,7 @@ igt_main
>  		kmstest_set_vt_graphics_mode();
>  
>  		igt_display_init(&data.display, data.drm_fd);
> +		igt_display_require_output(&data.display);
>  	}
>  
>  	igt_subtest_f("rmfb-ioctl")
> -- 
> 2.16.2
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev