From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_kms: Fix enum type in igt_pipe_has_prop.
Date: Thu, 15 Mar 2018 14:51:04 +0200 [thread overview]
Message-ID: <20180315125104.GP5453@intel.com> (raw)
In-Reply-To: <20180315110104.72199-1-maarten.lankhorst@linux.intel.com>
On Thu, Mar 15, 2018 at 12:01:04PM +0100, Maarten Lankhorst wrote:
> Found when compiling igt with clang:
> [284/819] Compiling C object 'tests/kms_crtc_background_color@exe/kms_crtc_background_color.c.o'.
> ../tests/kms_crtc_background_color.c:140:48: warning: implicit conversion from enumeration type
> 'enum igt_atomic_crtc_properties' to different enumeration type 'enum igt_atomic_connector_properties' [-Wenum-conversion]
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> lib/igt_kms.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index 1c46186e8a9d..672930e9849f 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -615,7 +615,7 @@ igt_pipe_get_prop(igt_display_t *display, enum pipe pipe,
> */
> static inline bool
> igt_pipe_has_prop(igt_display_t *display, enum pipe pipe,
> - enum igt_atomic_connector_properties prop)
> + enum igt_atomic_crtc_properties prop)
> {
> return display->pipes[pipe].props[prop];
> }
> --
> 2.16.2
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel OTC
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-03-15 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 11:01 [igt-dev] [PATCH i-g-t] lib/igt_kms: Fix enum type in igt_pipe_has_prop Maarten Lankhorst
2018-03-15 12:43 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-03-15 12:51 ` Ville Syrjälä [this message]
2018-03-15 14:43 ` [igt-dev] ✗ Fi.CI.IGT: warning " Patchwork
2018-03-15 16:31 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315125104.GP5453@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox