Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Vidya Srinivas <vidya.srinivas@intel.com>
Cc: igt-dev@lists.freedesktop.org, sunil.kamath@intel.com,
	ville.syrjala@intel.com
Subject: Re: [igt-dev] [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: fb height to be multiplier of 4 for YUV 420 planar
Date: Fri, 16 Mar 2018 16:30:33 +0200	[thread overview]
Message-ID: <20180316143033.GI5453@intel.com> (raw)
In-Reply-To: <1521206427-28202-1-git-send-email-vidya.srinivas@intel.com>

On Fri, Mar 16, 2018 at 06:50:27PM +0530, Vidya Srinivas wrote:
> For Gen9, GLK, CNL, GLV: Display WA 1106:
> Display corruption/color shift observed when using NV12 with
> 270 rotation or 90 rotation + horizontal flip.
> WA: NV12 with 270 rotation or 90 rotation + horizontal flip requires
> the programmed plane height to be a multiple of 4.
> Patch changes the NV12 buffer to 20x20 to maintain both
> fb > min fb and also multiplier of 4
> 
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_scaling.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 36fcfc0..b94d785 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -132,7 +132,7 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
>  	/* create buffer in the range of  min and max source side limit.*/
>  	width = height = 9;
>  	if (pixel_format == DRM_FORMAT_NV12)
> -		width = height = 17;
> +		width = height = 20;

Why 20 and not 16? I thought 16 was the limit?

>  	igt_create_color_fb(display->drm_fd, width, height,
>  		       pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
>  	igt_plane_set_fb(plane, &d->fb[0]);
> -- 
> 2.7.4
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2018-03-16 14:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-16 13:20 [igt-dev] [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: fb height to be multiplier of 4 for YUV 420 planar Vidya Srinivas
2018-03-16 14:11 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-03-16 14:30 ` Ville Syrjälä [this message]
2018-03-17  9:15   ` [igt-dev] [PATCH i-g-t] [i-g-t] " Srinivas, Vidya
2018-03-19 14:04     ` Ville Syrjälä
2018-03-20 10:02       ` Srinivas, Vidya
2018-03-21 15:04         ` Maarten Lankhorst
2018-03-23  4:21           ` Srinivas, Vidya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180316143033.GI5453@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=sunil.kamath@intel.com \
    --cc=vidya.srinivas@intel.com \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox