From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] lib/igt_kms: Improve connector probing in igt_display_init(), v2.
Date: Wed, 28 Mar 2018 10:37:36 +0200 [thread overview]
Message-ID: <20180328083736.10249-1-maarten.lankhorst@linux.intel.com> (raw)
In-Reply-To: <20180327132840.GI16453@ahiler-desk1.ger.corp.intel.com>
Only do a full probe when the initial connector status is unknown, and
otherwise skip it. This should speed up kms tests ever so slightly.
Also set pipe to PIPE_NONE for igt_output_refresh(), to make the
connector info slightly more accurate.
Changes since v1:
- Instead of a force_reprobe tristate, only force reprobe from
igt_display_init() when an unknown connection is found.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
lib/igt_kms.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 2b81cabb05d8..19d650a8dcf8 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1955,11 +1955,17 @@ void igt_display_init(igt_display_t *display, int drm_fd)
* We don't assign each output a pipe unless
* a pipe is set with igt_output_set_pipe().
*/
- output->force_reprobe = true;
+ output->pending_pipe = PIPE_NONE;
output->id = resources->connectors[i];
output->display = display;
igt_output_refresh(output);
+
+ if (output->config.connector &&
+ output->config.connector->connection == DRM_MODE_UNKNOWNCONNECTION) {
+ output->force_reprobe = true;
+ igt_output_refresh(output);
+ }
}
drmModeFreePlaneResources(plane_resources);
--
2.16.3
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-03-28 8:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 10:40 [igt-dev] [PATCH i-g-t] lib/igt_kms: Improve connector probing in igt_display_init() Maarten Lankhorst
2018-03-26 11:06 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2018-03-26 11:22 ` [igt-dev] [PATCH i-g-t] " Maarten Lankhorst
2018-03-27 13:28 ` Arkadiusz Hiler
2018-03-28 8:37 ` Maarten Lankhorst [this message]
2018-03-28 9:20 ` [igt-dev] [PATCH i-g-t] lib/igt_kms: Improve connector probing in igt_display_init(), v2 Arkadiusz Hiler
2018-03-28 11:50 ` Maarten Lankhorst
2018-03-26 11:41 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_kms: Improve connector probing in igt_display_init() (rev2) Patchwork
2018-03-26 13:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-03-28 9:04 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_kms: Improve connector probing in igt_display_init() (rev3) Patchwork
2018-03-28 13:58 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328083736.10249-1-maarten.lankhorst@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox