[igt-dev] [PATCH i-g-t 0/2] tests/kms_frontbuffer_tracking: Rework to prevent modesets!

[igt-dev] [PATCH i-g-t 0/2] tests/kms_frontbuffer_tracking: Rework to prevent modesets!

[Maarten Lankhorst]

Now that FBC can be toggled at runtime, I wanted to make sure that we try to prevent
modesets as much as we can.
Patch 1 kind of needs kernel support to work.

https://patchwork.freedesktop.org/series/39955/

Maarten Lankhorst (2):
  tests/kms_frontbuffer_tracking: Add support for toggling edp psr
    through debugfs, v2.
  tests/kms_frontbuffer_tracking: Remove redundant modesets during
    subtest start, v3.

 tests/kms_frontbuffer_tracking.c | 93 +++++++++++++++++++++++++++++++++-------
 1 file changed, 78 insertions(+), 15 deletions(-)

-- 
2.16.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 1/2] tests/kms_frontbuffer_tracking: Add support for toggling edp psr through debugfs, v2.

[Maarten Lankhorst]

It's harmful to write to enable_psr at runtime, and the patch that allows
us to change i915_edp_psr_status with the panel running will require us
to abandon the module parameter. Hence the userspace change needs to be
put in IGT first before we can change it at kernel time.

Toggling it to debugfs will mean we can skip a modeset when changing our
feature set.

Changes since v1:
- Rebase with the previous patches dropped.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/kms_frontbuffer_tracking.c | 36 ++++++++++++++++++++++++++++++++++--
 1 file changed, 34 insertions(+), 2 deletions(-)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index 2b85392dfa4b..5d619f211725 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -811,6 +811,38 @@ static void drrs_set(unsigned int val)
 		igt_assert_f(ret == (sizeof(buf) - 1), "debugfs_write failed");
 }
 
+static void restore_psr_debugfs(int sig)
+{
+	debugfs_write("i915_edp_psr_status", "-1");
+}
+
+static bool psr_set(unsigned int val)
+{
+	static int oldval = -1;
+	char buf[4];
+	int ret;
+
+	snprintf(buf, sizeof(buf), "%i\n", val);
+
+	ret = debugfs_write("i915_edp_psr_status", buf);
+	if (ret != -EINVAL) {
+		igt_assert(ret > 0 || val <= 0);
+
+		if (ret > 0)
+			igt_install_exit_handler(restore_psr_debugfs);
+
+		return false;
+	}
+
+	igt_set_module_param_int("enable_psr", val);
+
+	if (val == oldval)
+		return false;
+
+	oldval = val;
+	return true;
+}
+
 static bool is_drrs_high(void)
 {
 	char buf[MAX_DRRS_STATUS_BUF_LEN];
@@ -979,8 +1011,8 @@ static bool drrs_wait_until_rr_switch_to_low(void)
 
 #define fbc_enable() igt_set_module_param_int("enable_fbc", 1)
 #define fbc_disable() igt_set_module_param_int("enable_fbc", 0)
-#define psr_enable() igt_set_module_param_int("enable_psr", 1)
-#define psr_disable() igt_set_module_param_int("enable_psr", 0)
+#define psr_enable()	psr_set(1)
+#define psr_disable()	psr_set(0)
 #define drrs_enable()	drrs_set(1)
 #define drrs_disable()	drrs_set(0)
 
-- 
2.16.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 2/2] tests/kms_frontbuffer_tracking: Remove redundant modesets during subtest start, v3.

[Maarten Lankhorst]

CRC capturing enables the display, then disables it again. With
igt_display we can use igt_display_reset to restore the original state,
without committing it to the hw.

All subtests first set their own state anyway, so we can save up on
the number of commits.

Changes since v1:
- Try to avoid modesets for PSR if the kernel supports it, but otherwise force
  a modeset for the changes to take effect.
Changes since v2:
- Rebase on top of previous PSR changes.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/kms_frontbuffer_tracking.c | 57 +++++++++++++++++++++++++++++++---------
 1 file changed, 44 insertions(+), 13 deletions(-)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index 5d619f211725..454103d367c7 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -1239,14 +1239,14 @@ static void unset_all_crtcs(void)
 	igt_display_commit(&drm.display);
 }
 
-static void disable_features(const struct test_mode *t)
+static bool disable_features(const struct test_mode *t)
 {
 	if (t->feature == FEATURE_DEFAULT)
-		return;
+		return false;
 
 	fbc_disable();
-	psr_disable();
 	drrs_disable();
+	return psr_disable();
 }
 
 static void *busy_thread_func(void *data)
@@ -1339,7 +1339,7 @@ static void init_blue_crc(enum pixel_format format, bool mandatory_sink_crc)
 
 	print_crc("Blue CRC:  ", &blue_crcs[format].crc);
 
-	unset_all_crtcs();
+	igt_display_reset(&drm.display);
 
 	igt_remove_fb(drm.fd, &blue);
 
@@ -1392,7 +1392,7 @@ static void init_crcs(enum pixel_format format,
 		print_crc("", &pattern->crcs[format][r]);
 	}
 
-	unset_all_crtcs();
+	igt_display_reset(&drm.display);
 
 	for (r = 0; r < pattern->n_rects; r++)
 		igt_remove_fb(drm.fd, &tmp_fbs[r]);
@@ -1857,6 +1857,22 @@ static void enable_scnd_screen_and_wait(const struct test_mode *t)
 	do_assertions(ASSERT_NO_ACTION_CHANGE);
 }
 
+static void enable_both_screens_and_wait(const struct test_mode *t)
+{
+	fill_fb_region(&prim_mode_params.primary, COLOR_PRIM_BG);
+	fill_fb_region(&scnd_mode_params.primary, COLOR_SCND_BG);
+
+	__set_mode_for_params(&prim_mode_params);
+	__set_mode_for_params(&scnd_mode_params);
+
+	igt_display_commit2(&drm.display, drm.display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
+
+	wanted_crc = &blue_crcs[t->format].crc;
+	fbc_update_last_action();
+
+	do_assertions(ASSERT_NO_ACTION_CHANGE);
+}
+
 static void set_region_for_test(const struct test_mode *t,
 				struct fb_region *reg)
 {
@@ -1871,17 +1887,21 @@ static void set_region_for_test(const struct test_mode *t,
 	do_assertions(ASSERT_NO_ACTION_CHANGE);
 }
 
-static void enable_features_for_test(const struct test_mode *t)
+static bool enable_features_for_test(const struct test_mode *t)
 {
+	bool ret = false;
+
 	if (t->feature == FEATURE_DEFAULT)
-		return;
+		return false;
 
 	if (t->feature & FEATURE_FBC)
 		fbc_enable();
 	if (t->feature & FEATURE_PSR)
-		psr_enable();
+		ret = psr_enable();
 	if (t->feature & FEATURE_DRRS)
 		drrs_enable();
+
+	return ret;
 }
 
 static void check_test_requirements(const struct test_mode *t)
@@ -1965,28 +1985,40 @@ static void set_crtc_fbs(const struct test_mode *t)
 static void prepare_subtest_data(const struct test_mode *t,
 				 struct draw_pattern_info *pattern)
 {
+	bool need_modeset;
+
 	check_test_requirements(t);
 
 	stop_busy_thread();
 
-	disable_features(t);
+	need_modeset = disable_features(t);
 	set_crtc_fbs(t);
 
 	if (t->screen == SCREEN_OFFSCREEN)
 		fill_fb_region(&offscreen_fb, COLOR_OFFSCREEN_BG);
 
-	unset_all_crtcs();
+	igt_display_reset(&drm.display);
+	if (need_modeset)
+		igt_display_commit(&drm.display);
 
 	init_blue_crc(t->format, t->feature & FEATURE_PSR);
 	if (pattern)
 		init_crcs(t->format, pattern, t->feature & FEATURE_PSR);
 
-	enable_features_for_test(t);
+	igt_display_reset(&drm.display);
+
+	need_modeset = enable_features_for_test(t);
+	if (need_modeset)
+		igt_display_commit(&drm.display);
 }
 
 static void prepare_subtest_screens(const struct test_mode *t)
 {
-	enable_prim_screen_and_wait(t);
+	if (t->pipes == PIPE_DUAL)
+		enable_both_screens_and_wait(t);
+	else
+		enable_prim_screen_and_wait(t);
+
 	if (t->screen == SCREEN_PRIM) {
 		if (t->plane == PLANE_CUR)
 			set_region_for_test(t, &prim_mode_params.cursor);
@@ -1997,7 +2029,6 @@ static void prepare_subtest_screens(const struct test_mode *t)
 	if (t->pipes == PIPE_SINGLE)
 		return;
 
-	enable_scnd_screen_and_wait(t);
 	if (t->screen == SCREEN_SCND) {
 		if (t->plane == PLANE_CUR)
 			set_region_for_test(t, &scnd_mode_params.cursor);
-- 
2.16.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_frontbuffer_tracking: Rework to prevent modesets!

[Patchwork]

== Series Details ==

Series: tests/kms_frontbuffer_tracking: Rework to prevent modesets!
URL   : https://patchwork.freedesktop.org/series/40195/
State : failure

== Summary ==

IGT patchset tested on top of latest successful build
b09e979a67817a9b068f841bda81940b9d208850 tools/aubdump: For gen10+ support addresses up to 4GB

with latest DRM-Tip kernel build CI_DRM_3951
260af42eeff0 drm-tip: 2018y-03m-19d-17h-15m-08s UTC integration manifest

No testlist changes.

---- Possible new issues:

Test drv_module_reload:
        Subgroup basic-reload-inject:
                pass       -> INCOMPLETE (fi-elk-e7500)
Test gem_exec_suspend:
        Subgroup basic:
                pass       -> INCOMPLETE (fi-snb-2600)

---- Known issues:

Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                pass       -> INCOMPLETE (fi-snb-2520m) fdo#103713

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713

fi-bdw-5557u     total:285  pass:264  dwarn:0   dfail:0   fail:0   skip:21  time:430s
fi-bdw-gvtdvm    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:439s
fi-blb-e6850     total:285  pass:220  dwarn:1   dfail:0   fail:0   skip:64  time:382s
fi-bsw-n3050     total:285  pass:239  dwarn:0   dfail:0   fail:0   skip:46  time:535s
fi-bwr-2160      total:285  pass:180  dwarn:0   dfail:0   fail:0   skip:105 time:297s
fi-bxt-j4205     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:513s
fi-byt-j1900     total:285  pass:250  dwarn:0   dfail:0   fail:0   skip:35  time:517s
fi-byt-n2820     total:285  pass:246  dwarn:0   dfail:0   fail:0   skip:39  time:507s
fi-cfl-8700k     total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:410s
fi-cfl-s2        total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:582s
fi-cfl-u         total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:507s
fi-cnl-drrs      total:285  pass:254  dwarn:3   dfail:0   fail:0   skip:28  time:550s
fi-elk-e7500     total:284  pass:224  dwarn:1   dfail:0   fail:0   skip:58 
fi-gdg-551       total:285  pass:176  dwarn:0   dfail:0   fail:1   skip:108 time:320s
fi-glk-1         total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:537s
fi-hsw-4770      total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:402s
fi-ilk-650       total:285  pass:225  dwarn:0   dfail:0   fail:0   skip:60  time:419s
fi-ivb-3520m     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:473s
fi-ivb-3770      total:285  pass:252  dwarn:0   dfail:0   fail:0   skip:33  time:427s
fi-kbl-7500u     total:285  pass:260  dwarn:1   dfail:0   fail:0   skip:24  time:472s
fi-kbl-7567u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:464s
fi-kbl-r         total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:515s
fi-pnv-d510      total:285  pass:219  dwarn:1   dfail:0   fail:0   skip:65  time:656s
fi-skl-6260u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:438s
fi-skl-6600u     total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:529s
fi-skl-6700hq    total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:534s
fi-skl-6700k2    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:512s
fi-skl-6770hq    total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:497s
fi-skl-guc       total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:427s
fi-skl-gvtdvm    total:285  pass:262  dwarn:0   dfail:0   fail:0   skip:23  time:446s
fi-snb-2520m     total:242  pass:208  dwarn:0   dfail:0   fail:0   skip:33 
fi-snb-2600      total:107  pass:90   dwarn:0   dfail:0   fail:0   skip:16

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1160/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: Rework to prevent modesets!

[Patchwork]

== Series Details ==

Series: tests/kms_frontbuffer_tracking: Rework to prevent modesets!
URL   : https://patchwork.freedesktop.org/series/40195/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
b09e979a67817a9b068f841bda81940b9d208850 tools/aubdump: For gen10+ support addresses up to 4GB

with latest DRM-Tip kernel build CI_DRM_3954
141def2a45f4 drm-tip: 2018y-03m-19d-23h-48m-43s UTC integration manifest

No testlist changes.

---- Known issues:

Test kms_pipe_crc_basic:
        Subgroup nonblocking-crc-pipe-c-frame-sequence:
                pass       -> FAIL       (fi-cfl-s2) fdo#103481
        Subgroup suspend-read-crc-pipe-b:
                incomplete -> PASS       (fi-snb-2520m) fdo#103713

fdo#103481 https://bugs.freedesktop.org/show_bug.cgi?id=103481
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713

fi-bdw-5557u     total:285  pass:264  dwarn:0   dfail:0   fail:0   skip:21  time:434s
fi-bdw-gvtdvm    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:441s
fi-blb-e6850     total:285  pass:220  dwarn:1   dfail:0   fail:0   skip:64  time:382s
fi-bsw-n3050     total:285  pass:239  dwarn:0   dfail:0   fail:0   skip:46  time:543s
fi-bwr-2160      total:285  pass:180  dwarn:0   dfail:0   fail:0   skip:105 time:298s
fi-bxt-dsi       total:285  pass:255  dwarn:0   dfail:0   fail:0   skip:30  time:515s
fi-bxt-j4205     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:514s
fi-byt-j1900     total:285  pass:250  dwarn:0   dfail:0   fail:0   skip:35  time:527s
fi-byt-n2820     total:285  pass:246  dwarn:0   dfail:0   fail:0   skip:39  time:506s
fi-cfl-8700k     total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:411s
fi-cfl-s2        total:285  pass:258  dwarn:0   dfail:0   fail:1   skip:26  time:574s
fi-cfl-u         total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:508s
fi-cnl-drrs      total:285  pass:254  dwarn:3   dfail:0   fail:0   skip:28  time:532s
fi-elk-e7500     total:285  pass:225  dwarn:1   dfail:0   fail:0   skip:59  time:428s
fi-gdg-551       total:285  pass:176  dwarn:0   dfail:0   fail:1   skip:108 time:318s
fi-glk-1         total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:536s
fi-hsw-4770      total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:404s
fi-ilk-650       total:285  pass:225  dwarn:0   dfail:0   fail:0   skip:60  time:419s
fi-ivb-3520m     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:471s
fi-ivb-3770      total:285  pass:252  dwarn:0   dfail:0   fail:0   skip:33  time:430s
fi-kbl-7500u     total:285  pass:260  dwarn:1   dfail:0   fail:0   skip:24  time:476s
fi-kbl-7567u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:465s
fi-kbl-r         total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:510s
fi-pnv-d510      total:285  pass:219  dwarn:1   dfail:0   fail:0   skip:65  time:661s
fi-skl-6260u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:440s
fi-skl-6600u     total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:529s
fi-skl-6700hq    total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:537s
fi-skl-6700k2    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:502s
fi-skl-6770hq    total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:487s
fi-skl-guc       total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:431s
fi-skl-gvtdvm    total:285  pass:262  dwarn:0   dfail:0   fail:0   skip:23  time:448s
fi-snb-2520m     total:285  pass:245  dwarn:0   dfail:0   fail:0   skip:40  time:576s
fi-snb-2600      total:285  pass:245  dwarn:0   dfail:0   fail:0   skip:40  time:399s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1166/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_frontbuffer_tracking: Rework to prevent modesets!

[Patchwork]

== Series Details ==

Series: tests/kms_frontbuffer_tracking: Rework to prevent modesets!
URL   : https://patchwork.freedesktop.org/series/40195/
State : success

== Summary ==

---- Possible new issues:

Test kms_cursor_crc:
        Subgroup cursor-128x128-suspend:
                skip       -> PASS       (shard-snb)

---- Known issues:

Test kms_cursor_legacy:
        Subgroup 2x-long-flip-vs-cursor-legacy:
                incomplete -> PASS       (shard-hsw) fdo#104873
Test kms_flip:
        Subgroup dpms-vs-vblank-race:
                fail       -> PASS       (shard-hsw) fdo#103060
        Subgroup flip-vs-absolute-wf_vblank:
                fail       -> PASS       (shard-hsw) fdo#100368
Test kms_flip_tiling:
        Subgroup flip-x-tiled:
                fail       -> PASS       (shard-apl) fdo#103822
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                skip       -> PASS       (shard-snb) fdo#103375 +1
Test kms_plane_multiple:
        Subgroup atomic-pipe-a-tiling-x:
                pass       -> FAIL       (shard-snb) fdo#103166 +1

fdo#104873 https://bugs.freedesktop.org/show_bug.cgi?id=104873
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166

shard-apl        total:3478 pass:1814 dwarn:1   dfail:0   fail:7   skip:1655 time:13117s
shard-hsw        total:3478 pass:1768 dwarn:1   dfail:0   fail:1   skip:1707 time:11755s
shard-snb        total:3478 pass:1357 dwarn:1   dfail:0   fail:3   skip:2117 time:7228s
Blacklisted hosts:
shard-kbl        total:3478 pass:1937 dwarn:2   dfail:1   fail:9   skip:1529 time:9827s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1166/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_frontbuffer_tracking: Rework to prevent modesets!

[Daniel Vetter]

Hi all,

Ok, something went wrong here it seems:

This patch series passed CI nicely, but then it caused a regression:

https://bugs.freedesktop.org/show_bug.cgi?id=105503

Another problem is that history moves so damn fast nowadays that even
the longer per-test history is useless already:

https://intel-gfx-ci.01.org/tree/drm-tip/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu.html

Just 1 week later I can't even see anymore where this started. This
makes finding and analysing regressions a real pain.

Tomi/Arek, can we have more history here? Or some view to go back further.

Cheers, Daniel


On Tue, Mar 20, 2018 at 12:46 PM, Patchwork
<patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: tests/kms_frontbuffer_tracking: Rework to prevent modesets!
> URL   : https://patchwork.freedesktop.org/series/40195/
> State : success
>
> == Summary ==
>
> ---- Possible new issues:
>
> Test kms_cursor_crc:
>         Subgroup cursor-128x128-suspend:
>                 skip       -> PASS       (shard-snb)
>
> ---- Known issues:
>
> Test kms_cursor_legacy:
>         Subgroup 2x-long-flip-vs-cursor-legacy:
>                 incomplete -> PASS       (shard-hsw) fdo#104873
> Test kms_flip:
>         Subgroup dpms-vs-vblank-race:
>                 fail       -> PASS       (shard-hsw) fdo#103060
>         Subgroup flip-vs-absolute-wf_vblank:
>                 fail       -> PASS       (shard-hsw) fdo#100368
> Test kms_flip_tiling:
>         Subgroup flip-x-tiled:
>                 fail       -> PASS       (shard-apl) fdo#103822
> Test kms_pipe_crc_basic:
>         Subgroup suspend-read-crc-pipe-a:
>                 skip       -> PASS       (shard-snb) fdo#103375 +1
> Test kms_plane_multiple:
>         Subgroup atomic-pipe-a-tiling-x:
>                 pass       -> FAIL       (shard-snb) fdo#103166 +1
>
> fdo#104873 https://bugs.freedesktop.org/show_bug.cgi?id=104873
> fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
> fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
> fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
> fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
> fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
>
> shard-apl        total:3478 pass:1814 dwarn:1   dfail:0   fail:7   skip:1655 time:13117s
> shard-hsw        total:3478 pass:1768 dwarn:1   dfail:0   fail:1   skip:1707 time:11755s
> shard-snb        total:3478 pass:1357 dwarn:1   dfail:0   fail:3   skip:2117 time:7228s
> Blacklisted hosts:
> shard-kbl        total:3478 pass:1937 dwarn:2   dfail:1   fail:9   skip:1529 time:9827s
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1166/shards.html
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_frontbuffer_tracking: Rework to prevent modesets!

[Rodrigo Vivi]

On Thu, Apr 05, 2018 at 09:56:42PM +0200, Daniel Vetter wrote:
> Hi all,
> 
> Ok, something went wrong here it seems:
> 
> This patch series passed CI nicely, but then it caused a regression:
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=105503
> 
> Another problem is that history moves so damn fast nowadays that even
> the longer per-test history is useless already:
> 
> https://intel-gfx-ci.01.org/tree/drm-tip/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu.html
> 
> Just 1 week later I can't even see anymore where this started. This
> makes finding and analysing regressions a real pain.
> 
> Tomi/Arek, can we have more history here? Or some view to go back further.

There is an extra aspect here. Paulo raised that the removal of modesets
could fully invalidate the kms_frontbuffer_tracking entirely.

So I think we should revert this patch.

> 
> Cheers, Daniel
> 
> 
> On Tue, Mar 20, 2018 at 12:46 PM, Patchwork
> <patchwork@emeril.freedesktop.org> wrote:
> > == Series Details ==
> >
> > Series: tests/kms_frontbuffer_tracking: Rework to prevent modesets!
> > URL   : https://patchwork.freedesktop.org/series/40195/
> > State : success
> >
> > == Summary ==
> >
> > ---- Possible new issues:
> >
> > Test kms_cursor_crc:
> >         Subgroup cursor-128x128-suspend:
> >                 skip       -> PASS       (shard-snb)
> >
> > ---- Known issues:
> >
> > Test kms_cursor_legacy:
> >         Subgroup 2x-long-flip-vs-cursor-legacy:
> >                 incomplete -> PASS       (shard-hsw) fdo#104873
> > Test kms_flip:
> >         Subgroup dpms-vs-vblank-race:
> >                 fail       -> PASS       (shard-hsw) fdo#103060
> >         Subgroup flip-vs-absolute-wf_vblank:
> >                 fail       -> PASS       (shard-hsw) fdo#100368
> > Test kms_flip_tiling:
> >         Subgroup flip-x-tiled:
> >                 fail       -> PASS       (shard-apl) fdo#103822
> > Test kms_pipe_crc_basic:
> >         Subgroup suspend-read-crc-pipe-a:
> >                 skip       -> PASS       (shard-snb) fdo#103375 +1
> > Test kms_plane_multiple:
> >         Subgroup atomic-pipe-a-tiling-x:
> >                 pass       -> FAIL       (shard-snb) fdo#103166 +1
> >
> > fdo#104873 https://bugs.freedesktop.org/show_bug.cgi?id=104873
> > fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
> > fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
> > fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
> > fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
> > fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
> >
> > shard-apl        total:3478 pass:1814 dwarn:1   dfail:0   fail:7   skip:1655 time:13117s
> > shard-hsw        total:3478 pass:1768 dwarn:1   dfail:0   fail:1   skip:1707 time:11755s
> > shard-snb        total:3478 pass:1357 dwarn:1   dfail:0   fail:3   skip:2117 time:7228s
> > Blacklisted hosts:
> > shard-kbl        total:3478 pass:1937 dwarn:2   dfail:1   fail:9   skip:1529 time:9827s
> >
> > == Logs ==
> >
> > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1166/shards.html
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> 
> 
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_frontbuffer_tracking: Rework to prevent modesets!

[Lofstedt, Marta]

> -----Original Message-----
> From: Vivi, Rodrigo
> Sent: Thursday, April 5, 2018 11:36 PM
> To: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: IGT development <igt-dev@lists.freedesktop.org>; Sarvela, Tomi P
> <tomi.p.sarvela@intel.com>; Hiler, Arkadiusz <arkadiusz.hiler@intel.com>;
> Saarinen, Jani <jani.saarinen@intel.com>; Lofstedt, Marta
> <marta.lofstedt@intel.com>; Zanoni, Paulo R <paulo.r.zanoni@intel.com>;
> Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Maarten
> Lankhorst <maarten.lankhorst@linux.intel.com>
> Subject: Re: [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_frontbuffer_tracking:
> Rework to prevent modesets!
> 
> On Thu, Apr 05, 2018 at 09:56:42PM +0200, Daniel Vetter wrote:
> > Hi all,
> >
> > Ok, something went wrong here it seems:
> >
> > This patch series passed CI nicely, but then it caused a regression:
> >
> > https://bugs.freedesktop.org/show_bug.cgi?id=105503
> >
> > Another problem is that history moves so damn fast nowadays that even
> > the longer per-test history is useless already:
> >
> > https://intel-gfx-ci.01.org/tree/drm-tip/igt@kms_frontbuffer_tracking@
> > fbc-rgb101010-draw-mmap-cpu.html
> >
> > Just 1 week later I can't even see anymore where this started. This
> > makes finding and analysing regressions a real pain.
> >
> > Tomi/Arek, can we have more history here? Or some view to go back
> further.
> 
> There is an extra aspect here. Paulo raised that the removal of modesets
> could fully invalidate the kms_frontbuffer_tracking entirely.
> 
> So I think we should revert this patch.
> 
For this bug I don't think we need to revert the patch, I believe it could be fixed by having the badformat_subtest behave more like the draw_subtest. 

However, I am really concerned with https://bugs.freedesktop.org/show_bug.cgi?id=105798 
On SNB-shard and IVB drmtip runs. I have noticed that kms tests that are always skipped now can fail on random shards on random machines. This appear to always start with a kms_frontbuffer_tracking failing then other kms test can be affected. It appear as if this sorts itself out after for example a kms_flip test was run. Since the frequency of hitting this only is ~10% and it starts at random tests it is very difficult to say when it started. My theory is that some recent frontbuffer tracking rework don't take into account first frontbuffer_tracking test is supposed to be skipped, 

> >
> > Cheers, Daniel
> >
> >
> > On Tue, Mar 20, 2018 at 12:46 PM, Patchwork
> > <patchwork@emeril.freedesktop.org> wrote:
> > > == Series Details ==
> > >
> > > Series: tests/kms_frontbuffer_tracking: Rework to prevent modesets!
> > > URL   : https://patchwork.freedesktop.org/series/40195/
> > > State : success
> > >
> > > == Summary ==
> > >
> > > ---- Possible new issues:
> > >
> > > Test kms_cursor_crc:
> > >         Subgroup cursor-128x128-suspend:
> > >                 skip       -> PASS       (shard-snb)
> > >
> > > ---- Known issues:
> > >
> > > Test kms_cursor_legacy:
> > >         Subgroup 2x-long-flip-vs-cursor-legacy:
> > >                 incomplete -> PASS       (shard-hsw) fdo#104873
> > > Test kms_flip:
> > >         Subgroup dpms-vs-vblank-race:
> > >                 fail       -> PASS       (shard-hsw) fdo#103060
> > >         Subgroup flip-vs-absolute-wf_vblank:
> > >                 fail       -> PASS       (shard-hsw) fdo#100368
> > > Test kms_flip_tiling:
> > >         Subgroup flip-x-tiled:
> > >                 fail       -> PASS       (shard-apl) fdo#103822
> > > Test kms_pipe_crc_basic:
> > >         Subgroup suspend-read-crc-pipe-a:
> > >                 skip       -> PASS       (shard-snb) fdo#103375 +1
> > > Test kms_plane_multiple:
> > >         Subgroup atomic-pipe-a-tiling-x:
> > >                 pass       -> FAIL       (shard-snb) fdo#103166 +1
> > >
> > > fdo#104873 https://bugs.freedesktop.org/show_bug.cgi?id=104873
> > > fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
> > > fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
> > > fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
> > > fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
> > > fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
> > >
> > > shard-apl        total:3478 pass:1814 dwarn:1   dfail:0   fail:7   skip:1655
> time:13117s
> > > shard-hsw        total:3478 pass:1768 dwarn:1   dfail:0   fail:1   skip:1707
> time:11755s
> > > shard-snb        total:3478 pass:1357 dwarn:1   dfail:0   fail:3   skip:2117
> time:7228s
> > > Blacklisted hosts:
> > > shard-kbl        total:3478 pass:1937 dwarn:2   dfail:1   fail:9   skip:1529
> time:9827s
> > >
> > > == Logs ==
> > >
> > > For more details see:
> > > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1166/shards.html
> > > _______________________________________________
> > > igt-dev mailing list
> > > igt-dev@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> >
> >
> >
> > --
> > Daniel Vetter
> > Software Engineer, Intel Corporation
> > +41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_frontbuffer_tracking: Rework to prevent modesets!

[Tomi Sarvela]

On 04/05/2018 10:56 PM, Daniel Vetter wrote:
> Hi all,
> 
> Ok, something went wrong here it seems:
> 
> This patch series passed CI nicely, but then it caused a regression:
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=105503
> 
> Another problem is that history moves so damn fast nowadays that even
> the longer per-test history is useless already:
> 
> https://intel-gfx-ci.01.org/tree/drm-tip/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu.html
> 
> Just 1 week later I can't even see anymore where this started. This > makes finding and analysing regressions a real pain.
> 
> Tomi/Arek, can we have more history here? Or some view to go back further.

We do have some 1000 builds of history, 80 visible was chosen by memory 
limits: it's easiest to load all the results in memory, then print out 
all the host- and test-history htmls.

It probably could be increased somewhat, or make it skip even builds, or 
something else?

Tomi

> 
> Cheers, Daniel
> 
> 
> On Tue, Mar 20, 2018 at 12:46 PM, Patchwork
> <patchwork@emeril.freedesktop.org> wrote:
>> == Series Details ==
>>
>> Series: tests/kms_frontbuffer_tracking: Rework to prevent modesets!
>> URL   : https://patchwork.freedesktop.org/series/40195/
>> State : success
>>
>> == Summary ==
>>
>> ---- Possible new issues:
>>
>> Test kms_cursor_crc:
>>          Subgroup cursor-128x128-suspend:
>>                  skip       -> PASS       (shard-snb)
>>
>> ---- Known issues:
>>
>> Test kms_cursor_legacy:
>>          Subgroup 2x-long-flip-vs-cursor-legacy:
>>                  incomplete -> PASS       (shard-hsw) fdo#104873
>> Test kms_flip:
>>          Subgroup dpms-vs-vblank-race:
>>                  fail       -> PASS       (shard-hsw) fdo#103060
>>          Subgroup flip-vs-absolute-wf_vblank:
>>                  fail       -> PASS       (shard-hsw) fdo#100368
>> Test kms_flip_tiling:
>>          Subgroup flip-x-tiled:
>>                  fail       -> PASS       (shard-apl) fdo#103822
>> Test kms_pipe_crc_basic:
>>          Subgroup suspend-read-crc-pipe-a:
>>                  skip       -> PASS       (shard-snb) fdo#103375 +1
>> Test kms_plane_multiple:
>>          Subgroup atomic-pipe-a-tiling-x:
>>                  pass       -> FAIL       (shard-snb) fdo#103166 +1
>>
>> fdo#104873 https://bugs.freedesktop.org/show_bug.cgi?id=104873
>> fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
>> fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
>> fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
>> fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
>> fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
>>
>> shard-apl        total:3478 pass:1814 dwarn:1   dfail:0   fail:7   skip:1655 time:13117s
>> shard-hsw        total:3478 pass:1768 dwarn:1   dfail:0   fail:1   skip:1707 time:11755s
>> shard-snb        total:3478 pass:1357 dwarn:1   dfail:0   fail:3   skip:2117 time:7228s
>> Blacklisted hosts:
>> shard-kbl        total:3478 pass:1937 dwarn:2   dfail:1   fail:9   skip:1529 time:9827s
>>
>> == Logs ==
>>
>> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1166/shards.html
>> _______________________________________________
>> igt-dev mailing list
>> igt-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/igt-dev
> 
> 
> 


Tomi
-- 
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 0/5] tests/kms_frontbuffer_tracking: Rework to prevent modesets!

[Maarten Lankhorst]

Now that FBC can be toggled at runtime, I wanted to make sure that we try to prevent
modesets as much as we can.
Patch 4 is still experimental, and needs kernel support to work. Still wanted to add it,
but can be skipped in reviews.

Maarten Lankhorst (5):
  lib/igt_aux: Add igt_get_module_param_int.
  tests/kms_frontbuffer_tracking: Rework toggling drrs/fbc/psr.
  tests/kms_frontbuffer_tracking: Fix basic subtest
  tests/kms_frontbuffer_tracking: Add support for toggling edp psr
    through debugfs, to prevent a modeset
  tests/kms_frontbuffer_tracking: Remove redundant modesets during
    subtest start, v2.

 lib/igt_aux.c                    |  61 ++++++++++++++++++
 lib/igt_aux.h                    |   3 +
 tests/kms_frontbuffer_tracking.c | 136 +++++++++++++++++++++++++++++----------
 3 files changed, 166 insertions(+), 34 deletions(-)

-- 
2.16.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_frontbuffer_tracking: Rework to prevent modesets!

[Patchwork]

== Series Details ==

Series: tests/kms_frontbuffer_tracking: Rework to prevent modesets!
URL   : https://patchwork.freedesktop.org/series/39803/
State : success

== Summary ==

---- Known issues:

Test gem_eio:
        Subgroup in-flight-contexts:
                incomplete -> PASS       (shard-apl) fdo#105341
Test kms_atomic_transition:
        Subgroup 1x-modeset-transitions-nonblocking-fencing:
                fail       -> PASS       (shard-apl) fdo#103207
Test kms_cursor_crc:
        Subgroup cursor-256x256-suspend:
                skip       -> PASS       (shard-snb) fdo#103375
Test kms_rotation_crc:
        Subgroup sprite-rotation-180:
                pass       -> FAIL       (shard-snb) fdo#105185
Test kms_sysfs_edid_timing:
                warn       -> PASS       (shard-apl) fdo#100047
Test kms_vblank:
        Subgroup pipe-a-ts-continuation-dpms-suspend:
                pass       -> INCOMPLETE (shard-hsw) fdo#103540

fdo#105341 https://bugs.freedesktop.org/show_bug.cgi?id=105341
fdo#103207 https://bugs.freedesktop.org/show_bug.cgi?id=103207
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#105185 https://bugs.freedesktop.org/show_bug.cgi?id=105185
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540

shard-apl        total:3473 pass:1831 dwarn:1   dfail:0   fail:7   skip:1634 time:12978s
shard-hsw        total:3447 pass:1766 dwarn:1   dfail:0   fail:2   skip:1676 time:10845s
shard-snb        total:3473 pass:1364 dwarn:1   dfail:0   fail:4   skip:2104 time:7191s
Blacklisted hosts:
shard-kbl        total:3408 pass:1921 dwarn:1   dfail:1   fail:9   skip:1475 time:9526s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1112/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev