Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tursulin@ursulin.net>
To: igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org,
	Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: [igt-dev] [PATCH i-g-t 4/7] trace.pl: Fix engine busy accounting in split mode
Date: Tue,  8 May 2018 18:31:12 +0100	[thread overview]
Message-ID: <20180508173115.24550-4-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20180508173115.24550-1-tvrtko.ursulin@linux.intel.com>

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

In split mode all requests have to be added up since they were previously
re-arranged so there is no overlap.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: John Harrison <John.C.Harrison@intel.com>
---
 scripts/trace.pl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/trace.pl b/scripts/trace.pl
index fae94d5044ef..696c18e8b1cf 100755
--- a/scripts/trace.pl
+++ b/scripts/trace.pl
@@ -601,7 +601,8 @@ foreach my $key (@sorted_keys) {
 	$db{$key}->{'submit-delay'} = $db{$key}->{'submit'} - $db{$key}->{'queue'};
 	$db{$key}->{'duration'} = $notify - $start;
 
-	$running{$ring} += $end - $start unless exists $db{$key}->{'no-end'};
+	$running{$ring} += $end - $start if $correct_durations or
+					    not exists $db{$key}->{'no-end'};
 	$runnable{$ring} += $db{$key}->{'execute-delay'};
 	$queued{$ring} += $start - $db{$key}->{'execute-delay'} - $db{$key}->{'queue'};
 
-- 
2.14.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2018-05-08 17:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-08 17:31 [Intel-gfx] [PATCH i-g-t 1/7] trace.pl: Add support for colouring context execution Tvrtko Ursulin
2018-05-08 17:31 ` [igt-dev] [PATCH i-g-t 2/7] trace.pl: Improve readability of graphical timeline representation Tvrtko Ursulin
2018-05-08 17:31 ` [igt-dev] [PATCH i-g-t 3/7] trace.pl: Remove context squashing option Tvrtko Ursulin
2018-05-08 17:31 ` Tvrtko Ursulin [this message]
2018-05-08 17:31 ` [igt-dev] [PATCH i-g-t 5/7] trace.pl: Fix incomplete request handling Tvrtko Ursulin
2018-05-08 17:31 ` [igt-dev] [PATCH i-g-t 6/7] trace.pl: Basic preemption support Tvrtko Ursulin
2018-05-08 17:31 ` [igt-dev] [PATCH i-g-t 7/7] trace.pl: Fix request split mode Tvrtko Ursulin
2018-05-09 15:32   ` [igt-dev] [PATCH i-g-t v4 " Tvrtko Ursulin
2018-05-08 19:09 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/7] trace.pl: Add support for colouring context execution Patchwork
2018-05-08 23:01 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-05-09 15:59 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/7] trace.pl: Add support for colouring context execution (rev2) Patchwork
2018-05-09 19:10 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180508173115.24550-4-tvrtko.ursulin@linux.intel.com \
    --to=tursulin@ursulin.net \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=tvrtko.ursulin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox