Re: [igt-dev] [PATCH i-g-t 04/10] lib: Clean up format_desc

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Thu, May 17, 2018 at 09:13:06PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjala (2018-05-17 20:51:42)
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Always populate the plane_bpp[] stuff, and use named initializers so
> > that we can actually see what's being set to what.
> > 
> > v2: Fix depth for xrgb8888
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> > ---
> >  lib/igt_fb.c | 66 +++++++++++++++++++++++++++++++++---------------------------
> >  1 file changed, 36 insertions(+), 30 deletions(-)
> > 
> > diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> > index 5cf2cd7d9e90..af8ba70b0a2a 100644
> > --- a/lib/igt_fb.c
> > +++ b/lib/igt_fb.c
> > @@ -57,26 +57,35 @@
> >   */
> >  
> >  /* drm fourcc/cairo format maps */
> > -#define DF(did, cid, ...)      \
> > -       { DRM_FORMAT_##did, CAIRO_FORMAT_##cid, # did, __VA_ARGS__ }
> >  static struct format_desc_struct {
> > +       const char *name;
> >         uint32_t drm_id;
> >         cairo_format_t cairo_id;
> > -       const char *name;
> > -       int bpp;
> >         int depth;
> > -       int planes;
> > +       int num_planes;
> >         int plane_bpp[4];
> >  } format_desc[] = {
> > -       DF(RGB565,      RGB16_565,      16, 16),
> > -       //DF(RGB888,    INVALID,        24, 24),
> > -       DF(XRGB8888,    RGB24,          32, 24),
> > -       DF(XRGB2101010, RGB30,          32, 30),
> > -       DF(ARGB8888,    ARGB32,         32, 32),
> > -       DF(NV12,        RGB24,          32, -1, 2, {8, 16}),
> > +       { .name = "RGB565", .depth = 16, .drm_id = DRM_FORMAT_RGB565,
> > +         .cairo_id = CAIRO_FORMAT_RGB16_565,
> > +         .num_planes = 1, .plane_bpp = { 16, },
> > +       },
> 
> There's no enum to suggest
> 	[MY_FORMAT_DESC_A] = {
> 		.name = "XRGB8888", .depth = 24, .drm_id = DRM_FORMAT_XRGB8888,
> 		.cairo_id = CAIRO_FORMAT_RGB24,
> 		.num_planes = 1, .plane_bpp = { 32, },
> 	}
> ?

I don't think we have anything like that atm.

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev