Re: [igt-dev] [PATCH v3 03/11] fb: Add format conversion routine

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Thu, May 24, 2018 at 05:19:04PM +0200, Maxime Ripard wrote:
> On Thu, May 24, 2018 at 05:58:13PM +0300, Ville Syrjälä wrote:
> > On Thu, May 24, 2018 at 04:24:42PM +0200, Maxime Ripard wrote:
> > > The chamelium format subtests will need to convert the reference pattern to
> > > the format to be tested on the DRM device.
> > > 
> > > However, Cairo is very limited when it comes to format, and while pixman
> > > has much more support for formats, it's still falling short compared to
> > > what DRM exposes, especially on the YUV side.
> > 
> > We already have the capability to do format conversions automagically.
> > I'm extending it to handle more YUV stuff here:
> > https://patchwork.freedesktop.org/series/43651/
> > 
> > Can you hook up the pixman stuff in the same way so that we don't
> > have to any explicit conversion stuff in the tests themselves?
> 
> I really think that the assumption that cairo will handle it is not a
> proper fit. Cairo support is very limited, just like pixman is to a
> lesser extent, and we should just break the assumption that we will
> get a cairo surface all the time.

Not sure what you're saying here. We don't assume cairo handles all
the formats, well, because it doesn't. We just magically convert
to/from XRGB888 so that cairo doesn't have to handle anything else.

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev