From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Katarzyna Dec <katarzyna.dec@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] lib/rendercopy: Add gen4/5 rendercopy
Date: Thu, 14 Jun 2018 16:24:57 +0300 [thread overview]
Message-ID: <20180614132457.GG20518@intel.com> (raw)
In-Reply-To: <20180614131313.GF20459@kdec5-desk.ger.corp.intel.com>
On Thu, Jun 14, 2018 at 03:13:13PM +0200, Katarzyna Dec wrote:
> On Mon, Jun 11, 2018 at 07:14:18PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Add rendercopy implementation for gen4/5. Basic structure
> > copied from the gen6 implementation, and the gen4/5 specific
> > bits were mostly lifted from sna.
> >
> I have pushed remaining rendercopy code to public ML.
> Could you please remove duplications from registers?
> I've talked to Lukasz and he will remove duplications in
> other places.
> Maybe you could make more patches instead of 1?
>
> We are waiting for your patches :)
Since you're already working on the deduplication I don't know if I
should stick my fingers in that pie. I'm afraid ocd will kick in
and I'll just move almost everything from the gen6+ files to the gen4
file, which will probably conflict badly with what you're already
doing.
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2018-06-14 13:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 16:14 [igt-dev] [PATCH i-g-t] lib/rendercopy: Add gen4/5 rendercopy Ville Syrjala
2018-06-11 18:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-06-12 0:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-06-13 10:35 ` [igt-dev] [PATCH i-g-t] " Kalamarz, Lukasz
2018-06-14 13:23 ` Ville Syrjälä
2018-06-14 13:13 ` Katarzyna Dec
2018-06-14 13:24 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614132457.GG20518@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=katarzyna.dec@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox