Re: [igt-dev] [PATCH i-g-t] gtkdoc: Remove the build_by_default hack

[Daniel Vetter <daniel@ffwll.ch>]

On Mon, Jun 04, 2018 at 02:07:21PM -0700, Eric Anholt wrote:
> Daniel Vetter <daniel.vetter@ffwll.ch> writes:
> 
> > On Wed, Apr 4, 2018 at 8:39 PM, Eric Anholt <eric@anholt.net> wrote:
> >> Daniel Vetter <daniel.vetter@ffwll.ch> writes:
> >>> meson 0.45 properly supports generated content_files. Except for the
> >>> minor issue that we're hitting an internal bug in meson. I've made a
> >>> pull request for that, but this needs more work:
> >>>
> >>> https://github.com/mesonbuild/meson/pull/3189
> >>>
> >>> Downside of this all is that we'd need to up the meson requirements to
> >>> something like 0.46, at least if you want to build the docs.
> >>
> >> What's the status of this?  I just pulled this to my vc5 dev branch so
> >> that builds don't take ages, and it seems to have fixed it for me.
> >
> > I need to revise the meson pull to include a proper regression test.
> > Which I didn't find time for yet. Then we need to wait until that
> > meson is released and in enough distros, and then we can merge this
> > patch. As-is, with unpatched meson, this patch breaks the docs build.
> 
> Ping - the upstream PR is closed, but I can't tell if 0.46 is usable
> yet.  I'm still carrying this patch in my trees so I can cross compile.

Sry I dropped the ball on this completely, and somehow also didn't see the
update that my github pull request got closed.

The fix indeed works, but it's not even yet in a released version of
meson, only in 0.47-dev. Bit aggressive to require that from developers
and CI ...

I'll resend the patch meanwhile with those bits updated.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev