From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] lib/igt_draw: Zero initalize the igt_bufs
Date: Fri, 6 Jul 2018 19:39:40 +0300 [thread overview]
Message-ID: <20180706163940.7699-1-ville.syrjala@linux.intel.com> (raw)
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
I missed these when sprinkling the memsets. Using stack garbage as the
aux surface state isn't a good idea. Causes kms_front_buffer_tracking
to fail on skl+.
Fixes: a4393c3951ec ("lib: Add aux surface state to igt_buf")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
lib/igt_draw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_draw.c b/lib/igt_draw.c
index ebae915113da..c7d5770dca28 100644
--- a/lib/igt_draw.c
+++ b/lib/igt_draw.c
@@ -568,7 +568,7 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
drm_intel_bo *src, *dst;
uint32_t devid = intel_get_drm_devid(fd);
igt_render_copyfunc_t rendercopy = igt_get_render_copyfunc(devid);
- struct igt_buf src_buf, dst_buf;
+ struct igt_buf src_buf = {}, dst_buf = {};
struct intel_batchbuffer *batch;
uint32_t tiling, swizzle;
struct buf_data tmp;
--
2.16.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2018-07-06 16:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 16:39 Ville Syrjala [this message]
2018-07-06 16:43 ` [igt-dev] [PATCH i-g-t] lib/igt_draw: Zero initalize the igt_bufs Chris Wilson
2018-07-06 16:45 ` Antonio Argenziano
2018-07-06 18:32 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-07-07 19:28 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-07-09 14:36 ` [igt-dev] ✗ Fi.CI.BAT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-06-24 15:14 [igt-dev] [PATCH i-g-t] " Ville Syrjala
2019-06-24 15:27 ` Ville Syrjälä
2019-06-25 7:17 ` Ser, Simon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180706163940.7699-1-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox