From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/gem_render_copy: Check for GEM before running
Date: Mon, 9 Jul 2018 16:19:40 +0300 [thread overview]
Message-ID: <20180709131940.GR5565@intel.com> (raw)
In-Reply-To: <20180709102847.15553-1-chris@chris-wilson.co.uk>
On Mon, Jul 09, 2018 at 11:28:47AM +0100, Chris Wilson wrote:
> gem_render_copy requires a working GPU so check first.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/gem_render_copy.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/gem_render_copy.c b/tests/gem_render_copy.c
> index 8373cd738..238e70e97 100644
> --- a/tests/gem_render_copy.c
> +++ b/tests/gem_render_copy.c
> @@ -529,6 +529,7 @@ int main(int argc, char **argv)
> igt_fixture {
> data.drm_fd = drm_open_driver_render(DRIVER_INTEL);
> data.devid = intel_get_drm_devid(data.drm_fd);
> + igt_require_gem(data.drm_fd);
Is there ever a case where we'd be happy with open_driver() failing?
Just wondering about putting the require into the function itself.
Anyways
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096);
> igt_assert(data.bufmgr);
> --
> 2.18.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-07-09 13:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 10:28 [igt-dev] [PATCH i-g-t] igt/gem_render_copy: Check for GEM before running Chris Wilson
2018-07-09 11:34 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-07-09 13:19 ` Ville Syrjälä [this message]
2018-07-09 13:23 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2018-07-09 14:49 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180709131940.GR5565@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox