[igt-dev] [PATCH i-g-t] lib: Require working GEM (!wedged) to allow hang injection

[igt-dev] [PATCH i-g-t] lib: Require working GEM (!wedged) to allow hang injection

[Chris Wilson]

As we ordinarily use a spinning batch to trigger a hang, we cannot do so
without execbuf. On the other hand, if we do a manual reset of the
wedged driver, we expect it to remain wedged and for the reset to fail;
failing the test. Even if we remove the igt_assert(!wedged), the test is
suspect as we don't know if the reset took place and so do not know if
the conditions the test is trying to setup apply.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 lib/igt_gt.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/lib/igt_gt.c b/lib/igt_gt.c
index 4569fd36b..89b318ae6 100644
--- a/lib/igt_gt.c
+++ b/lib/igt_gt.c
@@ -162,6 +162,13 @@ igt_hang_t igt_allow_hang(int fd, unsigned ctx, unsigned flags)
 	};
 	unsigned ban;
 
+	/*
+	 * If the driver is already wedged, we don't expect it to be able
+	 * to recover from reset and for it to remain wedged. It's hard to
+	 * say even if we do hang/reset making the test suspect.
+	 */
+	igt_require_gem(fd);
+
 	igt_assert(igt_sysfs_set_parameter
 		   (fd, "reset", "%d", INT_MAX /* any reset method */));
 
-- 
2.18.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for lib: Require working GEM (!wedged) to allow hang injection

[Patchwork]

== Series Details ==

Series: lib: Require working GEM (!wedged) to allow hang injection
URL   : https://patchwork.freedesktop.org/series/46257/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4463 -> IGTPW_1550 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46257/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1550 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@prime_vgem@basic-fence-flip:
      fi-elk-e7500:       PASS -> FAIL (fdo#103182)

    
    ==== Possible fixes ====

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       DMESG-FAIL (fdo#102614, fdo#106103) -> PASS

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
      {fi-skl-iommu}:     FAIL (fdo#106686) -> SKIP +2

    igt@prime_vgem@basic-fence-flip:
      fi-ilk-650:         FAIL (fdo#104008) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#103182 https://bugs.freedesktop.org/show_bug.cgi?id=103182
  fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
  fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
  fdo#106686 https://bugs.freedesktop.org/show_bug.cgi?id=106686


== Participating hosts (47 -> 42) ==

  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4544 -> IGTPW_1550

  CI_DRM_4463: 756ded1fe53d1449d239c6b34f97e03e478a8a38 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1550: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1550/
  IGT_4544: 764160f214cd916ddb79408b9f28ac0ad2df40e0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1550/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] lib: Require working GEM (!wedged) to allow hang injection

[Mika Kuoppala]

Chris Wilson <chris@chris-wilson.co.uk> writes:

> As we ordinarily use a spinning batch to trigger a hang, we cannot do so
> without execbuf. On the other hand, if we do a manual reset of the
> wedged driver, we expect it to remain wedged and for the reset to fail;

by 'manual' you are referring to '-1' on i915_wedged debugfs entry?
-Mika

> failing the test. Even if we remove the igt_assert(!wedged), the test is
> suspect as we don't know if the reset took place and so do not know if
> the conditions the test is trying to setup apply.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  lib/igt_gt.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/lib/igt_gt.c b/lib/igt_gt.c
> index 4569fd36b..89b318ae6 100644
> --- a/lib/igt_gt.c
> +++ b/lib/igt_gt.c
> @@ -162,6 +162,13 @@ igt_hang_t igt_allow_hang(int fd, unsigned ctx, unsigned flags)
>  	};
>  	unsigned ban;
>  
> +	/*
> +	 * If the driver is already wedged, we don't expect it to be able
> +	 * to recover from reset and for it to remain wedged. It's hard to
> +	 * say even if we do hang/reset making the test suspect.
> +	 */
> +	igt_require_gem(fd);
> +
>  	igt_assert(igt_sysfs_set_parameter
>  		   (fd, "reset", "%d", INT_MAX /* any reset method */));
>  
> -- 
> 2.18.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] lib: Require working GEM (!wedged) to allow hang injection

[Chris Wilson]

Quoting Mika Kuoppala (2018-07-10 14:13:39)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
> 
> > As we ordinarily use a spinning batch to trigger a hang, we cannot do so
> > without execbuf. On the other hand, if we do a manual reset of the
> > wedged driver, we expect it to remain wedged and for the reset to fail;
> 
> by 'manual' you are referring to '-1' on i915_wedged debugfs entry?

Yes, igt_force_gpu_reset() as opposed to igt_hang_ring().
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] lib: Require working GEM (!wedged) to allow hang injection

[Mika Kuoppala]

Chris Wilson <chris@chris-wilson.co.uk> writes:

> As we ordinarily use a spinning batch to trigger a hang, we cannot do so
> without execbuf. On the other hand, if we do a manual reset of the
> wedged driver, we expect it to remain wedged and for the reset to fail;
> failing the test. Even if we remove the igt_assert(!wedged), the test is
> suspect as we don't know if the reset took place and so do not know if
> the conditions the test is trying to setup apply.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  lib/igt_gt.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/lib/igt_gt.c b/lib/igt_gt.c
> index 4569fd36b..89b318ae6 100644
> --- a/lib/igt_gt.c
> +++ b/lib/igt_gt.c
> @@ -162,6 +162,13 @@ igt_hang_t igt_allow_hang(int fd, unsigned ctx, unsigned flags)
>  	};
>  	unsigned ban;
>  
> +	/*
> +	 * If the driver is already wedged, we don't expect it to be able
> +	 * to recover from reset and for it to remain wedged. It's hard to
> +	 * say even if we do hang/reset making the test suspect.
> +	 */
> +	igt_require_gem(fd);

This will do a manual reset for a wedged driver, trying to rectify the
situation. But we are on a more solid ground after it.

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>


> +
>  	igt_assert(igt_sysfs_set_parameter
>  		   (fd, "reset", "%d", INT_MAX /* any reset method */));
>  
> -- 
> 2.18.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [Intel-gfx] [PATCH i-g-t] lib: Require working GEM (!wedged) to allow hang injection

[Chris Wilson]

Quoting Mika Kuoppala (2018-07-10 14:30:15)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
> 
> > As we ordinarily use a spinning batch to trigger a hang, we cannot do so
> > without execbuf. On the other hand, if we do a manual reset of the
> > wedged driver, we expect it to remain wedged and for the reset to fail;
> > failing the test. Even if we remove the igt_assert(!wedged), the test is
> > suspect as we don't know if the reset took place and so do not know if
> > the conditions the test is trying to setup apply.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> >  lib/igt_gt.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/lib/igt_gt.c b/lib/igt_gt.c
> > index 4569fd36b..89b318ae6 100644
> > --- a/lib/igt_gt.c
> > +++ b/lib/igt_gt.c
> > @@ -162,6 +162,13 @@ igt_hang_t igt_allow_hang(int fd, unsigned ctx, unsigned flags)
> >       };
> >       unsigned ban;
> >  
> > +     /*
> > +      * If the driver is already wedged, we don't expect it to be able
> > +      * to recover from reset and for it to remain wedged. It's hard to
> > +      * say even if we do hang/reset making the test suspect.
> > +      */
> > +     igt_require_gem(fd);
> 
> This will do a manual reset for a wedged driver, trying to rectify the
> situation. But we are on a more solid ground after it.

Hmm, true. Need to wait to make sure it doesn't interfere with gem_eio
and its ilk. I think it remains sensible to verify that we have a
working GEM driver before testing, but there will be a time when we need
something not quite so heavy handed.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[igt-dev] ✓ Fi.CI.IGT: success for lib: Require working GEM (!wedged) to allow hang injection

[Patchwork]

== Series Details ==

Series: lib: Require working GEM (!wedged) to allow hang injection
URL   : https://patchwork.freedesktop.org/series/46257/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4544_full -> IGTPW_1550_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1550_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1550_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46257/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1550_full:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_exec_schedule@deep-vebox:
      shard-kbl:          SKIP -> PASS +1

    igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-msflip-blt:
      shard-hsw:          PASS -> SKIP

    
== Known issues ==

  Here are the changes found in IGTPW_1550_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_hangcheck:
      shard-kbl:          PASS -> DMESG-FAIL (fdo#107174, fdo#106560, fdo#106947)

    igt@drv_suspend@shrink:
      shard-kbl:          PASS -> INCOMPLETE (fdo#106886, fdo#103665)

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665, fdo#106023)

    igt@kms_cursor_crc@cursor-64x64-suspend:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665)

    igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
      shard-glk:          PASS -> FAIL (fdo#105454, fdo#106509)

    igt@kms_cursor_legacy@cursor-vs-flip-toggle:
      shard-hsw:          PASS -> FAIL (fdo#103355)

    igt@kms_flip@dpms-vs-vblank-race-interruptible:
      shard-glk:          PASS -> FAIL (fdo#103060)

    igt@kms_flip@wf_vblank-ts-check-interruptible:
      shard-glk:          PASS -> FAIL (fdo#100368) +1

    igt@kms_flip_tiling@flip-x-tiled:
      shard-glk:          PASS -> FAIL (fdo#107161) +1

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-snb:          PASS -> FAIL (fdo#103166)

    igt@prime_busy@wait-before-bsd1:
      shard-snb:          SKIP -> INCOMPLETE (fdo#105411)

    
    ==== Possible fixes ====

    igt@kms_flip_tiling@flip-to-x-tiled:
      shard-glk:          FAIL (fdo#107161, fdo#103822) -> PASS +1

    igt@pm_rpm@system-suspend:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
  fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
  fdo#107161 https://bugs.freedesktop.org/show_bug.cgi?id=107161
  fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4544 -> IGTPW_1550
    * Linux: CI_DRM_4453 -> CI_DRM_4463

  CI_DRM_4453: 940e07c2a136b53965e4a6728e01e1638f5ba2de @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4463: 756ded1fe53d1449d239c6b34f97e03e478a8a38 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1550: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1550/
  IGT_4544: 764160f214cd916ddb79408b9f28ac0ad2df40e0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1550/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev