From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] igt/kms_flip_tiling: Check GEM availability before use
Date: Thu, 12 Jul 2018 16:00:31 +0300 [thread overview]
Message-ID: <20180712130031.GA5565@intel.com> (raw)
In-Reply-To: <20180712101245.20683-1-chris@chris-wilson.co.uk>
On Thu, Jul 12, 2018 at 11:12:45AM +0100, Chris Wilson wrote:
> We use the GPU to convert between tiling formats, indirectly via the
> call to igt_create_pattern_fb. So before we try and execute commands on
> the GPU, we should check that the GPU is available.
Should this one be in the actualy spot in igt_fb.c where we do
the gem stuff? I could imagine other drivers might want to add
their own mechanisms there.
Or we add some kind of igt_require_fb() to indicate igt_fb
will be used?
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/kms_flip_tiling.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/kms_flip_tiling.c b/tests/kms_flip_tiling.c
> index beeb111be..77ed8a68f 100644
> --- a/tests/kms_flip_tiling.c
> +++ b/tests/kms_flip_tiling.c
> @@ -147,6 +147,7 @@ igt_main
> igt_fixture {
> data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
> data.gen = intel_gen(intel_get_drm_devid(data.drm_fd));
> + igt_require_gem(data.drm_fd);
>
> kmstest_set_vt_graphics_mode();
>
> --
> 2.18.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-07-12 13:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 10:12 [igt-dev] [PATCH i-g-t] igt/kms_flip_tiling: Check GEM availability before use Chris Wilson
2018-07-12 10:54 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-07-12 13:00 ` Ville Syrjälä [this message]
2018-07-12 13:05 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2018-07-12 14:25 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712130031.GA5565@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).