[igt-dev] [PATCH i-g-t] igt/kms_flip_tiling: Check GEM availability before use

[igt-dev] [PATCH i-g-t] igt/kms_flip_tiling: Check GEM availability before use

[Chris Wilson]

We use the GPU to convert between tiling formats, indirectly via the
call to igt_create_pattern_fb. So before we try and execute commands on
the GPU, we should check that the GPU is available.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/kms_flip_tiling.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/kms_flip_tiling.c b/tests/kms_flip_tiling.c
index beeb111be..77ed8a68f 100644
--- a/tests/kms_flip_tiling.c
+++ b/tests/kms_flip_tiling.c
@@ -147,6 +147,7 @@ igt_main
 	igt_fixture {
 		data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
 		data.gen = intel_gen(intel_get_drm_devid(data.drm_fd));
+		igt_require_gem(data.drm_fd);
 
 		kmstest_set_vt_graphics_mode();
 
-- 
2.18.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for igt/kms_flip_tiling: Check GEM availability before use

[Patchwork]

== Series Details ==

Series: igt/kms_flip_tiling: Check GEM availability before use
URL   : https://patchwork.freedesktop.org/series/46376/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4474 -> IGTPW_1563 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46376/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1563:

  === IGT changes ===

    ==== Possible regressions ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      {fi-cfl-8109u}:     PASS -> INCOMPLETE

    
== Known issues ==

  Here are the changes found in IGTPW_1563 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-kbl-7500u:       PASS -> DMESG-WARN (fdo#105128, fdo#107139)

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       PASS -> DMESG-FAIL (fdo#106103, fdo#102614)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         PASS -> INCOMPLETE (fdo#103927)

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
  fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
  fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139


== Participating hosts (45 -> 40) ==

  Missing    (5): fi-ctg-p8600 fi-skl-guc fi-ilk-m540 fi-byt-squawks fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4549 -> IGTPW_1563

  CI_DRM_4474: c298e0700edde3d016ae9b16d0ce2a098bee1022 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1563: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1563/
  IGT_4549: e19fd5549e9cf603251704117fc64f4068be5016 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1563/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] igt/kms_flip_tiling: Check GEM availability before use

[Ville Syrjälä]

On Thu, Jul 12, 2018 at 11:12:45AM +0100, Chris Wilson wrote:
> We use the GPU to convert between tiling formats, indirectly via the
> call to igt_create_pattern_fb. So before we try and execute commands on
> the GPU, we should check that the GPU is available.

Should this one be in the actualy spot in igt_fb.c where we do
the gem stuff? I could imagine other drivers might want to add
their own mechanisms there.

Or we add some kind of igt_require_fb() to indicate igt_fb
will be used?

> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  tests/kms_flip_tiling.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/kms_flip_tiling.c b/tests/kms_flip_tiling.c
> index beeb111be..77ed8a68f 100644
> --- a/tests/kms_flip_tiling.c
> +++ b/tests/kms_flip_tiling.c
> @@ -147,6 +147,7 @@ igt_main
>  	igt_fixture {
>  		data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
>  		data.gen = intel_gen(intel_get_drm_devid(data.drm_fd));
> +		igt_require_gem(data.drm_fd);
>  
>  		kmstest_set_vt_graphics_mode();
>  
> -- 
> 2.18.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] igt/kms_flip_tiling: Check GEM availability before use

[Chris Wilson]

Quoting Ville Syrjälä (2018-07-12 14:00:31)
> On Thu, Jul 12, 2018 at 11:12:45AM +0100, Chris Wilson wrote:
> > We use the GPU to convert between tiling formats, indirectly via the
> > call to igt_create_pattern_fb. So before we try and execute commands on
> > the GPU, we should check that the GPU is available.
> 
> Should this one be in the actualy spot in igt_fb.c where we do
> the gem stuff? I could imagine other drivers might want to add
> their own mechanisms there.

Maybe... There's a catch in that igt_require_gem() is quite heavy and
does things (reset the gpu, reset seqno) that you ordinarily don't want
to happen in the middle of the test (and can cause issues if caught
unaware, in particular if you happen to have a spinbatch in flight).

> Or we add some kind of igt_require_fb() to indicate igt_fb
> will be used?

Yup, something along those lines will be better.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for igt/kms_flip_tiling: Check GEM availability before use

[Patchwork]

== Series Details ==

Series: igt/kms_flip_tiling: Check GEM availability before use
URL   : https://patchwork.freedesktop.org/series/46376/
State : failure

== Summary ==

= CI Bug Log - changes from IGT_4549_full -> IGTPW_1563_full =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1563_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1563_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46376/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1563_full:

  === IGT changes ===

    ==== Possible regressions ====

    igt@gem_eio@in-flight-contexts-10ms:
      shard-snb:          PASS -> FAIL

    
    ==== Warnings ====

    igt@gem_exec_schedule@deep-blt:
      shard-kbl:          PASS -> SKIP +1

    igt@gem_mocs_settings@mocs-rc6-bsd2:
      shard-kbl:          SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_1563_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
      shard-glk:          PASS -> FAIL (fdo#105703)

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-snb:          PASS -> FAIL (fdo#106641)

    igt@kms_rotation_crc@primary-rotation-180:
      shard-snb:          PASS -> FAIL (fdo#103925)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    igt@perf@blocking:
      shard-hsw:          PASS -> FAIL (fdo#102252)

    
    ==== Possible fixes ====

    igt@gem_ctx_switch@basic-default-heavy:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@gem_ppgtt@blt-vs-render-ctx0:
      shard-kbl:          INCOMPLETE (fdo#103665, fdo#106023) -> PASS

    igt@kms_cursor_legacy@all-pipes-torture-move:
      shard-glk:          DMESG-WARN -> PASS
      shard-apl:          DMESG-WARN -> PASS
      shard-kbl:          DMESG-WARN -> PASS
      shard-hsw:          DMESG-WARN -> PASS

    igt@kms_flip@2x-plain-flip-ts-check:
      shard-glk:          FAIL (fdo#100368) -> PASS

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105703 https://bugs.freedesktop.org/show_bug.cgi?id=105703
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4549 -> IGTPW_1563
    * Linux: CI_DRM_4469 -> CI_DRM_4474

  CI_DRM_4469: 02e578b7aace48d33fa617dddb40621bd664c92c @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4474: c298e0700edde3d016ae9b16d0ce2a098bee1022 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1563: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1563/
  IGT_4549: e19fd5549e9cf603251704117fc64f4068be5016 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1563/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev