* [Intel-gfx] [PATCH i-g-t 2/2] lib/gt: Check GEM is operation before injecting a hang
2018-07-12 15:37 [igt-dev] [PATCH i-g-t 1/2] igt/gem_gpgpu_fill: Check for GEM before use Chris Wilson
@ 2018-07-12 15:37 ` Chris Wilson
2018-07-12 18:30 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] igt/gem_gpgpu_fill: Check for GEM before use Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2018-07-12 15:37 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
To inject a hang, we execute a spinning batch. This means we require GEM
to be operation before the hang, so check.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
lib/igt_gt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/igt_gt.c b/lib/igt_gt.c
index 89b318ae6..86c6e1972 100644
--- a/lib/igt_gt.c
+++ b/lib/igt_gt.c
@@ -118,6 +118,7 @@ void igt_require_hang_ring(int fd, int ring)
if (!igt_check_boolean_env_var("IGT_HANG", true))
igt_skip("hang injection disabled by user");
+ igt_require_gem(fd);
gem_require_ring(fd, ring);
gem_context_require_bannable(fd);
if (!igt_check_boolean_env_var("IGT_HANG_WITHOUT_RESET", false))
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] igt/gem_gpgpu_fill: Check for GEM before use
2018-07-12 15:37 [igt-dev] [PATCH i-g-t 1/2] igt/gem_gpgpu_fill: Check for GEM before use Chris Wilson
2018-07-12 15:37 ` [Intel-gfx] [PATCH i-g-t 2/2] lib/gt: Check GEM is operation before injecting a hang Chris Wilson
@ 2018-07-12 18:30 ` Patchwork
2018-07-12 19:01 ` [Intel-gfx] [PATCH i-g-t 1/2] " Ville Syrjälä
2018-07-12 21:12 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-07-12 18:30 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/2] igt/gem_gpgpu_fill: Check for GEM before use
URL : https://patchwork.freedesktop.org/series/46408/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4476 -> IGTPW_1567 =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1567 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1567, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/46408/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1567:
=== IGT changes ===
==== Warnings ====
igt@pm_rpm@basic-rte:
fi-hsw-peppy: SKIP -> PASS +1
fi-hsw-4770r: SKIP -> PASS +1
fi-bdw-5557u: SKIP -> PASS +1
fi-hsw-4770: SKIP -> PASS +1
== Known issues ==
Here are the changes found in IGTPW_1567 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-no-display:
{fi-skl-iommu}: NOTRUN -> FAIL (fdo#106066) +2
igt@gem_basic@create-close:
fi-skl-6770hq: PASS -> DMESG-WARN (fdo#105541)
igt@gem_exec_suspend@basic-s3:
{fi-cfl-8109u}: PASS -> INCOMPLETE (fdo#107187)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-skl-guc: PASS -> FAIL (fdo#103191)
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: PASS -> FAIL (fdo#104008)
==== Possible fixes ====
igt@kms_flip@basic-flip-vs-dpms:
fi-skl-6700hq: DMESG-WARN (fdo#105998) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#105541 https://bugs.freedesktop.org/show_bug.cgi?id=105541
fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
fdo#106066 https://bugs.freedesktop.org/show_bug.cgi?id=106066
fdo#107187 https://bugs.freedesktop.org/show_bug.cgi?id=107187
== Participating hosts (45 -> 42) ==
Additional (2): fi-byt-j1900 fi-skl-iommu
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* IGT: IGT_4552 -> IGTPW_1567
CI_DRM_4476: b818fac0878147c6df45338cb515b9b7bd878b7f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1567: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1567/
IGT_4552: 5175aff31e00e17786ebb97aaaf25ddd38b5e72e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1567/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Intel-gfx] [PATCH i-g-t 1/2] igt/gem_gpgpu_fill: Check for GEM before use
2018-07-12 15:37 [igt-dev] [PATCH i-g-t 1/2] igt/gem_gpgpu_fill: Check for GEM before use Chris Wilson
2018-07-12 15:37 ` [Intel-gfx] [PATCH i-g-t 2/2] lib/gt: Check GEM is operation before injecting a hang Chris Wilson
2018-07-12 18:30 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] igt/gem_gpgpu_fill: Check for GEM before use Patchwork
@ 2018-07-12 19:01 ` Ville Syrjälä
2018-07-12 21:12 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Ville Syrjälä @ 2018-07-12 19:01 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx
On Thu, Jul 12, 2018 at 04:37:08PM +0100, Chris Wilson wrote:
> As we need GEM and the GPU to do a GPGPU fill, we should check that it
> is operable before using -- skipping rather than failing when the device
> is wedged.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Series is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tests/gem_gpgpu_fill.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/gem_gpgpu_fill.c b/tests/gem_gpgpu_fill.c
> index 8ef05a3f0..dfb581652 100644
> --- a/tests/gem_gpgpu_fill.c
> +++ b/tests/gem_gpgpu_fill.c
> @@ -104,6 +104,7 @@ igt_simple_main
>
> data.drm_fd = drm_open_driver_render(DRIVER_INTEL);
> data.devid = intel_get_drm_devid(data.drm_fd);
> + igt_require_gem(data.drm_fd);
>
> data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096);
> igt_assert(data.bufmgr);
> --
> 2.18.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] igt/gem_gpgpu_fill: Check for GEM before use
2018-07-12 15:37 [igt-dev] [PATCH i-g-t 1/2] igt/gem_gpgpu_fill: Check for GEM before use Chris Wilson
` (2 preceding siblings ...)
2018-07-12 19:01 ` [Intel-gfx] [PATCH i-g-t 1/2] " Ville Syrjälä
@ 2018-07-12 21:12 ` Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-07-12 21:12 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/2] igt/gem_gpgpu_fill: Check for GEM before use
URL : https://patchwork.freedesktop.org/series/46408/
State : failure
== Summary ==
= CI Bug Log - changes from IGT_4552_full -> IGTPW_1567_full =
== Summary - FAILURE ==
Serious unknown changes coming with IGTPW_1567_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1567_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/46408/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1567_full:
=== IGT changes ===
==== Possible regressions ====
igt@gem_exec_schedule@preemptive-hang-bsd1:
shard-kbl: PASS -> FAIL +4
igt@gem_exec_schedule@preemptive-hang-render:
shard-apl: PASS -> FAIL +3
igt@gem_exec_schedule@preemptive-hang-vebox:
shard-glk: PASS -> FAIL +3
==== Warnings ====
igt@gem_exec_schedule@deep-blt:
shard-kbl: PASS -> SKIP
igt@pm_rpm@cursor:
shard-hsw: SKIP -> PASS +34
== Known issues ==
Here are the changes found in IGTPW_1567_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_schedule@pi-ringfull-blt:
shard-glk: NOTRUN -> FAIL (fdo#103158)
igt@gem_pwrite_pread@uncached-copy-performance:
shard-snb: PASS -> INCOMPLETE (fdo#105411)
igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
shard-glk: PASS -> FAIL (fdo#105703)
igt@kms_available_modes_crc@available_mode_test_crc:
shard-snb: PASS -> FAIL (fdo#106641)
igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
shard-glk: PASS -> FAIL (fdo#105363) +1
igt@kms_flip@plain-flip-fb-recreate:
shard-glk: PASS -> FAIL (fdo#100368) +1
igt@kms_flip_tiling@flip-to-x-tiled:
shard-glk: PASS -> FAIL (fdo#107161)
igt@kms_flip_tiling@flip-x-tiled:
shard-glk: PASS -> FAIL (fdo#107161, fdo#103822)
igt@kms_frontbuffer_tracking@fbc-suspend:
shard-kbl: PASS -> INCOMPLETE (fdo#105959, fdo#103665)
==== Possible fixes ====
igt@gem_exec_async@concurrent-writes-blt:
shard-snb: INCOMPLETE (fdo#105411) -> PASS
igt@gem_ppgtt@blt-vs-render-ctx0:
shard-kbl: INCOMPLETE (fdo#103665, fdo#106023) -> PASS
igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled:
shard-glk: FAIL -> PASS
igt@kms_flip@2x-flip-vs-expired-vblank:
shard-glk: FAIL (fdo#105189) -> PASS
igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
shard-hsw: FAIL (fdo#100368) -> PASS
igt@kms_flip_tiling@flip-y-tiled:
shard-glk: FAIL (fdo#107161) -> PASS
igt@kms_rotation_crc@sprite-rotation-180:
shard-snb: FAIL (fdo#103925) -> PASS
igt@kms_setmode@basic:
shard-apl: FAIL (fdo#99912) -> PASS
shard-kbl: FAIL (fdo#99912) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#105189 https://bugs.freedesktop.org/show_bug.cgi?id=105189
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105703 https://bugs.freedesktop.org/show_bug.cgi?id=105703
fdo#105959 https://bugs.freedesktop.org/show_bug.cgi?id=105959
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#107161 https://bugs.freedesktop.org/show_bug.cgi?id=107161
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* IGT: IGT_4552 -> IGTPW_1567
* Linux: CI_DRM_4475 -> CI_DRM_4476
CI_DRM_4475: 1b6f049d73237a170919604538e747b0282b0109 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4476: b818fac0878147c6df45338cb515b9b7bd878b7f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1567: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1567/
IGT_4552: 5175aff31e00e17786ebb97aaaf25ddd38b5e72e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1567/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread